From 4b62e55220cd5dfe80a212a3595b298f9180e5d2 Mon Sep 17 00:00:00 2001
From: Oliver Hamlet <oliver@ortham.io>
Date: Mon, 7 Feb 2022 00:37:10 +0000
Subject: [PATCH] Fix MSVC warning C26478

Relating to C++ Core Guidelines es.56.
---
 src/api/game/game_cache.cpp | 2 +-
 src/api/game/game_cache.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/api/game/game_cache.cpp b/src/api/game/game_cache.cpp
index 5fde7ec8..cf8cb43c 100644
--- a/src/api/game/game_cache.cpp
+++ b/src/api/game/game_cache.cpp
@@ -94,7 +94,7 @@ std::shared_ptr<const Plugin> GameCache::GetPlugin(
   return nullptr;
 }
 
-void GameCache::AddPlugin(const Plugin&& plugin) {
+void GameCache::AddPlugin(Plugin&& plugin) {
   lock_guard<mutex> lock(mutex_);
 
   auto normalizedName = NormalizeFilename(plugin.GetName());
diff --git a/src/api/game/game_cache.h b/src/api/game/game_cache.h
index 7f072fcb..4ecf1465 100644
--- a/src/api/game/game_cache.h
+++ b/src/api/game/game_cache.h
@@ -44,7 +44,7 @@ public:
 
   std::vector<std::shared_ptr<const Plugin>> GetPlugins() const;
   std::shared_ptr<const Plugin> GetPlugin(const std::string& pluginName) const;
-  void AddPlugin(const Plugin&& plugin);
+  void AddPlugin(Plugin&& plugin);
 
   std::set<std::filesystem::path> GetArchivePaths() const;
   void CacheArchivePaths(std::set<std::filesystem::path>&& paths);