From 0d6c0c70bee4a82b4e78a09e030a9751acd61943 Mon Sep 17 00:00:00 2001
From: Oliver Hamlet <oliver.hamlet@gmail.com>
Date: Thu, 12 May 2016 21:10:24 +0100
Subject: [PATCH] Fix first-time tips not displaying

If settings.yaml is deleted or the lastVersion key is missing.
---
 src/gui/loot_settings.cpp          | 3 +--
 src/tests/gui/loot_settings_test.h | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/gui/loot_settings.cpp b/src/gui/loot_settings.cpp
index f0961597..434a71a9 100644
--- a/src/gui/loot_settings.cpp
+++ b/src/gui/loot_settings.cpp
@@ -50,8 +50,7 @@ namespace loot {
         updateMasterlist(true),
         game("auto"),
         language(Language(Language::english)),
-        lastGame("auto"),
-        lastVersion(std::to_string(g_version_major) + "." + std::to_string(g_version_minor) + "." + std::to_string(g_version_patch)) {}
+        lastGame("auto") {}
 
     void LootSettings::load(YAML::Node& settings) {
         std::lock_guard<std::recursive_mutex> guard(mutex);
diff --git a/src/tests/gui/loot_settings_test.h b/src/tests/gui/loot_settings_test.h
index d9a4a44b..4602b5f6 100644
--- a/src/tests/gui/loot_settings_test.h
+++ b/src/tests/gui/loot_settings_test.h
@@ -64,7 +64,7 @@ namespace loot {
 
             const YAML::Node node = settings.toYaml();
             EXPECT_TRUE(node["updateMasterlist"].as<bool>());
-            EXPECT_EQ(currentVersion, node["lastVersion"].as<std::string>());
+            EXPECT_TRUE(node["lastVersion"].as<std::string>().empty());
             EXPECT_FALSE(node["filters"]);
 
             // GameSettings equality only checks name and folder, so check