mirror of
https://github.com/linux-msm/qdl.git
synced 2026-10-07 06:29:17 -07:00
Igor Opaniuk
75ac9bcb20
Without any verification on the host side, a dry-run with pre-built VIP tables (-n -D <path>) would silently succeed even when the digest tables did not match the data being flashed. The only way to catch a mismatch was to attempt a real flash and wait for the device to reject it, which wastes time and risks leaving a device in a broken state. Add hash validation to the simulator so mismatches are caught at dry-run time, before any hardware is involved. The signed initial table (DigestsToSign.bin.mbn) and all chained tables (ChainedTableOfDigests<n>.bin) are parsed as they arrive. Chain hashes linking each table to the next are verified to ensure table integrity. Per-chunk SHA256 hashes are checked in order against every XML command write and raw payload write; any mismatch is reported via ux_err() without aborting so all mismatches remain visible at the end of a run. Validation is active in exactly the intended modes: -n plain dry-run, no tables sent -- no-op -n -D <path> dry-run with VIP tables -- full hash validation -n -t <dir> digest generation -- validation disabled MAX_DIGESTS_PER_SIGNED_FILE and MAX_DIGESTS_PER_CHAINED_FILE are moved from vip.c to vip.h so sim.c can reference them. sha2.c is added to RAMDUMP_SRCS because qdl-ramdump links sim.o which now calls SHA256. Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
93 lines
2.9 KiB
Makefile
93 lines
2.9 KiB
Makefile
QDL := qdl
|
|
RAMDUMP := qdl-ramdump
|
|
VERSION := $(or $(VERSION), $(shell git describe --dirty --always --tags 2>/dev/null), "unknown-version")
|
|
|
|
PKG_CONFIG ?= pkg-config
|
|
CFLAGS += -O2 -Wall -g `$(PKG_CONFIG) --cflags libxml-2.0 libusb-1.0`
|
|
LDFLAGS += `$(PKG_CONFIG) --libs libxml-2.0 libusb-1.0`
|
|
ifeq ($(OS),Windows_NT)
|
|
LDFLAGS += -lws2_32
|
|
endif
|
|
prefix := /usr/local
|
|
|
|
QDL_SRCS := firehose.c io.c qdl.c sahara.c util.c patch.c program.c read.c sha2.c sim.c ufs.c usb.c ux.c oscompat.c vip.c sparse.c gpt.c
|
|
QDL_OBJS := $(QDL_SRCS:.c=.o)
|
|
|
|
RAMDUMP_SRCS := ramdump.c sahara.c io.c sim.c sha2.c usb.c util.c ux.c oscompat.c
|
|
RAMDUMP_OBJS := $(RAMDUMP_SRCS:.c=.o)
|
|
|
|
KS_OUT := ks
|
|
KS_SRCS := ks.c sahara.c util.c ux.c oscompat.c
|
|
KS_OBJS := $(KS_SRCS:.c=.o)
|
|
|
|
CHECKPATCH_SOURCES := $(shell find . -type f \( -name "*.c" -o -name "*.h" -o -name "*.sh" \) ! -name "sha2.c" ! -name "sha2.h" ! -name "*version.h" ! -name "list.h")
|
|
CHECKPATCH_ROOT := https://raw.githubusercontent.com/torvalds/linux/v6.15/scripts
|
|
CHECKPATCH_URL := $(CHECKPATCH_ROOT)/checkpatch.pl
|
|
CHECKPATCH_SP_URL := $(CHECKPATCH_ROOT)/spelling.txt
|
|
CHECKPATCH := ./.scripts/checkpatch.pl
|
|
CHECKPATCH_SP := ./.scripts/spelling.txt
|
|
|
|
MANPAGES := ks.1 qdl-ramdump.1 qdl.1
|
|
|
|
default: $(QDL) $(RAMDUMP) $(KS_OUT)
|
|
|
|
$(QDL): $(QDL_OBJS)
|
|
$(CC) -o $@ $^ $(LDFLAGS)
|
|
|
|
$(RAMDUMP): $(RAMDUMP_OBJS)
|
|
$(CC) -o $@ $^ $(LDFLAGS)
|
|
|
|
$(KS_OUT): $(KS_OBJS)
|
|
$(CC) -o $@ $^ $(LDFLAGS)
|
|
|
|
compile_commands.json: $(QDL_SRCS) $(KS_SRCS)
|
|
@echo -n $^ | jq -snR "[inputs|split(\" \")[]|{directory:\"$(PWD)\", command: \"$(CC) $(CFLAGS) -c \(.)\", file:.}]" > $@
|
|
|
|
manpages: $(KS_OUT) $(RAMDUMP) $(QDL)
|
|
help2man -N -n "KS" -o ks.1 ./ks
|
|
help2man -N -n "Qualcomm Download" -o qdl.1 ./qdl
|
|
help2man -N -n "Qualcomm Download Ramdump" -o qdl-ramdump.1 ./qdl-ramdump
|
|
|
|
version.h::
|
|
@echo "#define VERSION \"$(VERSION)\"" > .version.h
|
|
@cmp -s .version.h version.h || cp .version.h version.h
|
|
|
|
util.o: version.h
|
|
|
|
clean:
|
|
rm -f $(QDL) $(QDL_OBJS)
|
|
rm -f $(RAMDUMP) $(RAMDUMP_OBJS)
|
|
rm -f $(KS_OUT) $(KS_OBJS)
|
|
rm -f $(MANPAGES)
|
|
rm -f compile_commands.json
|
|
rm -f version.h .version.h
|
|
rm -f $(CHECKPATCH)
|
|
rm -f $(CHECKPATCH_SP)
|
|
if [ -d .scripts ]; then rmdir .scripts; fi
|
|
|
|
install: $(QDL) $(RAMDUMP) $(KS_OUT)
|
|
install -d $(DESTDIR)$(prefix)/bin
|
|
install -m 755 $^ $(DESTDIR)$(prefix)/bin
|
|
|
|
tests: default
|
|
tests:
|
|
@./tests/run_tests.sh
|
|
|
|
# Target to download checkpatch.pl if not present
|
|
$(CHECKPATCH):
|
|
@echo "Downloading checkpatch.pl..."
|
|
@mkdir -p $(dir $(CHECKPATCH))
|
|
@curl -sSfL $(CHECKPATCH_URL) -o $(CHECKPATCH)
|
|
@curl -sSfL $(CHECKPATCH_SP_URL) -o $(CHECKPATCH_SP)
|
|
@chmod +x $(CHECKPATCH)
|
|
|
|
check: $(CHECKPATCH)
|
|
@echo "Running checkpatch on source files (excluding sha2.c and sha2.h)..."
|
|
@for file in $(CHECKPATCH_SOURCES); do \
|
|
perl $(CHECKPATCH) --no-tree -f $$file || exit 1; \
|
|
done
|
|
|
|
check-cached: $(CHECKPATCH)
|
|
@echo "Running checkpatch on staged changes..."
|
|
@git diff --cached -- . | perl $(CHECKPATCH) --no-tree -
|