mirror of
https://github.com/linux-msm/qdl.git
synced 2026-02-25 13:12:25 -08:00
cbd46184d3
Since commit 760b3dffb0 ("qdl: Rework qdl_write to limit write sizes
to out_maxpktsize") outgoing transfers has been chunked into blocks of
wMaxPacketSize.
As reported by Wiktor Drewniak, Maksim Paimushkin, and Luca Weiss in [1]
there's huge benefits to be found in reverting this change, but out of
caution the limit was untouched.
With the transition to libusb, the throughput dropped another ~15% on my
machine. The numbers for HighSpeed and SuperSpeed are also in the same
ballpark.
With SuperSpeed, benchmarking of different chunk sizes in the megabyte
range shows improvement over these numbers in the range of 15-20x on the
same machine/board combination.
The bug report related to the reduction in size describes a host machine
running out of swiotlb, from the fact that we requested 1MB physically
contiguous memory. It's unclear if attempts was made to correct the
kernel's behavior. libusb does inquiry the capabilities of the kernel
and will split the buffer and submitting multiple URBs at once, as
needed. While no definitive guidance has been found, multiple sources
seems to recommend passing 1-2MB of buffer to libusb at a time. So,
let's move the default chunk size back up to 1MB and hope that libusb
resolves the reported problem.
Additionally, introduce a new option --out-chunk-size, which allow the
user to override the chunk size. This would allow any user to reduce the
size if needed, but also allow the value to be increased as needed.
[1] https://github.com/linux-msm/qdl/pull/39
Reported-by: Wiktor Drewniak
Reported-by: Maksim Paimushkin
Reported-by: Luca Weiss
Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
44 lines
1.2 KiB
C
44 lines
1.2 KiB
C
#ifndef __QDL_H__
|
|
#define __QDL_H__
|
|
|
|
#include <stdbool.h>
|
|
|
|
#include "patch.h"
|
|
#include "program.h"
|
|
#include "read.h"
|
|
#include <libxml/tree.h>
|
|
|
|
#define MAPPING_SZ 64
|
|
|
|
struct libusb_device_handle;
|
|
|
|
struct qdl_device {
|
|
struct libusb_device_handle *usb_handle;
|
|
int fd;
|
|
|
|
int in_ep;
|
|
int out_ep;
|
|
|
|
size_t in_maxpktsize;
|
|
size_t out_maxpktsize;
|
|
size_t out_chunk_size;
|
|
|
|
char *mappings[MAPPING_SZ]; // array index is the id from the device
|
|
};
|
|
|
|
int qdl_open(struct qdl_device *qdl, const char *serial);
|
|
int qdl_read(struct qdl_device *qdl, void *buf, size_t len, unsigned int timeout);
|
|
int qdl_write(struct qdl_device *qdl, const void *buf, size_t len);
|
|
void qdl_set_out_chunk_size(struct qdl_device *qdl, long size);
|
|
|
|
int firehose_run(struct qdl_device *qdl, const char *incdir, const char *storage);
|
|
int sahara_run(struct qdl_device *qdl, char *img_arr[], bool single_image,
|
|
const char *ramdump_path, const char *ramdump_filter);
|
|
void print_hex_dump(const char *prefix, const void *buf, size_t len);
|
|
unsigned attr_as_unsigned(xmlNode *node, const char *attr, int *errors);
|
|
const char *attr_as_string(xmlNode *node, const char *attr, int *errors);
|
|
|
|
extern bool qdl_debug;
|
|
|
|
#endif
|