Linux checkpatch.pl expects a Closes: trailer followed by a public URL,
while commitlint's default parser only treats GitHub-style "hash-number"
references as issue footers. Commits carrying a kernel-style Closes: tag
therefore trip commitlint's footer parsing.
Add Closes to the noteKeywords list, alongside the other kernel-style
trailers already recognized there, so commitlint treats it as the start
of the footer instead of misparsing the body.
Reported-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Closes: https://github.com/linux-msm/qdl/issues/318
Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Kernel-style commit bodies occasionally wrap a sentence or an
example command a few characters past 72, which tripped
commitlint's body-max-line-length even though the messages are
otherwise fine. Raise the body limit from 72 to 75 to match the
wrapping already used in the tree.
Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
The config relaxes footer-max-line-length to 200 specifically to
accommodate long Signed-off-by addresses, but commitlint's default
parser only treats `BREAKING CHANGE` as a note keyword. Other
kernel-style trailers (Fixes, Reviewed-by, Tested-by, ...) get
classified as body lines, so a trailer that exceeds 72 characters --
typically a `Fixes:` quoting a long commit subject -- trips
body-max-line-length even though the relaxed footer limit was meant
to cover exactly this case.
Configure parserPreset.parserOpts.noteKeywords with the trailer
tokens this project uses, so those lines move into the footer
section and inherit the existing footer-max-line-length=200 rule.
Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Malformed commit messages (overlong lines, missing blank line between
subject and body) have slipped through review. Automate the check in
CI so every PR is validated before merge.
Uses commitlint with a Linux kernel-style config: 72-char limit on
subject and body lines, blank-line rules enforced, Conventional
Commits type enforcement disabled.
Signed-off-by: Igor Opaniuk <igor.opaniuk@oss.qualcomm.com>
Igor Opaniuk