From aeb70e0645d6583b34b99c3025ebd2b8475d322b Mon Sep 17 00:00:00 2001 From: Konrad Dybcio Date: Wed, 15 May 2024 00:43:31 +0200 Subject: [PATCH] firehose: Prevent potential overflow in info print also fixes the improper format specifier i suppose CodeQL reports: Multiplication result may overflow 'unsigned int' before it is converted to 'long'. Signed-off-by: Konrad Dybcio --- firehose.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/firehose.c b/firehose.c index 974180c..da3ed31 100644 --- a/firehose.c +++ b/firehose.c @@ -417,9 +417,9 @@ static int firehose_program(struct qdl_device *qdl, struct program *program, int fprintf(stderr, "[PROGRAM] failed\n"); } else if (t) { fprintf(stderr, - "[PROGRAM] flashed \"%s\" successfully at %ldkB/s\n", + "[PROGRAM] flashed \"%s\" successfully at %lukB/s\n", program->label, - program->sector_size * num_sectors / t / 1024); + (unsigned long)program->sector_size * num_sectors / t / 1024); } else { fprintf(stderr, "[PROGRAM] flashed \"%s\" successfully\n", program->label);