From 2d5d8a5a621811d0ea58d3bdb90afc17f0cce4ac Mon Sep 17 00:00:00 2001 From: Erhan Kurubas Date: Wed, 5 Oct 2022 00:49:23 +0200 Subject: [PATCH] target/esp32s2: check xtensa_poll return value Although scan build couldn't catch, return value overwritten without checking. Signed-off-by: Erhan Kurubas Change-Id: I02b10002b03640604315047e8a8a639824724c16 Reviewed-on: https://review.openocd.org/c/openocd/+/7247 Tested-by: jenkins Reviewed-by: Ian Thompson Reviewed-by: Antonio Borneo --- src/target/espressif/esp32s2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/target/espressif/esp32s2.c b/src/target/espressif/esp32s2.c index 62d1ddb1d..64fa69057 100644 --- a/src/target/espressif/esp32s2.c +++ b/src/target/espressif/esp32s2.c @@ -402,6 +402,8 @@ static int esp32s2_poll(struct target *target) { enum target_state old_state = target->state; int ret = esp_xtensa_poll(target); + if (ret != ERROR_OK) + return ret; if (old_state != TARGET_HALTED && target->state == TARGET_HALTED) { /* Call any event callbacks that are applicable */