Yu Kuai
aba3d6d6cb
md/md-bitmap: split bitmap sysfs groups
...
Split the classic bitmap sysfs files into a common bitmap group with
the location attribute and a separate internal bitmap group for the
remaining files.
At the same time, convert bitmap operations from a single sysfs group
to a sysfs group array so backends can share part of their sysfs
layout while adding backend-specific attributes separately.
Switch the bitmap sysfs helpers to use sysfs_update_groups() for the
add and update path, and remove groups in reverse order so shared named
groups are unmerged before the last group removes the directory.
Also make bitmap operation lookup depend only on the currently selected
bitmap id matching the installed backend. This prepares the lookup path
for a later registered none backend.
Reviewed-by: Su Yue <glass.su@suse.com >
Link: https://lore.kernel.org/r/20260425024615.1696892-3-yukuai@fnnas.com
Signed-off-by: Yu Kuai <yukuai@fnnas.com >
2026-04-28 20:44:37 +08:00
Yu Kuai
5ab829f197
md/md-llbitmap: introduce new lockless bitmap
...
Redundant data is used to enhance data fault tolerance, and the storage
method for redundant data vary depending on the RAID levels. And it's
important to maintain the consistency of redundant data.
Bitmap is used to record which data blocks have been synchronized and which
ones need to be resynchronized or recovered. Each bit in the bitmap
represents a segment of data in the array. When a bit is set, it indicates
that the multiple redundant copies of that data segment may not be
consistent. Data synchronization can be performed based on the bitmap after
power failure or readding a disk. If there is no bitmap, a full disk
synchronization is required.
Due to known performance issues with md-bitmap and the unreasonable
implementations:
- self-managed IO submitting like filemap_write_page();
- global spin_lock
I have decided not to continue optimizing based on the current bitmap
implementation, this new bitmap is invented without locking from IO fast
path and can be used with fast disks.
For designs and details, see the comments in drivers/md-llbitmap.c.
Link: https://lore.kernel.org/linux-raid/20250829080426.1441678-12-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Li Nan <linan122@huawei.com >
2025-09-06 17:27:51 +08:00
Yu Kuai
a4dd9ba39b
md/md-bitmap: add a new method blocks_synced() in bitmap_operations
...
Currently, raid456 must perform a whole array initial recovery to build
initail xor data, then IO to the array won't have to read all the blocks
in underlying disks.
This behavior will affect IO performance a lot, and nowadays there are
huge disks and the initial recovery can take a long time. Hence llbitmap
will support lazy initial recovery in following patches. This method is
used to check if data blocks is synced or not, if not then IO will still
have to read all blocks for raid456.
Link: https://lore.kernel.org/linux-raid/20250829080426.1441678-9-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
2025-09-06 17:20:01 +08:00
Yu Kuai
f196d72888
md/md-bitmap: add a new method skip_sync_blocks() in bitmap_operations
...
This method is used to check if blocks can be skipped before calling
into pers->sync_request(), llbitmap will use this method to skip
resync for unwritten/clean data blocks, and recovery/check/repair for
unwritten data blocks;
Link: https://lore.kernel.org/linux-raid/20250829080426.1441678-8-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Christoph Hellwig <hch@lst.de >
Reviewed-by: Xiao Ni <xni@redhat.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Reviewed-by: Li Nan <linan122@huawei.com >
2025-09-06 17:19:45 +08:00
Yu Kuai
ac9dad8faa
md/md-bitmap: support discard for bitmap ops
...
Use two new methods {start, end}_discard in bitmap_ops and a new field 'rw'
in struct md_io_clone to handle discard IO, prepare to support new md
bitmap.
Since all bitmap functions to hanlde write IO are the same, also add
typedef to make code cleaner.
Link: https://lore.kernel.org/linux-raid/20250829080426.1441678-4-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Reviewed-by: Li Nan <linan122@huawei.com >
2025-09-06 17:18:19 +08:00
Yu Kuai
c27474ac1d
md/md-bitmap: introduce CONFIG_MD_BITMAP
...
Now that all implementations are internal, it's sensible to add a config
option for md-bitmap, and it's a good way for isolation.
Link: https://lore.kernel.org/linux-raid/20250707012711.376844-16-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
2025-09-06 17:12:22 +08:00
Yu Kuai
bb74b093c3
md/md-bitmap: handle the case bitmap is not enabled before end_sync()
...
This case can be handled without knowing internal implementation.
Prepare to introduce CONFIG_MD_BITMAP.
Link: https://lore.kernel.org/linux-raid/20250707012711.376844-9-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
2025-09-06 17:11:54 +08:00
Yu Kuai
5ae58d1500
md/md-bitmap: handle the case bitmap is not enabled before start_sync()
...
This case can be handled without knowing internal implementation.
Prepare to introduce CONFIG_MD_BITMAP.
Link: https://lore.kernel.org/linux-raid/20250707012711.376844-8-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
2025-09-06 17:11:50 +08:00
Yu Kuai
110332074d
md/md-bitmap: add md_bitmap_registered/enabled() helper
...
There are no functional changes, prepare to handle the case that
mddev->bitmap_ops can be NULL, which is possible after introducing
CONFIG_MD_BITMAP.
Link: https://lore.kernel.org/linux-raid/20250707012711.376844-7-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
2025-09-06 17:11:45 +08:00
Yu Kuai
9c41ead04e
md/md-bitmap: add a new parameter 'flush' to bitmap_ops->enabled
...
The method is only used from raid1/raid10 IO path, to check if write
bio should be pluged, the parameter is always set to true for now,
following patch will use this helper in other context like updating
superblock.
Link: https://lore.kernel.org/linux-raid/20250707012711.376844-6-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
2025-09-06 17:11:42 +08:00
Yu Kuai
9307dbac0e
md/md-bitmap: merge md_bitmap_group into bitmap_operations
...
Now that all bitmap implementations are internal, it doesn't make sense
to export md_bitmap_group anymore.
Link: https://lore.kernel.org/linux-raid/20250707012711.376844-5-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
2025-09-06 17:11:40 +08:00
Yu Kuai
e57b225c28
md/md-bitmap: remove the parameter 'init' for bitmap_ops->resize()
...
It's set to 'false' for all callers, hence it's useless and can be
removed.
Link: https://lore.kernel.org/linux-raid/20250707012711.376844-3-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
2025-09-06 17:11:33 +08:00
Yu Kuai
01bf468c4e
md/md-bitmap: remove parameter slot from bitmap_create()
...
All callers pass in '-1' for 'slot', hence it can be removed.
Link: https://lore.kernel.org/linux-raid/20250524061320.370630-6-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Christoph Hellwig <hch@lst.de >
Reviewed-by: Xiao Ni <xni@redhat.com >
Reviewed-by: Christoph Hellwig <hch@lst.de >
Reviewed-by: Hannes Reinecke <hare@suse.de >
2025-05-30 15:47:23 +08:00
Yu Kuai
38f520a37d
md/md-bitmap: cleanup bitmap_ops->startwrite()
...
bitmap_startwrite() always return 0, and the caller doesn't check return
value as well, hence change the method to void.
Also rename startwrite/endwrite to start_write/end_write, which is more in
line with the usual naming convention.
Link: https://lore.kernel.org/linux-raid/20250524061320.370630-4-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
Reviewed-by: Christoph Hellwig <hch@lst.de >
Reviewed-by: Hannes Reinecke <hare@suse.de >
2025-05-30 15:47:23 +08:00
Yu Kuai
b886475804
md/dm-raid: remove max_write_behind setting limit
...
The comments said 'vaule in kB', while the value actually means the
number of write_behind IOs. And since md-bitmap will automatically
adjust the value to max COUNTER_MAX / 2, there is no need to fail
early.
Also move some macros that is only used md-bitmap.c.
Link: https://lore.kernel.org/linux-raid/20250524061320.370630-15-yukuai1@huaweicloud.com
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Christoph Hellwig <hch@lst.de >
Reviewed-by: Hannes Reinecke <hare@suse.de >
Reviewed-by: Xiao Ni <xni@redhat.com >
2025-05-30 15:47:23 +08:00
Yu Kuai and Song Liu
4f0e7d0e03
md/md-bitmap: remove the last parameter for bimtap_ops->endwrite()
...
For the case that IO failed for one rdev, the bit will be mark as NEEDED
in following cases:
1) If badblocks is set and rdev is not faulty;
2) If rdev is faulty;
Case 1) is useless because synchronize data to badblocks make no sense.
Case 2) can be replaced with mddev->degraded.
Also remove R1BIO_Degraded, R10BIO_Degraded and STRIPE_DEGRADED since
case 2) no longer use them.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Link: https://lore.kernel.org/r/20250109015145.158868-3-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2025-01-13 08:56:10 -08:00
Yu Kuai and Song Liu
08c50142a1
md/md-bitmap: factor behind write counters out from bitmap_{start/end}write()
...
behind_write is only used in raid1, prepare to refactor
bitmap_{start/end}write(), there are no functional changes.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Reviewed-by: Xiao Ni <xni@redhat.com >
Link: https://lore.kernel.org/r/20250109015145.158868-2-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2025-01-13 08:56:10 -08:00
Yu Kuai and Song Liu
59fdd43304
md/md-bitmap: make in memory structure internal
...
Now that struct bitmap_page and bitmap is not used externally anymore,
move them from md-bitmap.h to md-bitmap.c (expect that dm-raid is still
using define marco 'COUNTER_MAX').
Also fix some checkpatch warnings.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Link: https://lore.kernel.org/r/20240826074452.1490072-43-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2024-08-27 12:43:16 -07:00
Yu Kuai and Song Liu
dab2ce5534
md/md-bitmap: merge md_bitmap_enabled() into bitmap_operations
...
So that the implementation won't be exposed, and it'll be possible
to invent a new bitmap by replacing bitmap_operations.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Link: https://lore.kernel.org/r/20240826074452.1490072-42-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2024-08-27 12:43:16 -07:00
Yu Kuai and Song Liu
49f5f5e309
md/md-bitmap: merge md_bitmap_wait_behind_writes() into bitmap_operations
...
So that the implementation won't be exposed, and it'll be possible
to invent a new bitmap by replacing bitmap_operations.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Link: https://lore.kernel.org/r/20240826074452.1490072-41-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2024-08-27 12:43:16 -07:00
Yu Kuai and Song Liu
c65c20dc50
md/md-bitmap: merge md_bitmap_free() into bitmap_operations
...
So that the implementation won't be exposed, and it'll be possible
o invent a new bitmap by replacing bitmap_operations.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Link: https://lore.kernel.org/r/20240826074452.1490072-40-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2024-08-27 12:43:15 -07:00
Yu Kuai and Song Liu
ef1c400faf
md/md-bitmap: merge md_bitmap_set_pages() into struct bitmap_operations
...
o that the implementation won't be exposed, and it'll be possible
o invent a new bitmap by replacing bitmap_operations.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Link: https://lore.kernel.org/r/20240826074452.1490072-39-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2024-08-27 12:43:15 -07:00
Yu Kuai and Song Liu
3dd9141a15
md/md-bitmap: merge md_bitmap_copy_from_slot() into struct bitmap_operation.
...
So that the implementation won't be exposed, and it'll be possible
to invent a new bitmap by replacing bitmap_operations.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Link: https://lore.kernel.org/r/20240826074452.1490072-38-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2024-08-27 12:43:15 -07:00
Yu Kuai and Song Liu
57d602414d
md/md-bitmap: merge get_bitmap_from_slot() into bitmap_operations
...
So that the implementation won't be exposed, and it'll be possible
to invent a new bitmap by replacing bitmap_operations.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Link: https://lore.kernel.org/r/20240826074452.1490072-37-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2024-08-27 12:43:15 -07:00
Yu Kuai and Song Liu
77c09640ee
md/md-bitmap: merge md_bitmap_resize() into bitmap_operations
...
So that the implementation won't be exposed, and it'll be possible
to invent a new bitmap by replacing bitmap_operations.
Signed-off-by: Yu Kuai <yukuai3@huawei.com >
Link: https://lore.kernel.org/r/20240826074452.1490072-36-yukuai1@huaweicloud.com
Signed-off-by: Song Liu <song@kernel.org >
2024-08-27 12:43:15 -07:00
Yu Kuai
Yu Kuai
