From 7c5c46b52f05e87ef2e0984bcb377c20b2ab4e4b Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Mon, 13 Jul 2026 21:27:38 +0800 Subject: [PATCH] HSI: nokia-modem: Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang Link: https://patch.msgid.link/20260713132747.394970-2-panchuang@vivo.com Signed-off-by: Sebastian Reichel --- drivers/hsi/clients/nokia-modem.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c index 97ba59e60663..88924d757616 100644 --- a/drivers/hsi/clients/nokia-modem.c +++ b/drivers/hsi/clients/nokia-modem.c @@ -157,11 +157,8 @@ static int nokia_modem_probe(struct device *dev) do_nokia_modem_rst_ind_tasklet, (unsigned long)modem); err = devm_request_irq(dev, irq, nokia_modem_rst_ind_isr, pflags, "modem_rst_ind", modem); - if (err < 0) { - dev_err(dev, "Request rst_ind irq(%d) failed (flags %d)\n", - irq, pflags); + if (err < 0) return err; - } enable_irq_wake(irq); if (pm) {