From 70450fcfd28ad3d5a6ac77986497be1c28721eb2 Mon Sep 17 00:00:00 2001 From: Jan Kara Date: Thu, 26 Mar 2026 10:53:58 +0100 Subject: [PATCH] ocfs2: Drop pointless sync_mapping_buffers() calls ocfs2 never calls mark_buffer_dirty_inode() and thus its metadata buffers list is always empty. Drop the pointless sync_mapping_buffers() calls. CC: Joel Becker CC: Joseph Qi CC: ocfs2-devel@lists.linux.dev Signed-off-by: Jan Kara Link: https://patch.msgid.link/20260326095354.16340-46-jack@suse.cz Tested-by: syzbot@syzkaller.appspotmail.com Reviewed-by: Joseph Qi Signed-off-by: Christian Brauner --- fs/ocfs2/dlmglue.c | 1 - fs/ocfs2/namei.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index bd2ddb7d841d..7283bb2c5a31 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c @@ -3971,7 +3971,6 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres, mlog(ML_ERROR, "Could not sync inode %llu for downconvert!", (unsigned long long)OCFS2_I(inode)->ip_blkno); } - sync_mapping_buffers(mapping); if (blocking == DLM_LOCK_EX) { truncate_inode_pages(mapping, 0); } else { diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 268b79339a51..1277666c77cd 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -1683,9 +1683,6 @@ bail: if (rename_lock) ocfs2_rename_unlock(osb); - if (new_inode) - sync_mapping_buffers(old_inode->i_mapping); - iput(new_inode); ocfs2_free_dir_lookup_result(&target_lookup_res);