From 57c3c67fce95ab0d449d3f6ae339621fcb61080e Mon Sep 17 00:00:00 2001 From: Bradford Love Date: Thu, 12 Mar 2026 16:35:28 -0500 Subject: [PATCH] media: si2168: fw 4.0-11 loses warm state during sleep Ignoring version 4.0-11 firmware leads to non functional devices after sleep on all Hauppauge DVB devices containing the si2168 and firmware version 4.0-11. Signed-off-by: Bradford Love Signed-off-by: Hans Verkuil --- drivers/media/dvb-frontends/si2168.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/si2168.c b/drivers/media/dvb-frontends/si2168.c index b973d61c3720..9c5bac8cda47 100644 --- a/drivers/media/dvb-frontends/si2168.c +++ b/drivers/media/dvb-frontends/si2168.c @@ -574,8 +574,8 @@ static int si2168_sleep(struct dvb_frontend *fe) if (ret) goto err; - /* Firmware later than B 4.0-11 loses warm state during sleep */ - if (dev->version > ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0)) + /* Firmware B 4.0-11 and later lose warm state during sleep */ + if (dev->version >= ('B' << 24 | 4 << 16 | 0 << 8 | 11 << 0)) dev->warm = false; cmd_init(&cmd, "\x13", 1, 0);