From 1cfeeec9f0ff0d3cb2b5ac45964d89598e737550 Mon Sep 17 00:00:00 2001 From: Batu Ada Tutkun Date: Tue, 23 Jun 2026 15:35:08 +0300 Subject: [PATCH] staging: most: dim2: use dev_err_probe() for clock errors in rcar enable functions rcar_gen2_enable() and rcar_gen3_enable() use the old pattern of dev_err() followed by return PTR_ERR() when devm_clk_get() fails. fsl_mx6_enable() in the same file was already converted to use dev_err_probe() by a previous cleanup series. Convert the remaining two functions for consistency. devm_clk_get() calls clk_get() which can return -EPROBE_DEFER if the clock provider has not yet registered. Using dev_err_probe() suppresses the log at error level in that case, avoiding misleading "cannot get clock" output during a normal deferred probe. clk_prepare_enable() cannot return -EPROBE_DEFER since the clock handle is already acquired at that point, so those error paths are left as dev_err(). Assisted-by: Claude:claude-sonnet-4-6 Signed-off-by: Batu Ada Tutkun Reviewed-by: Dan Carpenter Link: https://patch.msgid.link/6a4ff7ac.cef1946f.13cfe2.dd63@mx.google.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/most/dim2/dim2.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index ec0e568ec12d..0e2512d16632 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -974,10 +974,9 @@ static int rcar_gen2_enable(struct platform_device *pdev) int ret; dev->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "cannot get clock\n"); - return PTR_ERR(dev->clk); - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "cannot get clock\n"); ret = clk_prepare_enable(dev->clk); if (ret) { @@ -1019,10 +1018,9 @@ static int rcar_gen3_enable(struct platform_device *pdev) int ret; dev->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(dev->clk)) { - dev_err(&pdev->dev, "cannot get clock\n"); - return PTR_ERR(dev->clk); - } + if (IS_ERR(dev->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(dev->clk), + "cannot get clock\n"); ret = clk_prepare_enable(dev->clk); if (ret) {