Alberto GarciaandMax Reitz 8e958260c5 qcow2: Make preallocate_co() resize the image to the correct size ...

This function preallocates metadata structures and then extends the
image to its new size, but that new size calculation is wrong because
it doesn't take into account that the host_offset variable is always
cluster-aligned.

This problem can be reproduced with preallocation=metadata when the
original size is not cluster-aligned but the new size is. In this case
the final image size will be shorter than expected.

   qemu-img create -f qcow2 img.qcow2 31k
   qemu-img resize --preallocation=metadata img.qcow2 128k

Signed-off-by: Alberto Garcia <berto@igalia.com>
Message-Id: <adeb8b059917b141d5f5b3bd2a016262d3052c79.1599833007.git.berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
[mreitz: Mark compat=0.10 unsupported for iotest 125]
Signed-off-by: Max Reitz <mreitz@redhat.com>

2020-09-15 11:30:36 +02:00

..

acceptance

…

data

…

decode

…

docker

…

fp

…

guest-debug

…

image-fuzzer

…

include

…

keys

…

migration

…

multiboot

…

perf/block/qcow2

…

plugin

…

qapi-schema

…

qemu-iotests

qcow2: Make preallocate_co() resize the image to the correct size

2020-09-15 11:30:36 +02:00

qtest

…

rocker

…

tcg

…

tsan

…

uefi-test-tools

…

vm

…

vmstate-static-checker-data

…

.gitignore

…

atomic64-bench.c

…

atomic_add-bench.c

…

benchmark-crypto-cipher.c

…

benchmark-crypto-hash.c

…

benchmark-crypto-hmac.c

…

check-block-qdict.c

…

check-block.sh

…

check-qdict.c

…

check-qjson.c

…

check-qlist.c

…

check-qlit.c

…

check-qnull.c

…

check-qnum.c

…

check-qobject.c

…

check-qom-interface.c

…

check-qom-proplist.c

…

check-qstring.c

…

crypto-tls-psk-helpers.c

…

crypto-tls-psk-helpers.h

…

crypto-tls-x509-helpers.c

…

crypto-tls-x509-helpers.h

…

dbus-vmstate-daemon.sh

…

io-channel-helpers.c

…

io-channel-helpers.h

…

iothread.c

…

iothread.h

…

Makefile.include

…

meson.build

…

pkix_asn1_tab.c

…

ptimer-test-stubs.c

…

ptimer-test.c

…

ptimer-test.h

…

qht-bench.c

…

rcutorture.c

…

requirements.txt

…

socket-helpers.c

…

socket-helpers.h

…

test-aio-multithread.c

…

test-aio.c

…

test-authz-list.c

…

test-authz-listfile.c

…

test-authz-pam.c

…

test-authz-simple.c

…

test-base64.c

…

test-bdrv-drain.c

…

test-bdrv-graph-mod.c

…

test-bitcnt.c

…

test-bitmap.c

…

test-bitops.c

…

test-block-backend.c

…

test-block-iothread.c

…

test-blockjob-txn.c

…

test-blockjob.c

…

test-bufferiszero.c

…

test-char.c

…

test-clone-visitor.c

…

test-coroutine.c

…

test-crypto-afsplit.c

…

test-crypto-block.c

…

test-crypto-cipher.c

…

test-crypto-hash.c

…

test-crypto-hmac.c

…

test-crypto-ivgen.c

…

test-crypto-pbkdf.c

…

test-crypto-secret.c

…

test-crypto-tlscredsx509.c

…

test-crypto-tlssession.c

…

test-crypto-xts.c

…

test-cutils.c

…

test-hbitmap.c

…

test-image-locking.c

…

test-int128.c

…

test-io-channel-buffer.c

…

test-io-channel-command.c

…

test-io-channel-file.c

…

test-io-channel-socket.c

…

test-io-channel-tls.c

…

test-io-task.c

…

test-iov.c

…

test-keyval.c

…

test-logging.c

…

test-mul64.c

…

test-opts-visitor.c

…

test-qapi-util.c

…

test-qdev-global-props.c

…

test-qdist.c

…

test-qemu-opts.c

…

test-qga.c

…

test-qgraph.c

…

test-qht-par.c

…

test-qht.c

…

test-qmp-cmds.c

…

test-qmp-event.c

…

test-qobject-input-visitor.c

…

test-qobject-output-visitor.c

…

test-rcu-list.c

…

test-rcu-simpleq.c

…

test-rcu-slist.c

…

test-rcu-tailq.c

…

test-replication.c

…

test-shift128.c

…

test-string-input-visitor.c

…

test-string-output-visitor.c

…

test-thread-pool.c

…

test-throttle.c

…

test-timed-average.c

…

test-util-filemonitor.c

…

test-util-sockets.c

…

test-uuid.c

…

test-visitor-serialization.c

…

test-vmstate.c

…

test-write-threshold.c

…

test-x86-cpuid.c

…

test-xbzrle.c

…

vhost-user-bridge.c

…