Markus Armbruster
7200fb211e
hmp: Improve sync-profile error message
...
Improve
(qemu) sync-profile of
Error: Invalid parameter 'of'
to
Error: invalid parameter 'of', expecting 'on', 'off', or 'reset'
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-ID: <20231031111059.3407803-3-armbru@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org >
2023-11-17 10:07:52 +01:00
Marc-André Lureau
4bf21c7f74
monitor: restrict command getfd to POSIX hosts
...
Currently, the function will simply fail if ancillary fds are not
provided, for ex on unsupported platforms.
This changes the failure from:
{"error": {"class": "GenericError", "desc": "No file descriptor
supplied via SCM_RIGHTS"}}
to:
{"error": {"class": "CommandNotFound", "desc": "The command getfd
has not been found"}}
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com >
Reviewed-by: Markus Armbruster <armbru@redhat.com >
2023-03-13 15:46:09 +04:00
Markus Armbruster
cbf819979b
monitor: Move remaining HMP commands from misc.c to hmp-cmds.c
...
This requires giving them external linkage. Rename do_help_cmd() to
hmp_help(), and do_print() to hmp_print().
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-30-armbru@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
6a5fcf6c1e
stats: Move HMP commands from monitor/ to stats/
...
This moves these commands from MAINTAINERS section "Human
Monitor (HMP)" to section "Stats".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-24-armbru@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
bab46b8180
runstate: Move HMP commands from monitor/ to softmmu/
...
This moves these commands from MAINTAINERS section "Human
Monitor (HMP)" and "QMP" to "Main loop".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-22-armbru@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
0801062c1b
tpm: Move HMP commands from monitor/ to softmmu/
...
This moves these commands from MAINTAINERS section "Human
Monitor (HMP)" to "TPM".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-21-armbru@redhat.com >
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
fa1cea9d0f
virtio: Move HMP commands from monitor/ to hw/virtio/
...
This moves these commands from MAINTAINERS section "Human
Monitor (HMP)" to "virtio".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-20-armbru@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
2023-02-04 07:56:54 +01:00
Markus Armbruster
119f50ce30
migration: Move HMP commands from monitor/ to migration/
...
This moves these commands from MAINTAINERS sections "Human
Monitor (HMP)" and "QMP" to "Migration".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-18-armbru@redhat.com >
Reviewed-by: Juan Quintela <quintela@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
ae71d13d4e
net: Move hmp_info_network() to net-hmp-cmds.c
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-17-armbru@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
2030ca36bf
net: Move HMP commands from monitor to net/
...
This moves these commands from MAINTAINERS sections "Human
Monitor (HMP)" and "QMP" to "Network device backends".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-16-armbru@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
0d79271b57
hmp: Rewrite strlist_from_comma_list() as hmp_split_at_comma()
...
Use g_strsplit() for the actual splitting. Give external linkage, so
the next commit can move one of its users to another source file.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-15-armbru@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
52cafcea43
rocker: Move HMP commands from monitor to hw/net/rocker/
...
This moves these commands from MAINTAINERS section "Human
Monitor (HMP)" to "Rocker" and "Network devices".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-14-armbru@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
fa1d2f8f63
block: Factor out hmp_change_medium(), and move to block/monitor/
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-13-armbru@redhat.com >
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com >
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
cffaca0fab
qom: Move HMP commands from monitor/ to qom/
...
This moves these commands from MAINTAINERS sections "Human
Monitor (HMP)" and "QMP" to "QOM".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-12-armbru@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
2023-02-04 07:56:54 +01:00
Markus Armbruster
85ea9dfedd
machine: Move HMP commands from monitor/ to hw/core/
...
This moves these commands from MAINTAINERS section "Human
Monitor (HMP)" to "Machine core".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-11-armbru@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
b7d75c0b48
char: Move HMP commands from monitor/ to chardev/
...
This moves these commands from MAINTAINERS sections "Human
Monitor (HMP)" and "QMP" to "Character device backends".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-4-armbru@redhat.com >
2023-02-04 07:56:54 +01:00
Markus Armbruster
15b7646c7d
monitor: Drop unnecessary includes
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Message-Id: <20230124121946.1139465-2-armbru@redhat.com >
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com >
2023-02-04 07:56:52 +01:00
Markus Armbruster
f916a1751e
ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c
...
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Message-Id: <20230109190321.1056914-14-armbru@redhat.com >
2023-01-19 13:30:01 +01:00
Markus Armbruster
f8f2e9a859
ui: Improve "change vnc" error reporting
...
Switch from monitor_printf() to error_setg() and hmp_handle_error().
This makes "this is an error" more obvious both in the source and in
the monitor, where hmp_handle_error() prefixes the message with
"Error: ".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Message-Id: <20230109190321.1056914-13-armbru@redhat.com >
2023-01-19 13:30:01 +01:00
Markus Armbruster
5011d262f0
ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c
...
This moves these commands from MAINTAINERS section "Human
Monitor (HMP)" to "Graphics".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Message-Id: <20230109190321.1056914-12-armbru@redhat.com >
2023-01-19 13:30:01 +01:00
Markus Armbruster
61d7f2a956
ui: Clean up a few things checkpatch.pl would flag later on
...
Fix a few style violations so that checkpatch.pl won't complain when I
move this code.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Message-Id: <20230109190321.1056914-9-armbru@redhat.com >
2023-01-19 13:30:01 +01:00
Markus Armbruster
10e3c47a5d
ui/spice: Give hmp_info_spice()'s channel_names[] static linkage
...
Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Message-Id: <20230109190321.1056914-8-armbru@redhat.com >
2023-01-19 13:30:01 +01:00
Markus Armbruster
f4c1bcb8c4
Revert "hmp: info spice: take out webdav"
...
This reverts commit 7c6044a94e .
We had to take it out because SPICE_CHANNEL_WEBDAV requires
spice-protocol 0.12.7, but we had only 0.12.3. We have 0.14.0 now, so
put it back in.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
Message-Id: <20230109190321.1056914-5-armbru@redhat.com >
2023-01-19 13:30:01 +01:00
Markus Armbruster
147c48791b
ui: Fix silent truncation of numeric keys in HMP sendkey
...
Keys are int. HMP sendkey assigns them from the value strtoul(),
silently truncating values greater than INT_MAX. Fix to reject them.
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com >
Message-Id: <20230109190321.1056914-3-armbru@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
2023-01-19 13:30:01 +01:00
Markus Armbruster
5ef4a0cb63
pci: Move HMP commands from monitor/ to new hw/pci/pci-hmp-cmds.c
...
This moves these commands from MAINTAINERS section "Human
Monitor (HMP)" to "PCI".
Signed-off-by: Markus Armbruster <armbru@redhat.com >
Reviewed-by: Michael S. Tsirkin <mst@redhat.com >
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org >
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com >
Message-Id: <20221201121133.3813857-4-armbru@redhat.com >
2022-12-19 16:21:51 +01:00