izzy/shinobu
0
0
Fork 0
mirror of https://github.com/izzy2lost/shinobu.git synced 2026-03-26 16:50:24 -07:00
Code Issues Packages Projects Releases Wiki Activity
23,890 Commits 54 Branches 36 Tags
27dab233d9d7ccf148a9779db1bc3a3dbdc329f4
Commit Graph

49 Commits

Author SHA1 Message Date
Mitch Curtis aa8e3e7b0f GDScript: add an optional message parameter to assert() 
Before this patch, assert() only took the condition to assert on:

    assert(item_data)

Now, it can optionally take a string that will be printed upon failure:

    assert(item_data, item_name + " has no item data in ItemDatabase")

This makes it easier to immediately see what the issue is by being
able to write informative failure messages.

Thanks to @wiped1 for sharing their patch, upon which this is based.

Closes #17082
 2019-09-11 15:37:11 +02:00
Bojidar Marinov 112aa6e367 Fix yield check in GDScriptFunction 
Fixes #31455
 2019-08-28 11:15:43 +03:00
Robin Hübner 6ab118c464 Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in "platform", "modules/gdnative", "modules/gdscript" directories. 2019-08-09 11:13:24 +02:00
Bojidar Marinov 8336590154 Fix stack underflows when yielding twice 
Also, refactor GDScriptFunctionState::_signal_callback, removing some excessive repetition.
Fixes #30269.
 2019-07-17 23:48:49 +03:00
Rémi Verschelde 4d99408d12 Merge pull request #28884 from vnen/yield-resume-stack 
Keep GDScript functions in stack while yielding
 2019-07-01 16:35:26 +02:00
Furkan Türkal 7d8d337b2c fix some crashes 2019-07-01 14:28:29 +03:00
Rémi Verschelde 6750e1b3cd GDScript: Improve error on Object to Object invalid argument calls 
Fixes #27804.
 2019-06-18 11:27:43 +02:00
George Marques 9df1a2442b Show function name in debugger stack trace 
Also show script and line when the instance is gone when resuming from
yield.
 2019-05-14 11:39:44 -03:00
George Marques bdc6649b79 Keep GDScript functions in stack while yielding 
This prevents GDScript functions from leaving the stack too soon when
they are resuming from yield, allowing the ones expecting it to finish
to know the caller.

Helps debugging cases when you use:
`yield(function_which_yields(), "completed")`
since now it shows the call that resumed that function.
 2019-05-14 11:39:40 -03:00
Rémi Verschelde 425ec6914c Revert "Forbid implicit type conversion in GDScript" 2019-03-04 12:25:59 +01:00
George Marques d0b08342b8 GDScript: Forbid implicit type conversion 
Since types are not present in release builds, this could cause issues
where a variable does not have the exact defined type.
 2019-03-03 22:25:22 -03:00
Bojidar Marinov f0efc7521e Allow parameters passed to GDScript functions to be nulled 
Previous version resulted in confusing (but actually right) errors about converting "from Object to Object", since CallError
does not include information about the actual types involved.
 2019-03-03 15:24:06 +02:00
Bojidar Marinov d2e43475b5 Fix wrong error messages for invalid arguments when calling functions through call 
Fixes #25505
 2019-01-31 17:02:18 +02:00
Rémi Verschelde b16c309f82 Update copyright statements to 2019 
Happy new year to the wonderful Godot community!
 2019-01-01 12:58:10 +01:00
Rémi Verschelde 7b2ac28326 Merge pull request #23959 from RandomShaper/fix-dangling-script-fix 
Fix dangling script fix
 2018-11-26 10:13:00 +01:00
Pedro J. Estébanez 06b6cea62e Fix crash on signal/resume to dangling target 2018-11-25 13:16:45 +01:00
Pedro J. Estébanez b499537e68 Revert "Fix crash on signal/resume to dangling target" 
This reverts commit 54bdc1e1f6.
 2018-11-24 23:46:13 +01:00
George Marques 0bc953d83b Allow primitives to be compared to Object types with is 2018-11-17 22:41:08 -02:00
Pedro J. Estébanez 54bdc1e1f6 Fix crash on signal/resume to dangling target 
Fixes #22443.
 2018-10-17 20:44:47 +02:00
George Marques 6c9b1a5db2 Fix compiler warnings in GDScript module 2018-10-06 09:41:31 -03:00
Mariusz Chwalba 99d9af4fba Revert cause of #22794 2018-10-06 13:26:22 +02:00
Rémi Verschelde 95131e6f23 Fix warnings on release builds (not DEBUG_ENABLED) 
Fixes the following Clang 5 warnings:
```
modules/bmp/image_loader_bmp.cpp:46:60: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
modules/bmp/image_loader_bmp.cpp:48:61: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
drivers/png/image_loader_png.cpp:231:20: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
scene/gui/graph_edit.cpp:1045:8: warning: comparison of constant 0 with expression of type 'bool' is always false [-Wtautological-constant-out-of-range-compare]

core/class_db.cpp:812:13: warning: unused variable 'check' [-Wunused-variable]
core/io/file_access_pack.cpp:172:11: warning: unused variable 'ver_rev' [-Wunused-variable]
core/math/bsp_tree.cpp:195:13: warning: unused variable 'plane' [-Wunused-variable]
core/math/bsp_tree.cpp:168:6: warning: unused variable 'plane_count' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:685:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:706:10: warning: unused variable 'ok' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:755:19: warning: unused variable 'var_type' [-Wunused-variable]
modules/gdscript/gdscript_function.cpp:1306:12: warning: unused variable 'err' [-Wunused-variable]

modules/gdscript/gdscript_function.cpp:158:15: warning: unused function '_get_var_type' [-Wunused-function]
modules/gdscript/gdscript_parser.cpp:750:20: warning: unused variable 'lv' [-Wunused-variable]
modules/gdscript/gdscript_parser.cpp:59:15: warning: unused function '_find_function_name' [-Wunused-function]
scene/main/node.cpp:2489:13: warning: unused function '_Node_debug_sn' [-Wunused-function]
```
 2018-10-03 17:34:55 +02:00
Rémi Verschelde bca2d3ad40 Fix invalid comparison warnings: [-Wbool-compare] and [-Wenum-compare] 
Fixes the following GCC 5 warnings and actual bugs:
```
drivers/unix/net_socket_posix.cpp:562:28: warning: comparison between 'enum IP::Type' and 'enum NetSocket::Type' [-Wenum-compare]
modules/gdscript/gdscript_function.cpp:792:26: warning: comparison of constant '17' with boolean expression is always true [-Wbool-compare]
modules/gdscript/gdscript_function.cpp:792:26: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
modules/gdscript/gdscript_parser.cpp:5082:58: warning: comparison of constant '6' with boolean expression is always false [-Wbool-compare]
modules/gdscript/gdscript_parser.cpp:5082:58: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
modules/mbedtls/stream_peer_mbed_tls.cpp:286:45: warning: comparison between 'enum StreamPeerTCP::Status' and 'enum StreamPeerSSL::Status' [-Wenum-compare]
modules/mbedtls/stream_peer_mbed_tls.cpp:313:45: warning: comparison between 'enum StreamPeerTCP::Status' and 'enum StreamPeerSSL::Status' [-Wenum-compare]
```
 2018-09-27 16:25:24 +02:00
Rémi Verschelde 277b24dfb7 Make core/ includes absolute, remove subfolders from include path 
This allows more consistency in the manner we include core headers,
where previously there would be a mix of absolute, relative and
include path-dependent includes.
 2018-09-12 09:52:22 +02:00
George Marques 4b974a36b7 GDScript: Allow is operator to test built-in types 2018-08-26 13:31:23 -03:00