Commit Graph

173 Commits

Author SHA1 Message Date
Unknown W. Brackets
ab38c387ad Io: Correct some error handling for OpenFile().
See #12433.
2020-03-08 21:22:21 -07:00
Unknown W. Brackets
5009698cc0 Core: Use a shared_ptr for i18n categories.
This does not make them thread safe, but it reduces the chances of a crash
a bit (see #12594.)
2020-02-09 07:35:16 -08:00
Unknown W. Brackets
913121cf2b Io: Consistently use error codes with OpenFile().
This gets rid of OpenWithError(), and just always returns a negative value
on error for OpenFile().  Also fixed the sequence rollover, which could've
returned 0.

0 should be considered a valid handle ideally, but left it never returning
0 to simplify cleanup in some areas.
2019-10-20 11:03:37 -07:00
Unknown W. Brackets
2650ddae75 Savedata: Write only one secure entry.
Before, we were filling all the entries when the first file was saved, a
regression from 1976be4.  This caused issues in games that use a single
savedata folder for multiple secure files, such as Valkyria Chronicles 3.
2018-10-28 12:35:54 -07:00
Unknown W. Brackets
b64bb2e8ce Savedata: Also validate icon/subdata size. 2018-08-11 17:00:15 -07:00
Unknown W. Brackets
c0ccc9449d Savedata: Use size, not bufSize, for icons.
Verified by tests.  Should help #8810.
2018-08-11 17:00:09 -07:00
Unknown W. Brackets
42feade460 Savedata: Return error when bufSize is too small.
Mirrors what a PSP does.
2018-08-11 16:36:28 -07:00
Unknown W. Brackets
c4717fae2f Savedata: Reset data size when retrying hash.
It's even possible we might've not loaded the key before, so let's play it
safe and reset everything.

The previous fix only worked in some games, when dataSize was larger than
necessary.
2018-07-28 09:41:44 -07:00
Unknown W. Brackets
1976be48ab Savedata: Use file hash to validate hash mode.
This makes older PPSSPP save data also work, and also logs when save data
is detected as corrupt.
2018-06-30 12:17:52 -07:00
Unknown W. Brackets
93d96b8a32 Savedata: Map secureVersion modes correctly.
1 was correct, but other modes were not.
2018-06-24 15:34:27 -07:00
Unknown W. Brackets
46d7ead781 Savedata: Add validation on secureVersion param. 2018-06-24 15:30:33 -07:00
Unknown W. Brackets
aad6377580 Savedata: Return result codes from Save/Load.
This doesn't change anything, yet.
2018-06-24 13:28:57 -07:00
Unknown W. Brackets
c588046d99 Savedata: Respect secureVersion parameter.
This isn't used in many games, but see #10814.
2018-05-28 08:42:48 -07:00
Unknown W. Brackets
208b0aa4a7 Savedata: Report secureVersion param usage.
Seems likely this is what's happening in #10814, but need data from more
games.
2018-04-29 09:46:23 -07:00
Unknown W. Brackets
d2be5beccc Savedata: Show icon for new saves more often.
In fact, it may even be wrong to show the new data icon in this case...

Also fixes crashes when save title is 128 characters long.

Should improve #9632.
2017-12-03 06:35:41 -08:00
Unknown W. Brackets
42c0e7d5dd Savedata: Handle disk full properly in GETSIZE.
Games use these fields to determine how much more space is needed to
create savedata.  Some also use it for install data.

This allows more games to properly report free space issues.
2017-10-14 21:55:38 -07:00
LunaMoo
8826c031a6 Add ini-only "Savedata Upgrade" setting. 2017-10-04 17:16:21 +02:00
Henrik Rydgård
867a1d8bb2 Buildfix, oops 2017-05-26 19:05:18 +02:00
Henrik Rydgård
21fe73c8e7 Switch strncpy to truncate_cpy in a bunch of places. 2017-05-26 19:04:08 +02:00
Florent Castelli
70593d1004 android: Change preprocessor define to standard __ANDROID__
ANDROID is only standard to the old Makefile buildsystem, not the platform.
2016-10-12 11:14:09 +02:00
Florent Castelli
373db56a16 blackberry: Remove! 2016-10-11 17:40:32 +02:00
Unknown W. Brackets
a1fbcc3d93 Avoid directly calling osm from Core/GPU code.
This allows UI to handle the message however it wants to, and reduces
cross linkage issues.
2016-05-27 22:05:30 -07:00
gmvbif
281f0e18e6 Fixed some errors from PVS-Studio in Core project
FixedSizeQueue
- Added private operator=
- Changed signature of EndPop
Some changed to printf like functions.
Fixed typo in syn-att.c
2015-12-31 10:25:11 +03:00
Unknown W. Brackets
b71b1bbff9 Initially count the dir for save info size.
Should help #6068, verified by the sizes test and JpcspTrace results.
2015-11-15 10:29:13 -08:00
vnctdj
d7eba2061e Consistently use *di for the Dialog i18n category 2015-07-01 23:26:55 +02:00