Commit Graph

679 Commits

Author SHA1 Message Date
Unknown W. Brackets
dea9cac16c Core: Add range checks to some helpers and similar. 2023-01-09 16:56:18 -08:00
Henrik Rydgård
7e374c9324 Address feedback, more fixes 2023-01-05 08:38:53 +01:00
Henrik Rydgård
fd7cc76d95 Remove unnecessary savedata version reporting 2023-01-02 23:22:54 +01:00
Unknown W. Brackets
87172f9dd5 Dialog: Fix confirm/cancel button reversal. 2023-01-01 09:34:13 -08:00
Henrik Rydgård
61cc6cd0e0 Fix bug swapping O/X visually on PSPOskDialog 2022-12-16 21:51:20 +01:00
Unknown W. Brackets
a7b7bf7826 Global: Set many read-only params as const.
This makes what they do and which args to use clearer, if nothing else.
2022-12-10 21:13:36 -08:00
Unknown W. Brackets
f44852bb18 Global: Cleanup virtual/override specifiers.
Also missing virtual destructors, hidden non-overrides, etc.
2022-12-10 21:13:36 -08:00
Henrik Rydgård
93e5060137 Load and cache langValuesMapping on demand 2022-12-05 12:10:45 +01:00
Henrik Rydgård
f954013d0b Fix (?) the savestate bug in PSPSaveDialog/SaveDataParam
PSPSaveDialog::DoState called SetPspParam in non-READ modes, which could
modify it.
2022-12-02 22:46:39 +01:00
Henrik Rydgård
f5a7661c51 Add a NOOP state to reduce logspam after error 2022-12-02 22:46:38 +01:00
Henrik Rydgård
5b3a993db7 Typo fix 2022-11-28 09:50:23 +01:00
Henrik Rydgård
21647cd3c1 Blind workaround for Shining Ark circle button problem
Seems the game might not handle the case of confirm button being set to
cross properly, so force it to circle if this game is running.

Fixes #15663 (hopefully..)
2022-11-27 23:32:43 +01:00
Unknown W. Brackets
29e7a53b5d Savedata: Update filelist on file erasure.
Also stop reporting as "not coded."
2022-10-16 09:20:04 -07:00
Unknown W. Brackets
db5011d7f1 Savedata: Cache SFO data during processing.
This only caches between touching PSP code, in case something changes.
Reduces cases of multiple SFO lookups and reads.
2022-10-09 14:42:31 -07:00
Unknown W. Brackets
5bed35b293 Savedata: Skip and defer texture exist check.
We can skip if there's no UI.
2022-10-09 14:42:31 -07:00
Unknown W. Brackets
8c1acc30e4 Savedata: Combine file info and dir listing calls. 2022-10-09 14:42:31 -07:00
Unknown W. Brackets
6168e03b4a Savedata: Reduce some duplicate file info lookups. 2022-10-09 14:42:31 -07:00
Unknown W. Brackets
d473aa6db0 Module: Cleanup file read pattern.
Let's always use ReadEntireFile() when we can.
2022-10-09 14:42:30 -07:00
lainon
b304551747 Code readability, vec reserve() and remove excess c_str() 2022-09-30 12:31:32 +03:00
lainon
fec708489a Correct cleaning string and remove unused vars 2022-09-30 12:26:30 +03:00
Unknown W. Brackets
f0afc97247 Gamedata: Cleanup install request args/validate. 2022-09-18 20:39:13 -07:00
Unknown W. Brackets
ce80900b75 Savedata: Return errors more correctly on load.
If the buffer isn't large enough, return an error.  See #14687, thanks
sum2012 and gid15.
For many error cases, ensure SFO data and bind are not updated on failure,
and that dataSize is forced to zero on data errors.
2022-09-13 00:10:27 -07:00
Unknown W. Brackets
dd0de46ed9 Io: Use PSPPointer instead of struct temps. 2022-09-03 10:44:11 -07:00
Henrik Rydgård
c9048c3748 Shrink the DeferredDrawcall struct, because why not. Assorted cleanup 2022-09-01 11:59:33 +02:00
Henrik Rydgård
70b9dcc9a3 Initialize a bunch of Dialog structs 2022-08-18 16:46:22 +02:00