JosJuice
0b11f15158
Fix VolumeVerifier considering Wii Menu WADs to have wrong region
2019-07-15 12:42:13 +02:00
Lioncash
4f1f55093f
Common/MsgHandler: Namespace code within the Common namespace
...
Closes another gap in the Common library where code isn't being
namespaced under it.
2019-06-19 16:03:55 -04:00
Connor McLaughlin and GitHub
ab66e91766
Merge pull request #8134 from JosJuice/filesystem-string-view
...
DiscIO: Use std::string_view in FileSystem::FindFileInfo
2019-06-08 20:52:34 +10:00
Lioncash
5512876842
General: Migrate from deprecated mbedTLS functions
...
As indicated by mbedTLS' documentation, all of the relevant functions
have been superseded by _ret-suffixed variants in mbedTLS version
2.7.0.
2019-06-07 22:51:58 -04:00
Lioncash
a9663669dc
Common/CommonFuncs: Remove now-unneccessary ArraySize function
...
Since C++17, non-member std::size() is present in the standard library
which also operates on regular C arrays. Given that, we can just replace
usages of ArraySize with that where applicable.
In many cases, we can just change the actual C array ArraySize() was
called on into a std::array and just use its .size() member function
instead.
In some other cases, we can collapse the loops they were used in, into a
ranged-for loop, eliminating the need for en explicit bounds query.
2019-06-01 10:07:57 -04:00
Lioncash
cbcafd6830
DiscIO/CMakeLists: Specify headers in target sources
2019-05-31 06:54:25 -04:00
JosJuice
f25367a7a2
DiscIO: Avoid copies when comparing FileSystemGCWii file names
2019-05-29 14:53:39 +02:00
JosJuice
d4b069f458
DiscIO: Use std::string_view in FileSystem::FindFileInfo
...
...and in the functions that call it.
2019-05-29 08:29:56 +02:00
Lioncash
d220e33862
DiscIO/VolumeVerifier: Make no-argument overload of GetBiggestUsedOffset() const
...
The overload taking a partition is already a const member function, so
this one can be turned into one as well.
2019-05-27 10:40:41 -04:00
Lioncash
bf6948c1d4
DiscIO/VolumeVerifier: Use structured bindings where applicable
...
Allows providing better names than "first" or "second".
2019-05-27 10:40:38 -04:00
Lioncash
fa57396e97
DiscIO/VolumeVerifier: In-class initialize members where applicable
...
Removes redundant initializers from the constructor and provides
initializers for all members that don't already have one for consistency
(and deterministic initial state).
2019-05-27 10:40:17 -04:00
Lioncash
52eb2d0d82
DiscIO/VolumeVerifier: Default destructor within the cpp file
...
Given the volume verifier has quite a few non-trivial object within it,
it's best to default the destructor within the cpp file to prevent
inlining complex destruction logic elsewhere, while also making it nicer
if a forward-declared type is ever used in a member variable.
2019-05-27 10:19:51 -04:00
Lioncash
0ccaa2b5d6
DiscIO/VolumeVerifier: Take std::string by value in AddProblem()
...
This allows both std::moving into the function and moving the parameter
from within the function, potentially avoiding an unnecessary copy.
2019-05-27 10:17:11 -04:00
Lioncash
a1f77fd14b
DiscIO/VolumeVerifier: Make use of unused variable in CheckMisc()
...
This variable wasn't being utilized when comments indicate that it
probably should be.
2019-05-27 10:09:55 -04:00
Techjar
ff972e3673
Reformat repo to clang-format 7.0 rules
2019-05-06 18:48:04 +00:00
JosJuice
bb1ed46753
Use [[fallthrough]] in DiscExtractor
...
This was missed in PR 6273 because the fallthrough was added to
DiscExtractor after that PR was created.
2019-05-05 10:35:45 +02:00
JosJuice
8709b21ac3
VolumeVerifier: Verify WAD contents
2019-04-09 14:18:46 +02:00
JosJuice
a469fb3150
VolumeVerifier: Check whether invalid blocks are unused
2019-04-09 14:18:46 +02:00
JosJuice
eced9d7c7e
VolumeVerifier: Calculate CRC32/MD5/SHA-1
2019-04-09 14:18:46 +02:00
JosJuice
4fd2d8e8c4
VolumeVerifier: Check hashes in Wii partitions
2019-04-09 14:18:45 +02:00
JosJuice
84cbd5150f
Add a Verify tab to game properties
2019-04-09 14:18:41 +02:00
JosJuice
c885fed9da
DiscIO: Make Korean GC checks in Enums.cpp less fragile
2019-03-30 12:45:28 +01:00
JosJuice
c028a84531
Volume: Add a GetCertificateChain function
2019-03-30 12:45:28 +01:00
JosJuice
abb3c5bccd
VolumeWad: Implement GetTicket
2019-03-30 12:45:17 +01:00
JosJuice
cf9ab6ddcc
DiscExtractor: Make P prefix for partition names optional
...
Also added constants for common partition types.
2019-03-30 12:45:17 +01:00