From d379133801b9f4ec13103507853c84c4b41fbdf1 Mon Sep 17 00:00:00 2001 From: butomo1989 Date: Wed, 24 May 2017 11:52:48 +0200 Subject: [PATCH 1/2] Renamed method to fix codacy violation --- src/app.py | 6 +++--- src/tests/__init__.py | 14 +++++++------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/app.py b/src/app.py index 59fcb0d..f5b8fbc 100644 --- a/src/app.py +++ b/src/app.py @@ -26,7 +26,7 @@ def get_or_raise(env: str) -> str: return env_value -def str_to_bool(str: str) -> bool: +def convert_str_to_bool(str: str) -> bool: """ Convert string to boolean. @@ -101,7 +101,7 @@ def appium_run(avd_name: str): """ cmd = 'appium' - grid_connect = str_to_bool(str(os.getenv('CONNECT_TO_GRID', False))) + grid_connect = convert_str_to_bool(str(os.getenv('CONNECT_TO_GRID', False))) logger.info('Connect to selenium grid? {connect}'.format(connect=grid_connect)) if grid_connect: try: @@ -170,7 +170,7 @@ def run(): cmd = 'emulator -avd {name}'.format(name=avd_name) subprocess.Popen(cmd.split()) - appium = str_to_bool(str(os.getenv('APPIUM', False))) + appium = convert_str_to_bool(str(os.getenv('APPIUM', False))) if appium: logger.info('Run appium server...') appium_run(avd_name) diff --git a/src/tests/__init__.py b/src/tests/__init__.py index 65cd5a4..93c555e 100644 --- a/src/tests/__init__.py +++ b/src/tests/__init__.py @@ -21,17 +21,17 @@ class TestApp(TestCase): app.get_or_raise('ENV_2') def test_valid_bool(self): - self.assertEqual(app.str_to_bool('True'), True) - self.assertEqual(app.str_to_bool('t'), True) - self.assertEqual(app.str_to_bool('1'), True) - self.assertEqual(app.str_to_bool('YES'), True) + self.assertEqual(app.convert_str_to_bool('True'), True) + self.assertEqual(app.convert_str_to_bool('t'), True) + self.assertEqual(app.convert_str_to_bool('1'), True) + self.assertEqual(app.convert_str_to_bool('YES'), True) def test_invalid_bool(self): - self.assertEqual(app.str_to_bool(''), False) - self.assertEqual(app.str_to_bool('test'), False) + self.assertEqual(app.convert_str_to_bool(''), False) + self.assertEqual(app.convert_str_to_bool('test'), False) def test_invalid_format(self): - self.assertEqual(app.str_to_bool(True), None) + self.assertEqual(app.convert_str_to_bool(True), None) @mock.patch('src.app.prepare_avd') @mock.patch('subprocess.Popen') From 1a7453d6b67681288883ea363c1a4a315188923f Mon Sep 17 00:00:00 2001 From: butomo1989 Date: Wed, 24 May 2017 12:01:10 +0200 Subject: [PATCH 2/2] Added codacy badge --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index eefc6f4..86a7497 100644 --- a/README.md +++ b/README.md @@ -3,6 +3,7 @@ Docker-Android [![Build Status](https://travis-ci.org/butomo1989/docker-android.svg?branch=master)](https://travis-ci.org/butomo1989/docker-android) [![codecov](https://codecov.io/gh/butomo1989/docker-android/branch/master/graph/badge.svg)](https://codecov.io/gh/butomo1989/docker-android) +[![Codacy Badge](https://api.codacy.com/project/badge/Grade/3f000ffb97db45a59161814e1434c429)](https://www.codacy.com/app/butomo1989/docker-appium?utm_source=github.com&utm_medium=referral&utm_content=butomo1989/docker-appium&utm_campaign=Badge_Grade) Docker-Android is a docker image built to be used for everything related to mobile website testing and Android project.