Files
UnrealEngineUWP/Engine/Source/Runtime/Online/HTTP/Private/HttpRetrySystem.cpp
Andrew Grant fad858c6db Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 2912736)
#lockdown Nick.Penwarden

==========================
MAJOR FEATURES + CHANGES
==========================

Change 2912513 on 2016/03/16 by David.Ratti

	attempted cook fix
	#rb none
	#tests compile

Change 2912456 on 2016/03/16 by Zak.Middleton

	#ue4 - Move Replay client interpolation mode check to OnRegister(), out of TickComponent() so we don't check it constantly.

	#rb John.Pollard
	#tests Replays and MultiPIE vs AI

Change 2912386 on 2016/03/16 by Ben.Marsh

	BuildGraph: Add quotes around custom build node lists, so we can support node names with spaces.

Change 2912378 on 2016/03/16 by Ben.Marsh

	BuildGraph: Fix format of custom build arguments when running with buildgraph.

Change 2912318 on 2016/03/16 by Marcus.Wassmer

	Fix mallocleakdetection false positives, and hash collision data corruption.
	#rb none
	#test leak finding on goldenpath

Change 2912242 on 2016/03/16 by Lukasz.Furman

	CIS fix
	#rb none
	#tests none

Change 2912239 on 2016/03/16 by Ben.Marsh

	UBT: Include the project "Build" folder in the generated project files. It's pretty common to want to edit configuration data that's stored there.

	#rb none
	#tests generated project files using UGS after making change

Change 2912211 on 2016/03/16 by Ben.Marsh

	BuildFarm: Allow disabling the local DDC by setting the DDC override environment variable to "None". Testing performance of just using shared DDC for builders.

	#rb none
	#codereview Wes.Hunt
	#tests none

Change 2912196 on 2016/03/16 by Mieszko.Zielinski

	Added a missing #pragma once to GameplayDebuggerCompat.h #Orion

	#rb Lukasz.Furman
	#test none

Change 2912165 on 2016/03/16 by Lukasz.Furman

	new gameplay debugger and some replication fixes (disabled by default)
	uncommment debugger's setup line in FOrionGameModule::StartupModule to enable
	#orion
	#rb none
	#tests yes, a lot.
	#codereview Mieszko.Zielinski

Change 2912065 on 2016/03/16 by Jason.Bestimt

	[AUTOMERGE]

	#ORION_MAIN - Copy of DevUI (POST MERGE) @ CL 2912016

	#RB:none
	#Tests:none
	#CodeReview: matt.schembari

	--------
	Integrated using branch //Orion/Main_to_//Orion/Dev-General of change#2912060 by Jason.Bestimt on 2016/03/16 15:32:56.

Change 2912045 on 2016/03/16 by David.Ratti

	Add support for gameplay cues retrieiving the ability or gameplay effect level of the thing that instigated them. Also added level requirement settings in the addition particle system options in gameplay cues

	#rb DanY
	#tests PIE

Change 2912030 on 2016/03/16 by Alex.Fennell

	Merging //Portal/Dev-LibCurl_update/Engine/Source/Runtime/Online/... to //Orion/Dev-General/Engine/Source/Runtime/Online/...

	support for cookies across curl easy handles in libcurl

	#TESTS: cookie support confirmed by using the http test targetting google.com

	#RB: david.nikdel
	#codereview: david.nikdel, jason.bestimt

Change 2911870 on 2016/03/16 by Laurent.Delayen

	- Added FBranchingPointNotifyPayload used in AnimNotify and AnimNotifyState notifications.
	- FBranchingPointNotifyPayload includes MontageInstance InstanceID to uniquely identify which Montage it came from.
	- New notifications are backwards compatible with old.
	- Added bIsNativeBranchingPoint flag to notify classes to force them into branching points.

	#rb martin.wilson, frank.gigliotti
	#tests Kuro VS Rampage abilities in networked PIE

Change 2911763 on 2016/03/16 by Nick.Atamas

	Prevents a re-entrancy crash caused by potentially complex thumbnail generators. In general, we should not be doing heavy lifting in the asset browser until the user has released their mouse. This is especially true when a user is clicking on the content browser tab to bring it to front for the first time. This is probably a good change regardless of the re-entrancy issue.

	#rb none
	#test Editor does not crash.
	#codereview Matt.Kuhlenschmidt

Change 2911631 on 2016/03/16 by Dmitry.Rekman

	Fix AvgPing perfcounter being occasionally NaN (FORT-20523)

	- Prevent division by zero.

	#rb none

[CL 2917701 by Andrew Grant in Main branch]
2016-03-21 21:11:39 -04:00

425 lines
14 KiB
C++

// Copyright 1998-2016 Epic Games, Inc. All Rights Reserved.
#include "HttpPrivatePCH.h"
#include "HttpRetrySystem.h"
FHttpRetrySystem::FRequest::FRequest(
FManager& InManager,
const TSharedRef<IHttpRequest>& HttpRequest,
const FHttpRetrySystem::FRetryLimitCountSetting& InRetryLimitCountOverride,
const FHttpRetrySystem::FRetryTimeoutRelativeSecondsSetting& InRetryTimeoutRelativeSecondsOverride,
const FHttpRetrySystem::FRetryResponseCodes& InRetryResponseCodes
)
: FHttpRequestAdapterBase(HttpRequest)
, Status(FHttpRetrySystem::FRequest::EStatus::NotStarted)
, RetryLimitCountOverride(InRetryLimitCountOverride)
, RetryTimeoutRelativeSecondsOverride(InRetryTimeoutRelativeSecondsOverride)
, RetryResponseCodes(InRetryResponseCodes)
, RetryManager(InManager)
{
// if the InRetryTimeoutRelativeSecondsOverride override is being used the value cannot be negative
check(!(InRetryTimeoutRelativeSecondsOverride.bUseValue) || (InRetryTimeoutRelativeSecondsOverride.Value >= 0.0));
}
bool FHttpRetrySystem::FRequest::ProcessRequest()
{
TSharedRef<FRequest> RetryRequest = StaticCastSharedRef<FRequest>(AsShared());
HttpRequest->OnRequestProgress().BindSP(RetryRequest, &FHttpRetrySystem::FRequest::HttpOnRequestProgress);
return RetryManager.ProcessRequest(RetryRequest);
}
void FHttpRetrySystem::FRequest::CancelRequest()
{
TSharedRef<FRequest> RetryRequest = StaticCastSharedRef<FRequest>(AsShared());
RetryManager.CancelRequest(RetryRequest);
}
void FHttpRetrySystem::FRequest::HttpOnRequestProgress(FHttpRequestPtr InHttpRequest, int32 BytesSent, int32 BytesRcv)
{
OnRequestProgress().ExecuteIfBound(AsShared(), BytesSent, BytesRcv);
}
FHttpRetrySystem::FManager::FManager(const FRetryLimitCountSetting& InRetryLimitCountDefault, const FRetryTimeoutRelativeSecondsSetting& InRetryTimeoutRelativeSecondsDefault)
: RandomFailureRate(FRandomFailureRateSetting::Unused())
, RetryLimitCountDefault(InRetryLimitCountDefault)
, RetryTimeoutRelativeSecondsDefault(InRetryTimeoutRelativeSecondsDefault)
{}
TSharedRef<FHttpRetrySystem::FRequest> FHttpRetrySystem::FManager::CreateRequest(
const FRetryLimitCountSetting& InRetryLimitCountOverride,
const FRetryTimeoutRelativeSecondsSetting& InRetryTimeoutRelativeSecondsOverride,
const FRetryResponseCodes& InRetryResponseCodes)
{
return MakeShareable(new FRequest(
*this,
FHttpModule::Get().CreateRequest(),
InRetryLimitCountOverride,
InRetryTimeoutRelativeSecondsOverride,
InRetryResponseCodes
));
}
bool FHttpRetrySystem::FManager::ShouldRetry(const FHttpRetryRequestEntry& HttpRetryRequestEntry)
{
bool bResult = false;
FHttpResponsePtr Response = HttpRetryRequestEntry.Request->GetResponse();
// invalid response means connection or network error but we need to know which one
if (!Response.IsValid())
{
// ONLY retry bad responses if they are connection errors (NOT protocol errors or unknown) otherwise request may be sent (and processed!) twice
EHttpRequestStatus::Type Status = HttpRetryRequestEntry.Request->GetStatus();
if (Status == EHttpRequestStatus::Failed_ConnectionError)
{
bResult = true;
}
else if (Status == EHttpRequestStatus::Failed)
{
// we will also allow retry for GET and HEAD requests even if they may duplicate on the server
FString Verb = HttpRetryRequestEntry.Request->GetVerb();
if (Verb == TEXT("GET") || Verb == TEXT("HEAD"))
{
bResult = true;
}
}
}
else
{
// this may be a successful response with one of the explicitly listed response codes we want to retry on
if (HttpRetryRequestEntry.Request->RetryResponseCodes.Contains(Response->GetResponseCode()))
{
bResult = true;
}
}
return bResult;
}
bool FHttpRetrySystem::FManager::CanRetry(const FHttpRetryRequestEntry& HttpRetryRequestEntry)
{
bool bResult = false;
bool bShouldTestCurrentRetryCount = false;
double RetryLimitCount = 0;
if (HttpRetryRequestEntry.Request->RetryLimitCountOverride.bUseValue)
{
bShouldTestCurrentRetryCount = true;
RetryLimitCount = HttpRetryRequestEntry.Request->RetryLimitCountOverride.Value;
}
else if (RetryLimitCountDefault.bUseValue)
{
bShouldTestCurrentRetryCount = true;
RetryLimitCount = RetryLimitCountDefault.Value;
}
if (bShouldTestCurrentRetryCount)
{
if (HttpRetryRequestEntry.CurrentRetryCount < RetryLimitCount)
{
bResult = true;
}
}
return bResult;
}
bool FHttpRetrySystem::FManager::HasTimedOut(const FHttpRetryRequestEntry& HttpRetryRequestEntry, const double NowAbsoluteSeconds)
{
bool bResult = false;
bool bShouldTestRetryTimeout = false;
double RetryTimeoutAbsoluteSeconds = HttpRetryRequestEntry.RequestStartTimeAbsoluteSeconds;
if (HttpRetryRequestEntry.Request->RetryTimeoutRelativeSecondsOverride.bUseValue)
{
bShouldTestRetryTimeout = true;
RetryTimeoutAbsoluteSeconds += HttpRetryRequestEntry.Request->RetryTimeoutRelativeSecondsOverride.Value;
}
else if (RetryTimeoutRelativeSecondsDefault.bUseValue)
{
bShouldTestRetryTimeout = true;
RetryTimeoutAbsoluteSeconds += RetryTimeoutRelativeSecondsDefault.Value;
}
if (bShouldTestRetryTimeout)
{
if (NowAbsoluteSeconds >= RetryTimeoutAbsoluteSeconds)
{
bResult = true;
}
}
return bResult;
}
float FHttpRetrySystem::FManager::GetLockoutPeriodSeconds(const FHttpRetryRequestEntry& HttpRetryRequestEntry)
{
float lockoutTime = 0.0f;
if(HttpRetryRequestEntry.CurrentRetryCount >= 1)
{
lockoutTime = 5.0f + 5.0f * ((HttpRetryRequestEntry.CurrentRetryCount - 1) >> 1);
lockoutTime = lockoutTime > 30.0f ? 30.0f : lockoutTime;
}
return lockoutTime;
}
static FRandomStream temp(4435261);
bool FHttpRetrySystem::FManager::Update(uint32* FileCount, uint32* FailingCount, uint32* FailedCount, uint32* CompletedCount)
{
bool bIsGreen = true;
if (FileCount != nullptr)
{
*FileCount = RequestList.Num();
}
const double NowAbsoluteSeconds = FPlatformTime::Seconds();
// Basic algorithm
// for each managed item
// if the item hasn't timed out
// if the item's retry state is NotStarted
// if the item's request's state is not NotStarted
// move the item's retry state to Processing
// endif
// endif
// if the item's retry state is Processing
// if the item's request's state is Failed
// flag return code to false
// if the item can be retried
// increment FailingCount if applicable
// retry the item's request
// increment the item's retry count
// else
// increment FailedCount if applicable
// set the item's retry state to FailedRetry
// endif
// else if the item's request's state is Succeeded
// endif
// endif
// else
// flag return code to false
// set the item's retry state to FailedTimeout
// increment FailedCount if applicable
// endif
// if the item's retry state is FailedRetry
// do stuff
// endif
// if the item's retry state is FailedTimeout
// do stuff
// endif
// if the item's retry state is Succeeded
// do stuff
// endif
// endfor
int32 index = 0;
while (index < RequestList.Num())
{
FHttpRetryRequestEntry& HttpRetryRequestEntry = RequestList[index];
TSharedRef<FHttpRetrySystem::FRequest>& HttpRetryRequest = HttpRetryRequestEntry.Request;
EHttpRequestStatus::Type RequestStatus = HttpRetryRequest->GetStatus();
if (!HasTimedOut(HttpRetryRequestEntry, NowAbsoluteSeconds))
{
if (HttpRetryRequest->Status == FHttpRetrySystem::FRequest::EStatus::NotStarted)
{
if (RequestStatus != EHttpRequestStatus::NotStarted)
{
HttpRetryRequest->Status = FHttpRetrySystem::FRequest::EStatus::Processing;
}
}
if (HttpRetryRequest->Status == FHttpRetrySystem::FRequest::EStatus::Processing)
{
bool forceFail = false;
// Code to simulate request failure
if (RequestStatus == EHttpRequestStatus::Succeeded && RandomFailureRate.bUseValue)
{
float random = temp.GetFraction();
if (random < RandomFailureRate.Value)
{
forceFail = true;
}
}
// Save these for failure case retry checks if we hit a completion state
bool bShouldRetry = false;
bool bCanRetry = false;
if (RequestStatus == EHttpRequestStatus::Failed || RequestStatus == EHttpRequestStatus::Failed_ConnectionError || RequestStatus == EHttpRequestStatus::Succeeded)
{
bShouldRetry = ShouldRetry(HttpRetryRequestEntry);
bCanRetry = CanRetry(HttpRetryRequestEntry);
}
if (RequestStatus == EHttpRequestStatus::Failed || RequestStatus == EHttpRequestStatus::Failed_ConnectionError || forceFail || (bShouldRetry && bCanRetry))
{
bIsGreen = false;
if(HttpRetryRequestEntry.bShouldCancel == false)
{
if (forceFail || (bShouldRetry && bCanRetry))
{
float lockoutPeriod = GetLockoutPeriodSeconds(HttpRetryRequestEntry);
if(lockoutPeriod > 0.0f)
{
UE_LOG(LogHttp, Warning, TEXT("Lockout of %fs on %s"), lockoutPeriod, *(HttpRetryRequest->GetURL()));
}
HttpRetryRequestEntry.LockoutEndTimeAbsoluteSeconds = NowAbsoluteSeconds + lockoutPeriod;
HttpRetryRequest->Status = FHttpRetrySystem::FRequest::EStatus::ProcessingLockout;
}
else
{
UE_LOG(LogHttp, Warning, TEXT("Retry exhausted on %s"), *(HttpRetryRequest->GetURL()));
if (FailedCount != nullptr)
{
++(*FailedCount);
}
HttpRetryRequest->Status = FHttpRetrySystem::FRequest::EStatus::FailedRetry;
}
}
else
{
UE_LOG(LogHttp, Warning, TEXT("Request cancelled on %s"), *(HttpRetryRequest->GetURL()));
HttpRetryRequest->Status = FHttpRetrySystem::FRequest::EStatus::Cancelled;
}
}
else if (RequestStatus == EHttpRequestStatus::Succeeded)
{
if (HttpRetryRequestEntry.CurrentRetryCount > 0)
{
UE_LOG(LogHttp, Warning, TEXT("Success on %s"), *(HttpRetryRequest->GetURL()));
}
if (CompletedCount != nullptr)
{
++(*CompletedCount);
}
HttpRetryRequest->Status = FHttpRetrySystem::FRequest::EStatus::Succeeded;
}
}
if (HttpRetryRequest->Status == FHttpRetrySystem::FRequest::EStatus::ProcessingLockout)
{
if (NowAbsoluteSeconds >= HttpRetryRequestEntry.LockoutEndTimeAbsoluteSeconds)
{
// if this fails the HttpRequest's state will be failed which will cause the retry logic to kick(as expected)
bool success = HttpRetryRequest->HttpRequest->ProcessRequest();
if (success)
{
UE_LOG(LogHttp, Warning, TEXT("Retry %d on %s"), HttpRetryRequestEntry.CurrentRetryCount + 1, *(HttpRetryRequest->GetURL()));
++HttpRetryRequestEntry.CurrentRetryCount;
HttpRetryRequest->Status = FRequest::EStatus::Processing;
}
}
if (FailingCount != nullptr)
{
++(*FailingCount);
}
}
}
else
{
UE_LOG(LogHttp, Warning, TEXT("Timeout on retry %d: %s"), HttpRetryRequestEntry.CurrentRetryCount + 1, *(HttpRetryRequest->GetURL()));
bIsGreen = false;
HttpRetryRequest->Status = FHttpRetrySystem::FRequest::EStatus::FailedTimeout;
if (FailedCount != nullptr)
{
++(*FailedCount);
}
}
bool bWasCompleted = false;
bool bWasSuccessful = false;
if (HttpRetryRequest->Status == FHttpRetrySystem::FRequest::EStatus::Cancelled ||
HttpRetryRequest->Status == FHttpRetrySystem::FRequest::EStatus::FailedRetry ||
HttpRetryRequest->Status == FHttpRetrySystem::FRequest::EStatus::FailedTimeout ||
HttpRetryRequest->Status == FHttpRetrySystem::FRequest::EStatus::Succeeded)
{
bWasCompleted = true;
bWasSuccessful = HttpRetryRequest->Status == FHttpRetrySystem::FRequest::EStatus::Succeeded;
}
if (bWasCompleted)
{
HttpRetryRequest->OnProcessRequestComplete().ExecuteIfBound(HttpRetryRequest, HttpRetryRequest->GetResponse(), bWasSuccessful);
}
if(bWasSuccessful)
{
if(CompletedCount != nullptr)
{
++(*CompletedCount);
}
}
if (bWasCompleted)
{
RequestList.RemoveAtSwap(index);
}
else
{
++index;
}
}
return bIsGreen;
}
FHttpRetrySystem::FManager::FHttpRetryRequestEntry::FHttpRetryRequestEntry(TSharedRef<FHttpRetrySystem::FRequest>& InRequest)
: bShouldCancel(false)
, CurrentRetryCount(0)
, RequestStartTimeAbsoluteSeconds(FPlatformTime::Seconds())
, Request(InRequest)
{}
bool FHttpRetrySystem::FManager::ProcessRequest(TSharedRef<FHttpRetrySystem::FRequest>& HttpRetryRequest)
{
bool bResult = HttpRetryRequest->HttpRequest->ProcessRequest();
if (bResult)
{
RequestList.Add(FHttpRetryRequestEntry(HttpRetryRequest));
}
return bResult;
}
void FHttpRetrySystem::FManager::CancelRequest(TSharedRef<FHttpRetrySystem::FRequest>& HttpRetryRequest)
{
// Find the existing request entry if is was previously processed.
bool bFound = false;
for (int32 i = 0; i < RequestList.Num(); ++i)
{
FHttpRetryRequestEntry& EntryRef = RequestList[i];
if (EntryRef.Request == HttpRetryRequest)
{
EntryRef.bShouldCancel = true;
bFound = true;
}
}
// If we did not find the entry, likely auth failed for the request, in which case ProcessRequest does not get called.
// Adding it to the list and flagging as cancel will process it on next tick.
if (!bFound)
{
FHttpRetryRequestEntry RetryRequestEntry(HttpRetryRequest);
RetryRequestEntry.bShouldCancel = true;
RequestList.Add(RetryRequestEntry);
}
HttpRetryRequest->HttpRequest->CancelRequest();
}