You've already forked UnrealEngineUWP
mirror of
https://github.com/izzy2lost/UnrealEngineUWP.git
synced 2026-03-26 18:15:20 -07:00
dfcafcb010
- Changed the recovery session activity stream to return 'I'm done' when it encounters an error to prevent the caller to ignore the error and continue asking new activities (which triggers the assert).
- Handled the error reported by the stream when searching for a recoverable session just after the Editor finished its initialization.
Fixed DisasterRecovery freezing the Editor if the new session database could not be created successfully.
- Reported the error to the client instead of silently ignoring it.
- Updated the verbose log to Warning to let the user know that a new session could not be created (and therefore disaster recovery is going to be off.
#jira UE-89128 - Re-Opening Game After Trying to Add a Cooked Material to a Level Results in a Crash
#rb Jamie.Dale
Details:
- The bug UE-89128 is possibly related to UE-89826 (at least on Mac) where the database file would fails to open successfully. Corrupted database/broken file API would fail to open the database file and will result in the assert below:
Assertion failed: (RequestFetchCount < 0 && LowestFetchedActivityId == 0) || (RequestFetchCount > 0 && LowestFetchedActivityId > 1) [File:/Users/build/Build/++UE4+Licensee/Sync/Engine/Plugins/Developer/Concert/ConcertSync/ConcertSyncClient/Source/ConcertSyncClient/Private/ConcertActivityStream.cpp] [Line: 66]
This CL fix can be tested by:
1. Launch the Editor, generate a crash with 'debug crash' command.
2. Comment 'SessionDatabase->Open(Session->GetSessionWorkingDirectory());' in Engine\Plugins\Developer\Concert\ConcertSync\ConcertSyncServer\Source\ConcertSyncServer\Private\ConcertSyncServerLiveSession.cpp to simulate SQLite failing to open the database.
3. Recompile CrashReportClientEditor(Windows) or UnrealRecoverySvc(Mac/Linux)
4. Relaunch the editor.
#ROBOMERGE-SOURCE: CL 12393668 in //UE4/Release-4.25/... via CL 12393671
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)
[CL 12403482 by patrick laflamme in Release-Engine-Staging branch]