Files
UnrealEngineUWP/Engine/Source/Editor/TranslationEditor/Private/ITranslationEditor.cpp
justin hare f75e38db4b Fixing instances where several FAssetEditorToolkit-derived editors treat a close request as a close command, prematurely cleaning up in anticipation of closure. This can leave an editor in a dysfunctional state if other code checks whether the editor *could* be closed without actually closing it.
For context, other editors commonly use OnRequestClose as an opportunity to see if their data has changed, and pop up a message box asking the user if they want to save or cancel the closure. Actual cleanup is performed in OnClose() or as part of their destructor.

#jira none
#rb alejandro.arango tom.tillotson patrick.hardy
#preflight 60b0079c072a1d00012bc01e

[CL 16495334 by justin hare in ue5-main branch]
2021-05-27 21:17:19 -04:00

97 lines
3.6 KiB
C++

// Copyright Epic Games, Inc. All Rights Reserved.
#include "ITranslationEditor.h"
#include "Modules/ModuleManager.h"
#include "TranslationEditorModule.h"
#include "TranslationPickerWidget.h"
#include "LocalizationConfigurationScript.h"
/** To keep track of what translation editors are open editing which archive files */
TMap<FString, ITranslationEditor*> ITranslationEditor::OpenTranslationEditors = TMap<FString, ITranslationEditor*>();
void ITranslationEditor::OpenTranslationEditor(const FString& InManifestFile, const FString& InNativeArchiveFile, const FString& InArchiveFileToEdit)
{
// Only open a new translation editor if there isn't another one open for this archive file already
if (!OpenTranslationEditors.Contains(InArchiveFileToEdit))
{
FTranslationEditorModule& TranslationEditorModule = FModuleManager::LoadModuleChecked<FTranslationEditorModule>("TranslationEditor");
bool bLoadedSuccessfully = false;
ITranslationEditor* NewTranslationEditor = (ITranslationEditor*)&(TranslationEditorModule.CreateTranslationEditor(InManifestFile, InNativeArchiveFile, InArchiveFileToEdit, bLoadedSuccessfully).Get());
NewTranslationEditor->RegisterTranslationEditor();
if (!bLoadedSuccessfully)
{
NewTranslationEditor->CloseWindow();
}
}
else
{
// If already editing this archive file, flash the tab that contains the editor that has that file open
ITranslationEditor* OpenEditor = *OpenTranslationEditors.Find(InArchiveFileToEdit);
OpenEditor->FocusWindow();
}
}
void ITranslationEditor::OpenTranslationEditor(ULocalizationTarget* const LocalizationTarget, const FString& CultureToEdit)
{
check(LocalizationTarget);
const FString ManifestFile = LocalizationConfigurationScript::GetManifestPath(LocalizationTarget);
FString NativeCultureName;
if (LocalizationTarget->Settings.SupportedCulturesStatistics.IsValidIndex(LocalizationTarget->Settings.NativeCultureIndex))
{
NativeCultureName = LocalizationTarget->Settings.SupportedCulturesStatistics[LocalizationTarget->Settings.NativeCultureIndex].CultureName;
}
const FString NativeArchiveFile = NativeCultureName.IsEmpty() ? FString() : LocalizationConfigurationScript::GetArchivePath(LocalizationTarget, NativeCultureName);
const FString ArchiveFile = LocalizationConfigurationScript::GetArchivePath(LocalizationTarget, CultureToEdit);
// Only open a new translation editor if there isn't another one open for this archive file already
if (!OpenTranslationEditors.Contains(ArchiveFile))
{
FTranslationEditorModule& TranslationEditorModule = FModuleManager::LoadModuleChecked<FTranslationEditorModule>("TranslationEditor");
bool bLoadedSuccessfully = false;
ITranslationEditor* NewTranslationEditor = (ITranslationEditor*)&(TranslationEditorModule.CreateTranslationEditor(LocalizationTarget, CultureToEdit, bLoadedSuccessfully).Get());
NewTranslationEditor->RegisterTranslationEditor();
if (!bLoadedSuccessfully)
{
NewTranslationEditor->CloseWindow();
}
}
else
{
// If already editing this archive file, flash the tab that contains the editor that has that file open
ITranslationEditor* OpenEditor = *OpenTranslationEditors.Find(ArchiveFile);
OpenEditor->FocusWindow();
}
}
void ITranslationEditor::OpenTranslationPicker()
{
if (!TranslationPickerManager::IsPickerWindowOpen())
{
TranslationPickerManager::OpenPickerWindow();
}
}
void ITranslationEditor::RegisterTranslationEditor()
{
ITranslationEditor::OpenTranslationEditors.Add(ArchiveFilePath, this);
}
void ITranslationEditor::UnregisterTranslationEditor()
{
OpenTranslationEditors.Remove(ArchiveFilePath);
}
void ITranslationEditor::OnClose()
{
ITranslationEditor::UnregisterTranslationEditor();
}