paul chipchase 548ec539c0 Prevent bulkdata objects being saved with duplicate guids when saving a level created from a template. ...

#rb Francis.Hurteau
#jira UE-223781
#lockdown mark.lintott

- This issue was originally fixed in CL 23787156 but since then the editor has changed it's loading path and the 'LOAD_RegenerateBulkDataGuids' flag was no longer being passed to all of the packages being loaded as part of the map template.
- Taking a step back, the problem here is that the .umap package is correctly marked as being instanced but it's associated _BuiltData.uasset is not, so this time we will try fixing that instead by adding info about the _BuiltData.uasset package to the FLinkerInstancingContext being passed into the ::LoadPackage request. FEditorBulkData should then be made aware that it needs to generate new guids for the textures within that package.

- Deprecated LOAD_RegenerateBulkDataGuids as it is no longer needed as this was our only usecase.
- Deprecated FLinkerLoad::ShouldRegenerateGuids and removed the code using it from FEditorBulkData.

[CL 37221263 by paul chipchase in 5.5 branch]

2024-10-17 07:24:45 -04:00

..

SavePackage

Updating Dev-Release-5.5 from Main at CL #36144969

2024-09-10 10:26:02 -04:00

AnsiStrProperty.cpp

Added FUtf8StrProperty and FAnsiStrProperty.

2024-04-15 19:00:49 -04:00

AnyPackagePrivate.h

…

AssetRegistryTagsContext.cpp

…

Class.cpp

Fix Static Analysis warning in Class.cpp

2024-10-11 19:11:41 -04:00

ConstructorHelpers.cpp

…

CookedMetaData.cpp

Add support for allowing targets to opt into using the engine metadata API even in runtime by defining WITH_METADATA in a project target file.

2024-06-27 07:18:36 -04:00

CoreNative.cpp

Fix arrays subobject instanciation in non editor builds when saved with OverridableSerialization

2024-08-09 15:08:45 -04:00

CoreNet.cpp

Fixed linker errors on some console platform when building modular builds. Fixes involves moving ctor/dtor and friends from header to cpp and dll import/export

2024-08-21 13:44:16 -04:00

CoreRedirects.cpp

Updating Dev-Release-5.5 from Main at CL #36144969

2024-09-10 10:26:02 -04:00

DeferredRegistry.cpp

…

DeferredRegistry.h

…

DynamicallyTypedValue.cpp

…

EditPropertyChain.cpp

…

Enum.cpp

Replaced usage of FInternationalization::ForUseOnlyByLocMacroAndGraphNodeTextLiterals_CreateText with FText::AsLocalizable_Advanced

2024-10-01 19:45:55 -04:00

EnumProperty.cpp

Deprecating FProperty::ElementSize for public access and introducing accessors. Instead of accessing the variable directly, use GetElementSize and SetElementSize in order to facilitate a future change of underlying storage type (to pack FProperty tighter and save some memory).

2024-08-09 16:04:11 -04:00

ExpandingChunkedList.h

…

Field.cpp

Replaced usage of FInternationalization::ForUseOnlyByLocMacroAndGraphNodeTextLiterals_CreateText with FText::AsLocalizable_Advanced

2024-10-01 19:45:55 -04:00

FieldPath.cpp

Deprecated GetSerializeContext and SetSerializeContext on FArchive

2024-05-30 16:02:03 -04:00

FieldPathProperty.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

FindStronglyConnected.cpp

…

FindStronglyConnected.h

…

GarbageCollection.cpp

Updating Dev-Release-5.5 from Main at CL #36144969

2024-09-10 10:26:02 -04:00

GarbageCollectionHistory.cpp

…

GarbageCollectionInternal.h

…

GarbageCollectionInternalFlags.h

Restoring EInternalObjectFlags::Unreachable to make sure FObjectItem::IsUnreachable() is thread safe.

2024-05-17 03:32:15 -04:00

GarbageCollectionSchema.cpp

…

GarbageCollectionTesting.cpp

…

GarbageCollectionTesting.h

…

GarbageCollectionVerification.cpp

Restoring EInternalObjectFlags::Unreachable to make sure FObjectItem::IsUnreachable() is thread safe.

2024-05-17 03:32:15 -04:00

GarbageCollectionVerification.h

…

GCObjectInfo.cpp

…

GCScopeLock.h

…

GCVerseCellInfo.cpp

…

ICookInfo.cpp

IncrementalCook: Add ReferencedSet.txt for use when staging from a zen oplog that could include previous-cook entries than were no longer referenced from the most recent cook.

2024-10-01 19:46:19 -04:00

ImportExportCollector.cpp

Cooker: SkipOnlyEditorOnly: Fix BlueprintGeneratedClass's adapter that declares all imports from UBlueprint to exclude imports from editor-only components on the class default object, or from any other editor-only non-blueprint-node objects within the package. We now only allow editor-only objects if they are subobjects of the UBlueprint.

2024-08-09 10:41:26 -04:00

InstanceDataObjectUtils.cpp

Disable IDOs for Fortnite 32.xx releases

2024-10-04 16:50:30 -04:00

Interface.cpp

…

LazyObjectPtr.cpp

Fixed remapping of lazy object ptr in PIE : now a default FGuid is remapped to default FGuid

2024-04-19 13:37:17 -04:00

Linker.cpp

Deprecated GetSerializeContext and SetSerializeContext on FArchive

2024-05-30 16:02:03 -04:00

LinkerDiff.cpp

…

LinkerInstancingContext.cpp

Replaced EAutomationTestFlags::ApplicationContextMask with EAutomationTestFlags_ApplicationContextMask.

2024-06-13 07:06:47 -04:00

LinkerLoad.cpp

Prevent bulkdata objects being saved with duplicate guids when saving a level created from a template.

2024-10-17 07:24:45 -04:00

LinkerLoadImportBehavior.cpp

…

LinkerManager.cpp

[Linker]

2024-08-01 09:44:38 -04:00

LinkerManager.h

…

LinkerPlaceholderBase.cpp

…

LinkerPlaceholderBase.h

…

LinkerPlaceholderBase.inl

…

LinkerPlaceholderClass.cpp

…

LinkerPlaceholderClass.h

…

LinkerPlaceholderExportObject.cpp

…

LinkerPlaceholderExportObject.h

…

LinkerPlaceholderFunction.cpp

…

LinkerPlaceholderFunction.h

…

LinkerSave.cpp

Add a new feature allowing bulkdata cooked output to be split into smaller files to help with data organization and patching efforts.

2024-10-01 18:59:56 -04:00

MetaData.cpp

…

Obj.cpp

[Config] No longer skip EditorOnly properties when not in Editor (introduced in CL 400612) so standalone mode (-game) will be consistent with Editor and PIE.

2024-10-01 19:06:44 -04:00

ObjectBaseUtility.cpp

…

ObjectFwd.cpp

…

ObjectHandleIndex.cpp

Further revise TObjectPtr to avoid indirection by keeping references to placeholder-typed objects unresolved.

2024-05-29 11:43:30 -04:00

ObjectHandleTracking.cpp

Updating Dev-Release-5.5 from Main at CL #36144969

2024-09-10 10:26:02 -04:00

ObjectMemoryAnalyzer.cpp

…

ObjectPathId.cpp

…

ObjectPathId.h

…

ObjectPtr.cpp

…

ObjectRedirector.cpp

Create a placeholder type object on failure to resolve a type import through an existing redirector asset at load time.

2024-04-01 17:38:29 -04:00

ObjectRef.cpp

…

ObjectRename.cpp

Remove all simple usage of REN_ForceNoResetLoaders from the codebase since the flag has been deprecated and currently does nothing. Simple in this case is direct use of the flag with no conditional logic. More complex uses were removed in another change.

2024-06-17 11:55:02 -04:00

ObjectResource.cpp

Add a new feature allowing bulkdata cooked output to be split into smaller files to help with data organization and patching efforts.

2024-10-01 18:59:56 -04:00

ObjectSerializeAccessScope.cpp

…

ObjectSerializeAccessScope.h

…

ObjectVisibility.cpp

[ObjectVisibility]

2024-06-27 06:40:34 -04:00

OverridableManager.cpp

Change BP reinstancing to use the archetype caching system that was previously only for override serialization.

2024-10-01 20:08:11 -04:00

OverriddenPropertySet.cpp

Change BP reinstancing to use the archetype caching system that was previously only for override serialization.

2024-10-01 20:08:11 -04:00

Package.cpp

Fixing a bug where the GC would not be aware of package metadata in WITH_METADATA builds. (Bug found by [at]danny.couture)

2024-09-04 10:55:46 -04:00

PackageFileSummary.cpp

…

PackageReload.cpp

Remove all simple usage of REN_ForceNoResetLoaders from the codebase since the flag has been deprecated and currently does nothing. Simple in this case is direct use of the flag with no conditional logic. More complex uses were removed in another change.

2024-06-17 11:55:02 -04:00

PackageRelocation.cpp

…

PackageResourceIoDispatcherBackend.cpp

Add a new feature allowing bulkdata cooked output to be split into smaller files to help with data organization and patching efforts.

2024-10-01 18:59:56 -04:00

PackageResourceIoDispatcherBackend.h

Add a new feature allowing bulkdata cooked output to be split into smaller files to help with data organization and patching efforts.

2024-10-01 18:59:56 -04:00

PackageResourceManager.cpp

Add a new feature allowing bulkdata cooked output to be split into smaller files to help with data organization and patching efforts.

2024-10-01 18:59:56 -04:00

PackageResourceManagerFile.cpp

Add a new feature allowing bulkdata cooked output to be split into smaller files to help with data organization and patching efforts.

2024-10-01 18:59:56 -04:00

PackageTrailer.cpp

…

PerPlatformProperties.cpp

Allow users to create PerPlatformProperties for types outside Engine.

2024-05-03 04:27:33 -04:00

PrimaryAssetId.cpp

SerializeForLog implementations

2024-07-24 16:41:58 -04:00

Property.cpp

Modified the PropertyVisitor API to include the instance data for the parent struct.

2024-10-07 10:21:38 -04:00

PropertyAccessUtil.cpp

Deprecating FProperty::ElementSize for public access and introducing accessors. Instead of accessing the variable directly, use GetElementSize and SetElementSize in order to facilitate a future change of underlying storage type (to pack FProperty tighter and save some memory).

2024-08-09 16:04:11 -04:00

PropertyArray.cpp

Modified the PropertyVisitor API to include the instance data for the parent struct.

2024-10-07 10:21:38 -04:00

PropertyBagRepository.cpp

Updating Dev-Release-5.5 from Main at CL #36144969

2024-09-10 10:26:02 -04:00

PropertyBaseObject.cpp

Modified the PropertyVisitor API to include the instance data for the parent struct.

2024-10-07 10:21:38 -04:00

PropertyBool.cpp

Deprecating FProperty::ElementSize for public access and introducing accessors. Instead of accessing the variable directly, use GetElementSize and SetElementSize in order to facilitate a future change of underlying storage type (to pack FProperty tighter and save some memory).

2024-08-09 16:04:11 -04:00

PropertyByte.cpp

Fixed conversions in enum serialization

2024-08-06 17:02:22 -04:00

PropertyClass.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyDelegate.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyDouble.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyFloat.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyHelper.cpp

Added creation of transient enums for IDOs to support unknown enumerators

2024-08-06 10:38:55 -04:00

PropertyHelper.h

Added tracking of unknown enum names

2024-07-30 14:56:36 -04:00

PropertyInt8.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyInt16.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyInt64.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyInt.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyInterface.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyLazyObjectPtr.cpp

Added missing GetObjectPtrPropertyValue_InContainer overloads.

2024-08-30 17:54:33 -04:00

PropertyMap.cpp

Modified the PropertyVisitor API to include the instance data for the parent struct.

2024-10-07 10:21:38 -04:00

PropertyMulticastDelegate.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyName.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyNumeric.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyObject.cpp

Trivial changes to force an integration to Release-32.00.

2024-10-01 18:00:28 -04:00

PropertyOptional.cpp

Modified the PropertyVisitor API to include the instance data for the parent struct.

2024-10-07 10:21:38 -04:00

PropertyPathName.cpp

Core - Added [[nodiscard]] to most GetTypeHash() overloads in Core

2024-03-18 20:08:43 -04:00

PropertyPathNameTree.cpp

Added loading of missing structs into IDOs

2024-05-10 14:05:52 -04:00

PropertyPrivate.cpp

Renamed old-style namespace.

2024-03-07 08:44:27 -05:00

PropertySet.cpp

Modified the PropertyVisitor API to include the instance data for the parent struct.

2024-10-07 10:21:38 -04:00

PropertySoftClassPtr.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertySoftObjectPtr.cpp

Added missing GetObjectPtrPropertyValue_InContainer overloads.

2024-08-30 17:54:33 -04:00

PropertyStruct.cpp

Modified the PropertyVisitor API to include the instance data for the parent struct.

2024-10-07 10:21:38 -04:00

PropertyTag.cpp

Treat always-overridden properties as a 'replace' operation in the TPS data stream on save/write.

2024-08-28 15:08:57 -04:00

PropertyTempVal.cpp

…

PropertyTypeName.cpp

Fix some fun TeleportTo found bugs with child actor components by adding a new transactionally safe RWLock, and also fixing a bug in the existing transactionally safe critical section code.

2024-07-18 07:43:12 -04:00

PropertyUInt16.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyUInt32.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyUInt64.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

PropertyVisitor.cpp

Converted OverridableManager API to use FPropertyVistorPath and forwarded existing API to this new one.

2024-08-06 19:35:27 -04:00

PropertyWeakObjectPtr.cpp

Added missing GetObjectPtrPropertyValue_InContainer overloads.

2024-08-30 17:54:33 -04:00

ReachabilityAnalysisState.cpp

Fix a Verse GC race between BeginCollection and EnableExternalControl

2024-06-25 18:12:10 -04:00

ReachabilityAnalysisState.h

Fixing race condition when disabling disregard for GC set with multithreading enabled

2024-04-10 06:35:37 -04:00

RedirectionSummary.cpp

IterativeCooker: Add build dependency on CoreRedirects that affect a package's runtime dependencies. The names of runtime dependencies are stored in the package's imports, so if the change names due to a redirect then we need to recook them.

2024-05-21 15:41:10 -04:00

RedirectionSummary.h

IterativeCooker: Add build dependency on CoreRedirects that affect a package's runtime dependencies. The names of runtime dependencies are stored in the package's imports, so if the change names due to a redirect then we need to recook them.

2024-05-21 15:41:10 -04:00

ReferenceChainSearch.cpp

Passing in a verbosity argument in FReferenceChainSearch::PrintResults

2024-08-15 05:00:56 -04:00

ReferencerFinder.cpp

Also run CollectReferencers when searching for referencers, as it is fast and catches things that override ARO or UE::GC::DeclareIntrinsicMembers, the former is used by UObjectRedirector and as such references from UObjectRedirectors were not being reported by FindReferencers

2024-08-30 17:46:45 -04:00

ReferencerInformation.cpp

…

ReferenceToken.cpp

…

SavePackage2.cpp

Add a new feature allowing bulkdata cooked output to be split into smaller files to help with data organization and patching efforts.

2024-10-01 18:59:56 -04:00

SavePackage.cpp

…

ScriptCore.cpp

[LLM] Move more EngineMisc allocations to specific categories, mark more assets/objects for LLM tracking

2024-10-09 12:45:55 -04:00

ScriptStackTracker.cpp

…

SoftObjectPath.cpp

Avoid soft path serialization when saving weak and strong references with an object reference collector

2024-10-03 13:42:13 -04:00

SparseClassDataUtils.cpp

…

SparseDelegate.cpp

Fix FSparseDelegate to behave correctly under transactional conditions.

2024-06-27 13:06:38 -04:00

StrongObjectPtr.cpp

[UObject]

2024-05-01 08:26:48 -04:00

StrProperty.cpp

Added FUtf8StrProperty and FAnsiStrProperty.

2024-04-15 19:00:49 -04:00

StrProperty.cpp.inl

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

StrPropertyIncludes.cpp.inl

Added FUtf8StrProperty and FAnsiStrProperty.

2024-04-15 19:00:49 -04:00

StructOnScope.cpp

…

StructScriptLoader.cpp

…

StructScriptLoader.h

…

TemplateString.cpp

…

TextProperty.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

TopLevelAssetPath.cpp

SerializeForLog implementations

2024-07-24 16:41:58 -04:00

UnrealType.cpp

[Backout] preformance regression - CL32707000

2024-04-12 11:07:47 -04:00

UObjectAllocator.cpp

Updating Dev-Release-5.5 from Main at CL #36144969

2024-09-10 10:26:02 -04:00

UObjectArchetype.cpp

Change BP reinstancing to use the archetype caching system that was previously only for override serialization.

2024-10-01 20:08:11 -04:00

UObjectArchetypeInternal.h

…

UObjectArray.cpp

Check FName memory availability alongside UObject table availability

2024-10-08 19:25:05 -04:00

UObjectBase.cpp

Moving freeing of UObject's InternalIndex out of UObject destructor to not lock the global UObjectArray when the destructor runs (otherwise it may result in hangs)

2024-07-18 03:45:26 -04:00

UObjectBaseUtility.cpp

Fix reloading of UObjects while iterating

2024-07-30 12:14:40 -04:00

UObjectClusters.cpp

Restoring EInternalObjectFlags::Unreachable to make sure FObjectItem::IsUnreachable() is thread safe.

2024-05-17 03:32:15 -04:00

UObjectGlobals.cpp

Updating Dev-Release-5.5 from Main at CL #36144969

2024-09-10 10:26:02 -04:00

UObjectHash.cpp

[LLM] Properly clear LLM tagset scope

2024-10-01 19:10:20 -04:00

UObjectHashPrivate.h

…

UObjectLinker.cpp

UObject::SetLinker: Add callstack information in error reported when detaching from existing linker while the object still needs loading.

2024-06-25 13:39:11 -04:00

UObjectMarks.cpp

[ZenLoader]

2024-06-25 07:12:54 -04:00

UObjectNetIndex.cpp

…

UObjectThreadContext.cpp

Updating Dev-Release-5.5 from Main at CL #36144969

2024-09-10 10:26:02 -04:00

Utf8StrProperty.cpp

Added FUtf8StrProperty and FAnsiStrProperty.

2024-04-15 19:00:49 -04:00

VerseStringProperty.cpp

Native string fields and localization with substitution

2024-08-29 12:32:18 -04:00

VerseValueProperty.cpp

Moved FProperty constructors into their .cpp files.

2024-08-05 12:24:38 -04:00

WeakObjectPtr.cpp

Added some specific overloads for TObjectPtr.

2024-08-30 15:11:51 -04:00