Files
UnrealEngineUWP/Engine/Plugins/Developer/PerforceSourceControl
paul chipchase d27af6a0ee Fix assert when failing to clobber a file.
#rb juan.legaz
#jira UE-203769
#rnx

- The problem was introduced in my change CL 30208400 where I mistakenly believed that all messages should be routed through ClientUser::Message so added asserts to detect and classes derived from FP4ClientUser calling the lower level Info/Error methods. Server messages do indeed all go through ::Message but local client issues can call the lower level methods directly so my assumption was unsafe. To make matters worse the most common local error we have concerns clobbering files but I tend to run workspaces with "clobber" option rather than "noclobber" so I did not see the problem in testing.
- We once again implement ClientUser::OutputInfo and ClientUser::OutputError and store the messages in the correct array.
- The default implementation of ClientUser::HandleError calls ::OutputError so there is no point implementing this method but we also don't need to assert if it is called.

[CL 31778381 by paul chipchase in ue5-main branch]
2024-02-23 16:55:11 -05:00
..