Files
UnrealEngineUWP/Engine/Source/Programs/LiveCodingConsole/Private/LiveCodingManifest.cpp
ben marsh c3e532b195 Live Coding: Fix crashes when patching adaptive non-unity files in game modules containing static global variables.
Live++ reads object files at startup for game modules, and assigns unique ids to each compiland (used to disambiguate static variables). When compiling the patch, these compilands are modified to reference a unique id for the unity blob, causing the variables to be reconstructed.

Solution is to generate a JSON file to each output directory containing object files containing the mapping, and to use that to assign compiland ids at startup.

#rb none
#jira UE-74036

#ROBOMERGE-SOURCE: CL 6455253 in //UE4/Release-4.22/...
#ROBOMERGE-BOT: RELEASE (Release-4.22 -> Main)

[CL 6455273 by ben marsh in Main branch]
2019-05-14 18:12:06 -04:00

101 lines
2.6 KiB
C++

// Copyright 1998-2019 Epic Games, Inc. All Rights Reserved.
#include "LiveCodingManifest.h"
#include "Misc/FileHelper.h"
bool FLiveCodingManifest::Read(const TCHAR* FileName, FString& OutFailReason)
{
// Read the file to a string
FString FileContents;
if (!FFileHelper::LoadFileToString(FileContents, FileName))
{
OutFailReason = FString::Printf(TEXT("Unable to read from %s"), FileName);
return false;
}
// Deserialize a JSON object from the string
TSharedPtr< FJsonObject > Object;
TSharedRef< TJsonReader<> > Reader = TJsonReaderFactory<>::Create(FileContents);
if ( !FJsonSerializer::Deserialize(Reader, Object) || !Object.IsValid() )
{
OutFailReason = FString::Printf(TEXT("Unable to parse %s"), FileName);
return false;
}
// Parse the data
if (!Parse(*Object, OutFailReason))
{
OutFailReason = FString::Printf(TEXT("Unable to parse %s (%s)"), FileName, *OutFailReason);
return false;
}
return true;
}
bool FLiveCodingManifest::Parse(FJsonObject& Object, FString& OutFailReason)
{
if (!Object.TryGetStringField(TEXT("LinkerPath"), LinkerPath))
{
OutFailReason = TEXT("missing LinkerPath field");
return false;
}
const TSharedPtr<FJsonObject>* EnvironmentObject;
if (Object.TryGetObjectField(TEXT("LinkerEnvironment"), EnvironmentObject))
{
for(const TPair<FString, TSharedPtr<FJsonValue>>& Pair : EnvironmentObject->Get()->Values)
{
const FJsonValue* Value = Pair.Value.Get();
if (Value->Type == EJson::String)
{
LinkerEnvironment.Add(Pair.Key, Value->AsString());
}
}
}
const TArray<TSharedPtr<FJsonValue>>* ModulesArray;
if (!Object.TryGetArrayField(TEXT("Modules"), ModulesArray))
{
OutFailReason = TEXT("missing Modules field");
return false;
}
for (const TSharedPtr<FJsonValue>& ModuleValue : *ModulesArray)
{
if (ModuleValue->Type != EJson::Object)
{
OutFailReason = TEXT("invalid module object");
return false;
}
const FJsonObject& ModuleObject = *ModuleValue->AsObject();
FString OutputFile;
if (!ModuleObject.TryGetStringField(TEXT("Output"), OutputFile))
{
OutFailReason = TEXT("missing module 'Output' field");
return false;
}
const TArray<TSharedPtr<FJsonValue>>* Inputs;
if (!ModuleObject.TryGetArrayField(TEXT("Inputs"), Inputs))
{
OutFailReason = TEXT("missing module 'Inputs' field");
return false;
}
TArray<FString>& InputFiles = BinaryToObjectFiles.Add(OutputFile);
for (const TSharedPtr<FJsonValue>& Input : *Inputs)
{
if (Input->Type != EJson::String)
{
OutFailReason = TEXT("invalid module input field");
return false;
}
InputFiles.Add(Input->AsString());
}
}
return true;
}