Arne Schober 6b4c570371 DR - The issue is that GameThreadShaderMap and the RenderingThreadShaderMap can get out of sync. And one case of this is when DefaultMaterials are forced though the !bApplyCompletedShaderMapForRendering path because bSynchronousCompile is set. Although it is noted that "if !bApplyCompletedShaderMapForRendering, RenderingThreadShaderMap must be set elsewhere to match up with the new value of GameThreadShaderMap" the Result is actually a dangling reference of RenderingThreadShaderMap. Therefore I removed bApplyCompletedShaderMapForRendering and force the synchronization of the RenderingThreadShaderMap via the SetGameThreadShaderMap interface each and every time it is changed. ...

#jira UE-67622, UE-74710
#RB Rolando.Caloca, Marcus.Wassmer

[CL 6676473 by Arne Schober in Dev-Rendering branch]

2019-05-30 11:56:02 -04:00

..

Private

DR - The issue is that GameThreadShaderMap and the RenderingThreadShaderMap can get out of sync. And one case of this is when DefaultMaterials are forced though the !bApplyCompletedShaderMapForRendering path because bSynchronousCompile is set. Although it is noted that "if !bApplyCompletedShaderMapForRendering, RenderingThreadShaderMap must be set elsewhere to match up with the new value of GameThreadShaderMap" the Result is actually a dangling reference of RenderingThreadShaderMap. Therefore I removed bApplyCompletedShaderMapForRendering and force the synchronization of the RenderingThreadShaderMap via the SetGameThreadShaderMap interface each and every time it is changed.

2019-05-30 11:56:02 -04:00

Public

Merging //UE4/Dev-Main@4680011 to Dev-Rendering (//UE4/Dev-Rendering)

2019-01-03 19:28:34 -05:00

MaterialUtilities.Build.cs

Merging //UE4/Dev-Main@4680011 to Dev-Rendering (//UE4/Dev-Rendering)

2019-01-03 19:28:34 -05:00