You've already forked UnrealEngineUWP
mirror of
https://github.com/izzy2lost/UnrealEngineUWP.git
synced 2026-03-26 18:15:20 -07:00
bbc5c94cd1
#rb Sebastian.Nordgren #rnx #jira UE-158934 #preflight 62c829272823f28cf273a5aa ### Perforce Connection - The test for bRequireWorkspace was inverted, we only want to require a workspace if the workspace is NOT optional. - Combined the two if statements checking if we should try and auto assign a workspace to reduce indentation. - Changed use of Len() == 0 to IsEmpty() for consistency - Do not take the workspace name from the default environment if bRequireWorkspace is false ### PerforceSourceControlProvider - When switching workspaces use EConnectionOptions::WorkspaceOptional when establishing the connection since we are providing the workspace name. - Remove the check, the entire point of ::EnsureValidConnection is that it can change the workspace requested. ### PerforceSourceControloOperations - Running FConnect command with perforce does not actually connect, but rather validates the clientspec. This needed to be changed to not give an error if the clientspec is empty. - I'd rather allow FConnect to work for connections without a clientspec rather than avoid calling it at a higher level in case a different source control provider would require FConnect to be called at this point. Not calling it requires too much knowledge of the target source control provider to be safe. ### Future Work - Currently the optional workspace flag is used to indicate that the workspace is being set for the connection manually and we don't want to auto evalute the workspace name. However we are really confusing two different issues here 1) having no client 2) having a specific client. In the second case we might want to allow defaulting to a valid workspace. So overall it would be better to have a flag indicating that it is okay to have no clientspec name and another flag indicating that we want to fallback to a valid name if the one we provided was not valid. [CL 21008487 by paul chipchase in ue5-main branch]