Files
UnrealEngineUWP/Engine/Source/Programs/UnrealBuildTool/Executors/ParallelExecutor.cs
Joe Kirchoff 9f494a0864 UnrealBuildTool: Log PVS-Studio failure as an error
#rnx
#rb trivial
#preflight 620d58683609e19371479143

[CL 19020701 by Joe Kirchoff in ue5-main branch]
2022-02-16 15:16:28 -05:00

388 lines
13 KiB
C#

// Copyright Epic Games, Inc. All Rights Reserved.
using EpicGames.Core;
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Text.Json;
using System.Threading;
using System.Threading.Tasks;
namespace UnrealBuildTool
{
/// <summary>
/// This executor uses async Tasks to process the action graph
/// </summary>
class ParallelExecutor : ActionExecutor
{
/// <summary>
/// Maximum processor count for local execution.
/// </summary>
[XmlConfigFile]
private static int MaxProcessorCount = int.MaxValue;
/// <summary>
/// Processor count multiplier for local execution. Can be below 1 to reserve CPU for other tasks.
/// When using the local executor (not XGE), run a single action on each CPU core. Note that you can set this to a larger value
/// to get slightly faster build times in many cases, but your computer's responsiveness during compiling may be much worse.
/// This value is ignored if the CPU does not support hyper-threading.
/// </summary>
[XmlConfigFile]
private static double ProcessorCountMultiplier = 1.0;
/// <summary>
/// Free memory per action in bytes, used to limit the number of parallel actions if the machine is memory starved.
/// Set to 0 to disable free memory checking.
/// </summary>
[XmlConfigFile]
private static double MemoryPerActionBytes = 1.5 * 1024 * 1024 * 1024;
/// <summary>
/// When enabled, will stop compiling targets after a compile error occurs.
/// </summary>
[XmlConfigFile]
private static bool bStopCompilationAfterErrors = false;
/// <summary>
/// Whether to show compilation times along with worst offenders or not.
/// </summary>
[XmlConfigFile]
private static bool bShowCompilationTimes = false;
/// <summary>
/// Whether to show compilation times for each executed action
/// </summary>
[XmlConfigFile]
private static bool bShowPerActionCompilationTimes = false;
/// <summary>
/// Whether to log command lines for actions being executed
/// </summary>
[XmlConfigFile]
private static bool bLogActionCommandLines = false;
/// <summary>
/// Add target names for each action executed
/// </summary>
[XmlConfigFile]
private static bool bPrintActionTargetNames = false;
/// <summary>
/// How many processes that will be executed in parallel
/// </summary>
public int NumParallelProcesses { get; private set; }
private static readonly char[] LineEndingSplit = new char[] { '\n', '\r' };
public static int GetDefaultNumParallelProcesses()
{
double MemoryPerActionBytesComputed = Math.Max(MemoryPerActionBytes, MemoryPerActionBytesOverride);
if (MemoryPerActionBytesComputed > MemoryPerActionBytes)
{
Log.TraceInformation($"Overriding MemoryPerAction with target-defined value of {MemoryPerActionBytesComputed / 1024 / 1024 / 1024} bytes");
}
return Utils.GetMaxActionsToExecuteInParallel(MaxProcessorCount, ProcessorCountMultiplier, Convert.ToInt64(MemoryPerActionBytesComputed));
}
/// <summary>
/// Constructor
/// </summary>
/// <param name="MaxLocalActions">How many actions to execute in parallel</param>
public ParallelExecutor(int MaxLocalActions)
{
XmlConfig.ApplyTo(this);
// if specified this caps how many processors we can use
if (MaxLocalActions > 0)
{
NumParallelProcesses = MaxLocalActions;
}
else
{
// Figure out how many processors to use
NumParallelProcesses = GetDefaultNumParallelProcesses();
}
}
/// <summary>
/// Returns the name of this executor
/// </summary>
public override string Name
{
get { return "Parallel"; }
}
/// <summary>
/// Checks whether the task executor can be used
/// </summary>
/// <returns>True if the task executor can be used</returns>
public static bool IsAvailable()
{
return true;
}
private class ExecuteResults
{
public List<string> LogLines { get; private set; }
public int ExitCode { get; private set; }
public TimeSpan ExecutionTime { get; private set; }
public TimeSpan ProcessorTime { get; private set; }
public ExecuteResults(List<string> LogLines, int ExitCode, TimeSpan ExecutionTime, TimeSpan ProcessorTime)
{
this.LogLines = LogLines;
this.ExitCode = ExitCode;
this.ProcessorTime = ProcessorTime;
this.ExecutionTime = ExecutionTime;
}
public ExecuteResults(List<string> LogLines, int ExitCode)
{
this.LogLines = LogLines;
this.ExitCode = ExitCode;
}
}
/// <summary>
/// Executes the specified actions locally.
/// </summary>
/// <returns>True if all the tasks successfully executed, or false if any of them failed.</returns>
public override bool ExecuteActions(List<LinkedAction> InputActions)
{
int NumCompletedActions = 0;
int TotalActions = InputActions.Count;
int ActualNumParallelProcesses = Math.Min(TotalActions, NumParallelProcesses);
using ManagedProcessGroup ProcessGroup = new ManagedProcessGroup();
using SemaphoreSlim MaxProcessSemaphore = new SemaphoreSlim(ActualNumParallelProcesses, ActualNumParallelProcesses);
using ProgressWriter ProgressWriter = new ProgressWriter("Compiling C++ source code...", false);
Log.TraceInformation($"Building {TotalActions} {(TotalActions == 1 ? "action" : "actions")} with {ActualNumParallelProcesses} {(ActualNumParallelProcesses == 1 ? "process" : "processes")}...");
Dictionary<LinkedAction, Task<ExecuteResults>> Tasks = new Dictionary<LinkedAction, Task<ExecuteResults>>();
List<Task> AllTasks = new List<Task>();
using LogIndentScope Indent = new LogIndentScope(" ");
CancellationTokenSource CancellationTokenSource = new CancellationTokenSource();
CancellationToken CancellationToken = CancellationTokenSource.Token;
// Create a task for every action
foreach (LinkedAction Action in InputActions)
{
Task<ExecuteResults> ExecuteTask = ExecuteAction(Action, Tasks, ProcessGroup, MaxProcessSemaphore, CancellationToken);
Task LogTask = ExecuteTask.ContinueWith(antecedent => LogCompletedAction(Action, antecedent, CancellationTokenSource, ProgressWriter, TotalActions, ref NumCompletedActions), CancellationToken);
Tasks.Add(Action, ExecuteTask);
AllTasks.Add(ExecuteTask);
AllTasks.Add(LogTask);
}
// Wait for all tasks to complete
Task.WaitAll(AllTasks.ToArray(), CancellationToken);
if (bShowCompilationTimes)
{
Log.TraceInformation("");
if (ProcessGroup.TotalProcessorTime.Ticks > 0)
{
Log.TraceInformation($"Total CPU Time: {ProcessGroup.TotalProcessorTime.TotalSeconds} s");
Log.TraceInformation("");
}
if (Tasks.Count > 0)
{
Log.TraceInformation($"Compilation Time Top {Math.Min(20, Tasks.Count)}");
Log.TraceInformation("");
foreach (var Pair in Tasks.OrderByDescending(x => x.Value.Result.ExecutionTime).Take(20))
{
string Description = $"{(Pair.Key.Inner.CommandDescription ?? Pair.Key.Inner.CommandPath.GetFileNameWithoutExtension())} {Pair.Key.Inner.StatusDescription}".Trim();
if (Pair.Value.Result.ProcessorTime.Ticks > 0)
{
Log.TraceInformation($"{Description} [ Wall Time {Pair.Value.Result.ExecutionTime.TotalSeconds:0.00} s / CPU Time {Pair.Value.Result.ProcessorTime.TotalSeconds:0.00} s ]");
}
else
{
Log.TraceInformation($"{Description} [ Time {Pair.Value.Result.ExecutionTime.TotalSeconds:0.00} s ]");
}
}
Log.TraceInformation("");
}
}
// Return if all tasks succeeded
return Tasks.Values.All(x => x.Result.ExitCode == 0);
}
private async Task<ExecuteResults> ExecuteAction(LinkedAction Action, Dictionary<LinkedAction, Task<ExecuteResults>> Tasks, ManagedProcessGroup ProcessGroup, SemaphoreSlim MaxProcessSemaphore, CancellationToken CancellationToken)
{
Task? SemaphoreTask = null;
try
{
// Wait for Tasks list to be populated with any PrerequisiteActions
while (!Action.PrerequisiteActions.All(x => Tasks.ContainsKey(x)))
{
await Task.Delay(100, CancellationToken);
CancellationToken.ThrowIfCancellationRequested();
}
// Wait for all PrerequisiteActions to complete
ExecuteResults[] Results = await Task.WhenAll(Action.PrerequisiteActions.Select(x => Tasks[x]).ToArray());
// Cancel tasks if any PrerequisiteActions fail, unless a PostBuildStep
if (Action.ActionType != ActionType.PostBuildStep && Results.Any(x => x.ExitCode != 0))
{
throw new OperationCanceledException();
}
CancellationToken.ThrowIfCancellationRequested();
// Limit the number of concurrent processes that will run in parallel
SemaphoreTask = MaxProcessSemaphore.WaitAsync(CancellationToken);
await SemaphoreTask;
CancellationToken.ThrowIfCancellationRequested();
using ManagedProcess Process = new ManagedProcess(ProcessGroup, Action.CommandPath.FullName, Action.CommandArguments, Action.WorkingDirectory.FullName, null, null, ProcessPriorityClass.BelowNormal);
MemoryStream StdOutStream = new MemoryStream();
await Process.CopyToAsync(StdOutStream, CancellationToken);
CancellationToken.ThrowIfCancellationRequested();
Process.WaitForExit();
CancellationToken.ThrowIfCancellationRequested();
List<string> LogLines = Console.OutputEncoding.GetString(StdOutStream.GetBuffer(), 0, Convert.ToInt32(StdOutStream.Length)).Split(LineEndingSplit, StringSplitOptions.RemoveEmptyEntries).ToList();
int ExitCode = Process.ExitCode;
TimeSpan ProcessorTime = Process.TotalProcessorTime;
TimeSpan ExecutionTime = Process.ExitTime - Process.StartTime;
return new ExecuteResults(LogLines, ExitCode, ExecutionTime, ProcessorTime);
}
catch (OperationCanceledException)
{
return new ExecuteResults(new List<string>(), int.MaxValue);
}
catch (Exception Ex)
{
Log.WriteException(Ex, null);
return new ExecuteResults(new List<string>(), int.MaxValue);
}
finally
{
if (SemaphoreTask != null && SemaphoreTask.Status == TaskStatus.RanToCompletion)
{
MaxProcessSemaphore.Release();
}
}
}
private void LogCompletedAction(LinkedAction Action, Task<ExecuteResults> ExecuteTask, CancellationTokenSource CancellationTokenSource, ProgressWriter ProgressWriter, int TotalActions, ref int NumCompletedActions)
{
List<string> LogLines = new List<string>();
int ExitCode = int.MaxValue;
TimeSpan ExecutionTime = TimeSpan.Zero;
TimeSpan ProcessorTime = TimeSpan.Zero;
if (ExecuteTask.Status == TaskStatus.RanToCompletion)
{
ExecuteResults ExecuteTaskResult = ExecuteTask.Result;
LogLines = ExecuteTaskResult.LogLines;
ExitCode = ExecuteTaskResult.ExitCode;
ExecutionTime = ExecuteTaskResult.ExecutionTime;
ProcessorTime = ExecuteTaskResult.ProcessorTime;
}
// Write it to the log
string Description = string.Empty;
if (Action.bShouldOutputStatusDescription || LogLines.Count == 0)
{
Description = $"{(Action.CommandDescription ?? Action.CommandPath.GetFileNameWithoutExtension())} {Action.StatusDescription}".Trim();
}
else if (LogLines.Count > 0)
{
Description = $"{(Action.CommandDescription ?? Action.CommandPath.GetFileNameWithoutExtension())} {LogLines[0]}".Trim();
}
lock (ProgressWriter)
{
int CompletedActions;
CompletedActions = Interlocked.Increment(ref NumCompletedActions);
ProgressWriter.Write(CompletedActions, TotalActions);
// Cancelled
if (ExitCode == int.MaxValue)
{
Log.TraceInformation($"[{CompletedActions}/{TotalActions}] {Description} cancelled");
return;
}
string TargetDetails = "";
TargetDescriptor? Target = Action.Target;
if (bPrintActionTargetNames && Target != null)
{
TargetDetails = $"[{Target.Name} {Target.Platform} {Target.Configuration}]";
}
if (bLogActionCommandLines)
{
Log.TraceLog($"[{CompletedActions}/{TotalActions}]{TargetDetails} Command: {Action.CommandPath} {Action.CommandArguments}");
}
string CompilationTimes = "";
if (bShowPerActionCompilationTimes)
{
if (ProcessorTime.Ticks > 0)
{
CompilationTimes = $" (Wall: {ExecutionTime.TotalSeconds:0.00}s CPU: {ProcessorTime.TotalSeconds:0.00}s)";
}
else
{
CompilationTimes = $" (Wall: {ExecutionTime.TotalSeconds:0.00}s)";
}
}
Log.TraceInformation($"[{CompletedActions}/{TotalActions}]{TargetDetails}{CompilationTimes} {Description}");
foreach (string Line in LogLines.Skip(Action.bShouldOutputStatusDescription ? 0 : 1))
{
Log.TraceInformation(Line);
}
if (ExitCode != 0)
{
// BEGIN TEMPORARY TO CATCH PVS-STUDIO ISSUES
if (LogLines.Count == 0)
{
Log.TraceError($"{TargetDetails} {Description}: Exited with error code {ExitCode}");
Log.TraceInformation($"{TargetDetails} {Description}: WorkingDirectory {Action.WorkingDirectory}");
Log.TraceInformation($"{TargetDetails} {Description}: {Action.CommandPath} {Action.CommandArguments}");
}
// END TEMPORARY
// Cancel all other pending tasks
if (bStopCompilationAfterErrors)
{
CancellationTokenSource.Cancel();
}
}
}
}
}
/// <summary>
/// Publicly visible static class that allows external access to the parallel executor config
/// </summary>
public static class ParallelExecutorConfiguration
{
/// <summary>
/// Maximum number of processes that should be used for execution
/// </summary>
public static int MaxParallelProcesses { get { return ParallelExecutor.GetDefaultNumParallelProcesses(); } }
}
}