You've already forked UnrealEngineUWP
mirror of
https://github.com/izzy2lost/UnrealEngineUWP.git
synced 2026-03-26 18:15:20 -07:00
Change 1996384 by Andrew Brown: 322252 - EDITOR: Asset picker displays incorrect text when there are no filter results. Change 1996385 by Andrew Brown: 321858 - CRASH: Assertion failed: (Index >= 0) Function: STransformViewportToolBar::GetLocationGridLabel() STextBlock::CacheDesiredSize() Change 1996977 by Andrew Brown: 309685 - UE4: Adding an event/renaming an event on an event track in Matinee does not update the MatineeActor node in blueprint Change 2034873 by Jaroslaw Palczynski: More robust VS installation detection. Change 2039693 by Jaroslaw Palczynski: 327268 - RocketGDC: POSTLAUNCH: DEV: Make engine more robust against bad Visual Studio environment variables Change 1978978 by Jaroslaw Surowiec: - Removed obsolete AllowEliminatingReferences from the FArchive Change 2020326 by Maciej Mroz: pretest BP K2Node: RemovePinsFromOldPins function moved from K2Node to RemovePinsFromOldPins Change 2017608 by Maciej Mroz: pretest Some changes in SFortMissionEventSelector caused by FPinTypeTreeInfo Change 2017463 by Maciej Mroz: PinTypeSelector can lins unloaded UDStructs Change 2019979 by Maciej Mroz: pretest BP: Crash when performing Diff against Depot with blueprints containing Format Text nodes Change 2024469 by Maciej Mroz: MemberReference variable added to PinType. It's necessary for delegate's signature. Change 2024049 by Maciej Mroz: HasExternalBlueprintDependencies added to UK2Node_DynamicCast Change 2024586 by Maciej Mroz: FillSimpleMemberReference fix Change 2024472 by Maciej Mroz: workaround for delegates signature in pintype removed. Change 2023997 by Maciej Mroz: BP, UDStruc: Class UserDefinedStructEditorData added. It fixes many problems with undo/redo. Change 2021934 by Maciej Mroz: typo in a comment Change 2020355 by Maciej Mroz: Back out changelist 2020342 Change 2022178 by Maciej Mroz: CRASH: PRETEST: EDITOR: UDS: Crash when undo then redo new variable in struct that is used by blueprint Change 2021958 by Maciej Mroz: CRASH: PRETEST: EDITOR: UDS: Crash using variable of a type of copied struct in blueprint Change 1986247 by Maciej Mroz: User Defined Structures: circle dependency fixed. Early version. Change 1985107 by Maciej Mroz: UserDefinedStruct cannot have a field of a non-native type Change 1986278 by Maciej Mroz: pretest ensureMsgf in Struct::link Change 1986250 by Maciej Mroz: User Defined Struct: Non native classes are accepted types od values in structures. Change 1980955 by Maciej Mroz: Using AssetPtr and LazyPtr as UFunction parameter (intput or return) is explicitly disallowed. Change 2041215 by Maciej Mroz: ttp331249 BLOCKER: PRETEST: UI: Survive the Storm is missing the Mission HUD. Change 1984316 by Maciej Mroz: New User Defined Structure. WIP - there are still problems with circular dependencies. Change 2011616 by Maciej Mroz: UserDefinedStructures - various problems fixed. Change 2011609 by Maciej Mroz: more robust HasExternalBlueprintDependencies implementation Change 2016697 by Maciej Mroz: pretest BP: UDStruct - default value propagation in cooked build Change 2016288 by Maciej Mroz: pretest BP: UDStruct: Renaming variables wont break links from make/break nodes Change 1987637 by Maciej Mroz: CustomStruct icons placeholders Change 1987422 by Maciej Mroz: Better tooltips for variables in MyBlueprint Change 1991387 by Maciej Mroz: UDStructures fixes: Change 2029165 by Maciej Mroz: BP: better comment for incomatible pins Change2030016by Maciej Mroz: 8PRETEST: EDITOR: UDS: Defaults values aren't updated in struct type variables in blueprints Change 2030017 by Maciej Mroz: Unused UDStructure code removed (PPF_UseDefaultsForUDStructures) Change 2028856 by Maciej Mroz: BP: Pins with PC_Struct type are compatible only with exactly the same structure. (No derived structures are not handled as compatible). Change 2026701 by Maciej Mroz: k2: odd error on an add item node within a function (see attached image in details) Change 2028160 by Maciej Mroz: PRETEST: EDITOR: UDS: When deleting structures just after creating there is always some references in the memory Change 2028165 by Maciej Mroz: BP: BreakHitResult function has proper icon. Change 2033340 by Maciej Mroz: ttp330786 PRETEST: EDITOR: UDS: Changes of default values aren't apllied to breeak nodes for text type of variables Change 2034255 by Maciej Mroz: EDITOR: UDS: Changes of default values aren't apllied to make nodes for text type of variables ttp#330620 Change 2037682 by Maciej Mroz: ttp331309 BLOCKER: PRETEST: CRASH: EDITOR: Crash occurs when performing Diff Against Depot on any Blueprint Change 2033142 by Maciej Mroz: CreateDelegate Node uses internally FMemberReference. Refactor. Change 2032329 by Maciej Mroz: ttp330608 CRASH: PRETEST: EDITOR: UDS: Crash when trying to use struct named 'Color' in blueprint Change 2032420 by Maciej Mroz: ttp330620 PRETEST: EDITOR: UDS: Changes of default values aren't apllied to make nodes for text type of variables Change 2033139 by Maciej Mroz: Functions generated from CustomEvents can be also identified by GUID Change 2026631 by Maciej Mroz: BP. UDStruct: Invalid structs are handled better. Change 2025344 by Maciej Mroz: UDStruct enabled by default Change 2026672 by Maciej Mroz: EDITOR: BP: Can't easily remove 'pass-by-reference' pins on ReturnNodes Change 2026411 by Maciej Mroz: ExposeOnSpawn updated, it supports UDStructs, custom native Structs, and it throws compiler error. Change 2025342 by Maciej Mroz: GenerateBlueprintSkeleton moved from BLueprint::Serialize to RegenerateBlueprintClass, because SkeletonClass compilation requires all external dependencies to be loaded and linked. Change 2025570 by Steve Robb: Moved dependency processing to its own function. Change 2033235 by Steve Robb: String improvements Change 2035830 by Steve Robb: Workaround for FriendsAndChat crash in Fortnite. Change 2035115 by Steve Robb: UBT build time regression fixes. Change 2034162 by Steve Robb: 312775: UObject improvement: Ensure that *.generated.inl is included somewhere Change2034181by Steve Robb: Removal of any references to .generated.inl Change 2020165 by Steve Robb: BuildPublicAndPrivateUObjectHeaders factored out into its own function. Change 2020187 by Steve Robb: CreateModuleCompileEnvironment function factored out. Change 2020055 by Steve Robb: Refactoring of Unity.cs to remove complex and duplicate iteration. Change 2020083 by Steve Robb: Another use of dictionary utilities. Change 2031049 by Steve Robb: 312775: UObject improvement: Ensure that *.generated.inl is included somewhere Change 2025728 by Steve Robb: Refactored the application of a shared PCH file to multiple file into a single ApplySharedPCH function. Change 2020068 by Steve Robb: A couple of helpful utility functions for populating dictionaries. Change 2032307 by Steve Robb: 312775: UObject improvement: Ensure that *.generated.inl is included somewhere [CL 2054495 by Robert Manuszewski in Main branch]
308 lines
11 KiB
C++
308 lines
11 KiB
C++
// Copyright 1998-2014 Epic Games, Inc. All Rights Reserved.
|
|
|
|
#include "KismetCompilerPrivatePCH.h"
|
|
#include "UserDefinedStructureCompilerUtils.h"
|
|
#include "KismetCompiler.h"
|
|
#include "Editor/UnrealEd/Public/Kismet2/StructureEditorUtils.h"
|
|
#include "Editor/UnrealEd/Public/Kismet2/BlueprintEditorUtils.h"
|
|
|
|
#define LOCTEXT_NAMESPACE "StructureCompiler"
|
|
|
|
struct FUserDefinedStructureCompilerInner
|
|
{
|
|
static void ReplaceStructWithTempDuplicate(
|
|
UUserDefinedStruct* StructureToReinstance,
|
|
TSet<UBlueprint*>& BlueprintsToRecompile,
|
|
TArray<UUserDefinedStruct*>& ChangedStructs)
|
|
{
|
|
if (StructureToReinstance)
|
|
{
|
|
UUserDefinedStruct* DuplicatedStruct = NULL;
|
|
{
|
|
const FString ReinstancedName = FString::Printf(TEXT("STRUCT_REINST_%s"), *StructureToReinstance->GetName());
|
|
const FName UniqueName = MakeUniqueObjectName(GetTransientPackage(), UUserDefinedStruct::StaticClass(), FName(*ReinstancedName));
|
|
|
|
const bool OldIsDuplicatingClassForReinstancing = GIsDuplicatingClassForReinstancing;
|
|
GIsDuplicatingClassForReinstancing = true;
|
|
DuplicatedStruct = (UUserDefinedStruct*)StaticDuplicateObject(StructureToReinstance, GetTransientPackage(), *UniqueName.ToString(), ~RF_Transactional);
|
|
GIsDuplicatingClassForReinstancing = OldIsDuplicatingClassForReinstancing;
|
|
}
|
|
DuplicatedStruct->PrimaryStruct = StructureToReinstance;
|
|
DuplicatedStruct->Status = EUserDefinedStructureStatus::UDSS_Duplicate;
|
|
DuplicatedStruct->SetFlags(RF_Transient);
|
|
DuplicatedStruct->AddToRoot();
|
|
|
|
for (auto StructProperty : TObjectRange<UStructProperty>(RF_ClassDefaultObject | RF_PendingKill))
|
|
{
|
|
if (StructProperty && (StructureToReinstance == StructProperty->Struct))
|
|
{
|
|
if (auto OwnerClass = Cast<UBlueprintGeneratedClass>(StructProperty->GetOwnerClass()))
|
|
{
|
|
if (UBlueprint* FoundBlueprint = Cast<UBlueprint>(OwnerClass->ClassGeneratedBy))
|
|
{
|
|
BlueprintsToRecompile.Add(FoundBlueprint);
|
|
StructProperty->Struct = DuplicatedStruct;
|
|
}
|
|
}
|
|
else if (auto OwnerStruct = Cast<UUserDefinedStruct>(StructProperty->GetOwnerStruct()))
|
|
{
|
|
check(OwnerStruct != DuplicatedStruct);
|
|
const bool bValidStruct = (OwnerStruct->GetOutermost() != GetTransientPackage())
|
|
&& !OwnerStruct->HasAnyFlags(RF_PendingKill)
|
|
&& (EUserDefinedStructureStatus::UDSS_Duplicate != OwnerStruct->Status.GetValue());
|
|
|
|
if (bValidStruct)
|
|
{
|
|
ChangedStructs.AddUnique(OwnerStruct);
|
|
StructProperty->Struct = DuplicatedStruct;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
UE_LOG(LogK2Compiler, Error, TEXT("ReplaceStructWithTempDuplicate unknown owner"));
|
|
}
|
|
}
|
|
}
|
|
|
|
DuplicatedStruct->RemoveFromRoot();
|
|
}
|
|
}
|
|
|
|
static void CleanAndSanitizeStruct(UUserDefinedStruct* StructToClean)
|
|
{
|
|
check(StructToClean);
|
|
|
|
const FString TransientString = FString::Printf(TEXT("TRASHSTRUCT_%s"), *StructToClean->GetName());
|
|
const FName TransientName = MakeUniqueObjectName(GetTransientPackage(), UUserDefinedStruct::StaticClass(), FName(*TransientString));
|
|
UUserDefinedStruct* TransientStruct = NewNamedObject<UUserDefinedStruct>(GetTransientPackage(), TransientName, RF_Public|RF_Transient);
|
|
|
|
TArray<UObject*> SubObjects;
|
|
GetObjectsWithOuter(StructToClean, SubObjects, true);
|
|
SubObjects.Remove(StructToClean->EditorData);
|
|
for( auto SubObjIt = SubObjects.CreateIterator(); SubObjIt; ++SubObjIt )
|
|
{
|
|
UObject* CurrSubObj = *SubObjIt;
|
|
CurrSubObj->Rename(NULL, TransientStruct, REN_DontCreateRedirectors);
|
|
if( UProperty* Prop = Cast<UProperty>(CurrSubObj) )
|
|
{
|
|
FKismetCompilerUtilities::InvalidatePropertyExport(Prop);
|
|
}
|
|
else
|
|
{
|
|
ULinkerLoad::InvalidateExport(CurrSubObj);
|
|
}
|
|
}
|
|
|
|
StructToClean->SetSuperStruct(NULL);
|
|
StructToClean->Children = NULL;
|
|
StructToClean->Script.Empty();
|
|
StructToClean->MinAlignment = 0;
|
|
StructToClean->RefLink = NULL;
|
|
StructToClean->PropertyLink = NULL;
|
|
StructToClean->DestructorLink = NULL;
|
|
StructToClean->ScriptObjectReferences.Empty();
|
|
StructToClean->PropertyLink = NULL;
|
|
}
|
|
|
|
static void CreateVariables(UUserDefinedStruct* Struct, const class UEdGraphSchema_K2* Schema, FCompilerResultsLog& MessageLog)
|
|
{
|
|
check(Struct && Schema);
|
|
|
|
//FKismetCompilerUtilities::LinkAddedProperty push property to begin, so we revert the order
|
|
for (int32 VarDescIdx = FStructureEditorUtils::GetVarDesc(Struct).Num() - 1; VarDescIdx >= 0; --VarDescIdx)
|
|
{
|
|
FStructVariableDescription& VarDesc = FStructureEditorUtils::GetVarDesc(Struct)[VarDescIdx];
|
|
VarDesc.bInvalidMember = true;
|
|
|
|
FEdGraphPinType VarType = VarDesc.ToPinType();
|
|
|
|
FString ErrorMsg;
|
|
if(!FStructureEditorUtils::CanHaveAMemberVariableOfType(Struct, VarType, &ErrorMsg))
|
|
{
|
|
MessageLog.Error(*FString::Printf(*LOCTEXT("StructureGeneric_Error", "Structure: %s Error: %s").ToString(), *Struct->GetFullName(), *ErrorMsg));
|
|
continue;
|
|
}
|
|
|
|
UProperty* NewProperty = FKismetCompilerUtilities::CreatePropertyOnScope(Struct, VarDesc.VarName, VarType, NULL, 0, Schema, MessageLog);
|
|
if (NewProperty != NULL)
|
|
{
|
|
FKismetCompilerUtilities::LinkAddedProperty(Struct, NewProperty);
|
|
}
|
|
else
|
|
{
|
|
MessageLog.Error(*FString::Printf(*LOCTEXT("VariableInvalidType_Error", "The variable %s declared in %s has an invalid type %s").ToString(),
|
|
*VarDesc.VarName.ToString(), *Struct->GetName(), *UEdGraphSchema_K2::TypeToString(VarType)));
|
|
continue;
|
|
}
|
|
|
|
NewProperty->SetPropertyFlags(CPF_Edit);
|
|
NewProperty->SetMetaData(TEXT("FriendlyName"), *VarDesc.FriendlyName);
|
|
NewProperty->SetMetaData(TEXT("DisplayName"), *VarDesc.FriendlyName);
|
|
NewProperty->SetMetaData(TEXT("Category"), *VarDesc.Category);
|
|
NewProperty->RepNotifyFunc = NAME_None;
|
|
|
|
if (!VarDesc.DefaultValue.IsEmpty())
|
|
{
|
|
NewProperty->SetMetaData(TEXT("MakeStructureDefaultValue"), *VarDesc.DefaultValue);
|
|
}
|
|
VarDesc.CurrentDefaultValue = VarDesc.DefaultValue;
|
|
|
|
VarDesc.bInvalidMember = false;
|
|
}
|
|
}
|
|
|
|
static void InnerCompileStruct(UUserDefinedStruct* Struct, const class UEdGraphSchema_K2* K2Schema, class FCompilerResultsLog& MessageLog)
|
|
{
|
|
check(Struct);
|
|
const int32 ErrorNum = MessageLog.NumErrors;
|
|
|
|
CreateVariables(Struct, K2Schema, MessageLog);
|
|
|
|
Struct->Bind();
|
|
Struct->StaticLink(true);
|
|
|
|
if (Struct->GetStructureSize() <= 0)
|
|
{
|
|
MessageLog.Error(*FString::Printf(*LOCTEXT("StructurEmpty_Error", "Structure '%s' is empty ").ToString(), *Struct->GetFullName()));
|
|
}
|
|
|
|
const bool bNoErrorsDuringCompilation = (ErrorNum == MessageLog.NumErrors);
|
|
Struct->Status = bNoErrorsDuringCompilation ? EUserDefinedStructureStatus::UDSS_UpToDate : EUserDefinedStructureStatus::UDSS_Error;
|
|
}
|
|
|
|
static bool ShouldBeCompiled(const UUserDefinedStruct* Struct)
|
|
{
|
|
if (Struct && (EUserDefinedStructureStatus::UDSS_UpToDate == Struct->Status))
|
|
{
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
static void BuildDependencyMapAndCompile(TArray<UUserDefinedStruct*>& ChangedStructs, FCompilerResultsLog& MessageLog)
|
|
{
|
|
struct FDependencyMapEntry
|
|
{
|
|
UUserDefinedStruct* Struct;
|
|
TSet<UUserDefinedStruct*> StructuresToWaitFor;
|
|
|
|
FDependencyMapEntry() : Struct(NULL) {}
|
|
|
|
void Initialize(UUserDefinedStruct* ChangedStruct, TArray<UUserDefinedStruct*>& AllChangedStructs)
|
|
{
|
|
Struct = ChangedStruct;
|
|
check(Struct);
|
|
|
|
auto Schema = GetDefault<UEdGraphSchema_K2>();
|
|
for (auto& VarDesc : FStructureEditorUtils::GetVarDesc(Struct))
|
|
{
|
|
auto StructType = Cast<UUserDefinedStruct>(VarDesc.SubCategoryObject.Get());
|
|
if (StructType && (VarDesc.Category == Schema->PC_Struct) && AllChangedStructs.Contains(StructType))
|
|
{
|
|
StructuresToWaitFor.Add(StructType);
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
TArray<FDependencyMapEntry> DependencyMap;
|
|
for (auto Iter = ChangedStructs.CreateIterator(); Iter; ++Iter)
|
|
{
|
|
DependencyMap.Add(FDependencyMapEntry());
|
|
DependencyMap.Last().Initialize(*Iter, ChangedStructs);
|
|
}
|
|
|
|
while (DependencyMap.Num())
|
|
{
|
|
int32 StructureToCompileIndex = INDEX_NONE;
|
|
for (int32 EntryIndex = 0; EntryIndex < DependencyMap.Num(); ++EntryIndex)
|
|
{
|
|
if(0 == DependencyMap[EntryIndex].StructuresToWaitFor.Num())
|
|
{
|
|
StructureToCompileIndex = EntryIndex;
|
|
break;
|
|
}
|
|
}
|
|
check(INDEX_NONE != StructureToCompileIndex);
|
|
UUserDefinedStruct* Struct = DependencyMap[StructureToCompileIndex].Struct;
|
|
check(Struct);
|
|
|
|
FUserDefinedStructureCompilerInner::CleanAndSanitizeStruct(Struct);
|
|
FUserDefinedStructureCompilerInner::InnerCompileStruct(Struct, GetDefault<UEdGraphSchema_K2>(), MessageLog);
|
|
|
|
DependencyMap.RemoveAtSwap(StructureToCompileIndex);
|
|
|
|
for (auto EntryIter = DependencyMap.CreateIterator(); EntryIter; ++EntryIter)
|
|
{
|
|
(*EntryIter).StructuresToWaitFor.Remove(Struct);
|
|
}
|
|
}
|
|
}
|
|
};
|
|
|
|
void FUserDefinedStructureCompilerUtils::CompileStruct(class UUserDefinedStruct* Struct, class FCompilerResultsLog& MessageLog, bool bForceRecompile)
|
|
{
|
|
if (FStructureEditorUtils::UserDefinedStructEnabled() && Struct)
|
|
{
|
|
TSet<UBlueprint*> BlueprintsToRecompile;
|
|
TArray<UUserDefinedStruct*> ChangedStructs;
|
|
|
|
if (FUserDefinedStructureCompilerInner::ShouldBeCompiled(Struct) || bForceRecompile)
|
|
{
|
|
ChangedStructs.Add(Struct);
|
|
}
|
|
|
|
for (int32 StructIdx = 0; StructIdx < ChangedStructs.Num(); ++StructIdx)
|
|
{
|
|
FUserDefinedStructureCompilerInner::ReplaceStructWithTempDuplicate(ChangedStructs[StructIdx], BlueprintsToRecompile, ChangedStructs);
|
|
ChangedStructs[StructIdx]->Status = EUserDefinedStructureStatus::UDSS_Dirty;
|
|
}
|
|
|
|
// COMPILE IN PROPER ORDER
|
|
FUserDefinedStructureCompilerInner::BuildDependencyMapAndCompile(ChangedStructs, MessageLog);
|
|
|
|
// UPDATE ALL THINGS DEPENDENT ON COMPILED STRUCTURES
|
|
for (TObjectIterator<UK2Node_StructOperation> It(RF_Transient | RF_PendingKill | RF_ClassDefaultObject, true); It && ChangedStructs.Num(); ++It)
|
|
{
|
|
UK2Node_StructOperation* Node = *It;
|
|
if (Node && !Node->HasAnyFlags(RF_Transient|RF_PendingKill))
|
|
{
|
|
UUserDefinedStruct* StructInNode = Cast<UUserDefinedStruct>(Node->StructType);
|
|
if (StructInNode && ChangedStructs.Contains(StructInNode))
|
|
{
|
|
if (UBlueprint* FoundBlueprint = Node->GetBlueprint())
|
|
{
|
|
Node->ReconstructNode();
|
|
BlueprintsToRecompile.Add(FoundBlueprint);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
for (auto BPIter = BlueprintsToRecompile.CreateIterator(); BPIter; ++BPIter)
|
|
{
|
|
FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified(*BPIter);
|
|
}
|
|
}
|
|
}
|
|
|
|
void FUserDefinedStructureCompilerUtils::DefaultUserDefinedStructs(UObject* Object, FCompilerResultsLog& MessageLog)
|
|
{
|
|
if (Object && FStructureEditorUtils::UserDefinedStructEnabled())
|
|
{
|
|
for (TFieldIterator<UProperty> It(Object->GetClass()); It; ++It)
|
|
{
|
|
if (const UProperty* Property = (*It))
|
|
{
|
|
uint8* Mem = Property->ContainerPtrToValuePtr<uint8>(Object);
|
|
if (!FStructureEditorUtils::Fill_MakeStructureDefaultValue(Property, Mem))
|
|
{
|
|
MessageLog.Warning(*FString::Printf(*LOCTEXT("MakeStructureDefaultValue_Error", "MakeStructureDefaultValue parsing error. Object: %s, Property: %s").ToString(),
|
|
*Object->GetName(), *Property->GetName()));
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
#undef LOCTEXT_NAMESPACE |