You've already forked UnrealEngineUWP
mirror of
https://github.com/izzy2lost/UnrealEngineUWP.git
synced 2026-03-26 18:15:20 -07:00
bee76532da
#rb Sebastian.Nordgren #rnx #jira UE-151464 #preflight 627a4c60fc07e0a9b4eefda9 ### No files - When submitting a change list with no workspace files (either empty changelist or only shelved files) our internal C# api does not return any errors. - To get around this for now ::FindPackagesInChangelist can be changed to return null if we detect that there are no files to submit. - I am following up with the original author to try and find out if the submit behavior in our API is intended or not. ### Shelved files - Attempting to submit a valid changelist that has shelved files will eventually fail when we try to finally submit the changelist. - This means that the tool will check all of the packages for virtualization first, before eventually failing on the submit. - Most users will alt tab out of p4v during the submit and we cannot do anything fancy with the error reporting (like make the task bar icon flash etc) so might not notice that the submit failed for some time. - So it makes sense for us to check for shelved files, before we kick off the virtualization process and if the changelist does have shelved files we can error out and the user should see it before they alt tab away. [CL 20120836 by paul chipchase in ue5-main branch]