You've already forked UnrealEngineUWP
mirror of
https://github.com/izzy2lost/UnrealEngineUWP.git
synced 2026-03-26 18:15:20 -07:00
* Doing so exposed an ambiguity in GetTypeHash(FLinearColor) because previously it was relying on an implicit conversion to FColor. Once an overload for FVector4 was provided, it became ambiguous because there is ALSO an implicit conversion to FVector4! * Resolved this by implementing GetTypeHash(FLinearColor) directly instead of relying on implicit conversion to FColor. * This exposed a situation where SDataGraph inlined a local definition of GetTypehash(FLinearColor), and was now in conflict with the real, global one. * This was a nono in the first place because depending on how UBT decided to combine cpp files, this could CHANGE THE MEANING of GetTypeHash(FLinearColor)!!! * Turns out that the function was completely unused in that file anyway, so never needed to be added in the first place.Thus, I removed it. * Arguably, the implementation in SDataGraph is better, but I left the old way so as not to change the meaning of any existing serialized hashes of colors that might be in data files. #codereview:rob.manuszewski,Jaroslaw.Surowiec [CL 2302959 by Wes Hunt in Main branch]