Nick Darnell d287c6143f More Gamma Correction - Didn't catch this on the previous pass, apparently there was an implicit constructor allowing FLinearColor to FColor that was doing pow(2.2) gamma conversion inversion. Rather than leave the implicit constructor, I'm making it private and making people use ToFColor(true). Which is slightly more expensive, but performs the proper sRGB conversion. While fixing this, I found several terrible uses of the implicit constructor, when Hashing FLinearColors we were converting them to FColors first, when clearing FCanvas we were manually gamma correcting but leaving it as an FLinearColor, then implicitly converting to FColor, double gamma corrrecting. Neither of which should even be required as the RHI Clear command expects an FLinearColor. Additionally fixing a myriad of Slate widgets that were all doing FColor conversions needlessly only to convert back to FLinearColor when queuing slate draw commands. ...

#codereview nick.penwarden, martin.mittring, andrew.brown, gareth.martin

[CL 2593605 by Nick Darnell in Main branch]

2015-06-19 11:17:11 -04:00

..

LogVisualizer.cpp

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

LogVisualizer.h

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

LogVisualizerModule.cpp

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

LogVisualizerSessionSettings.cpp

…

LogVisualizerSettings.cpp

Added new shapes to log with Visual Logger: mesh, convex polygon, navarea / extruded convex and navoctree dump from given bounding box.

2015-05-20 05:30:24 -04:00

LogVisualizerStyle.cpp

Added more debug data about EQS to Visual Logs

2015-06-10 03:23:45 -04:00

LogVisualizerStyle.h

…

SFilterCheckBox.h

…

SFilterWidget.cpp

…

SFilterWidget.h

…

SSequencerSectionOverlay.cpp

…

SSequencerSectionOverlay.h

…

STimeline.cpp

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

STimeline.h

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

STimelineBar.cpp

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

STimelineBar.h

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

STimelinesContainer.cpp

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

STimelinesContainer.h

Clang warning fixes: Fixed missing 'override' specifiers

2015-04-01 07:20:55 -04:00

STimeSlider.cpp

…

STimeSlider.h

…

SVisualLogger.cpp

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

SVisualLogger.h

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

SVisualLoggerFilters.cpp

Added more debug data about EQS to Visual Logs

2015-06-10 03:23:45 -04:00

SVisualLoggerFilters.h

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

SVisualLoggerLogsList.cpp

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

SVisualLoggerLogsList.h

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

SVisualLoggerReport.cpp

…

SVisualLoggerReport.h

…

SVisualLoggerStatusView.cpp

Fixed status view categories in Visual Logger tool.

2015-06-10 11:02:43 -04:00

SVisualLoggerStatusView.h

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

SVisualLoggerToolbar.cpp

Added "Save All" button to Visual Logger.

2015-05-27 09:20:05 -04:00

SVisualLoggerToolbar.h

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

SVisualLoggerView.cpp

Sequencer improvements:

2015-06-12 08:55:27 -04:00

SVisualLoggerView.h

Bunch of fixes to have better control over Visual Logger tool with keyboard.

2015-06-11 09:51:31 -04:00

TimeSliderController.cpp

More Gamma Correction - Didn't catch this on the previous pass, apparently there was an implicit constructor allowing FLinearColor to FColor that was doing pow(2.2) gamma conversion inversion. Rather than leave the implicit constructor, I'm making it private and making people use ToFColor(true). Which is slightly more expensive, but performs the proper sRGB conversion. While fixing this, I found several terrible uses of the implicit constructor, when Hashing FLinearColors we were converting them to FColors first, when clearing FCanvas we were manually gamma correcting but leaving it as an FLinearColor, then implicitly converting to FColor, double gamma corrrecting. Neither of which should even be required as the RHI Clear command expects an FLinearColor. Additionally fixing a myriad of Slate widgets that were all doing FColor conversions needlessly only to convert back to FLinearColor when queuing slate draw commands.

2015-06-19 11:17:11 -04:00

TimeSliderController.h

Different optimizations to drawing histogram data from Visual Logger.

2015-05-20 10:04:17 -04:00

VisualLoggerCameraController.cpp

…

VisualLoggerCameraController.h

Back out changelist 2481333

2015-03-17 05:38:32 -04:00

VisualLoggerCanvasRenderer.cpp

Different optimizations to drawing histogram data from Visual Logger.

2015-05-20 10:04:17 -04:00

VisualLoggerCanvasRenderer.h

Different optimizations to drawing histogram data from Visual Logger.

2015-05-20 10:04:17 -04:00

VisualLoggerCommands.h

Added "Save All" button to Visual Logger.

2015-05-27 09:20:05 -04:00

VisualLoggerHUD.cpp

…

VisualLoggerHUD.h

Back out changelist 2481333

2015-03-17 05:38:32 -04:00

VisualLoggerRenderingActor.cpp

Added multiple logs selection to Visual Logger tool. It should partially fill UE-16336 task.

2015-06-02 06:51:31 -04:00

VisualLoggerRenderingActor.h

Added multiple logs selection to Visual Logger tool. It should partially fill UE-16336 task.

2015-06-02 06:51:31 -04:00

VisualLoggerRenderingComponent.h

Back out changelist 2481333

2015-03-17 05:38:32 -04:00