Files
UnrealEngineUWP/Engine/Source/Editor/EditorConfig/Private/EditorMetadataOverrides.cpp
robert manuszewski d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00

796 lines
17 KiB
C++

// Copyright Epic Games, Inc. All Rights Reserved.
#include "EditorMetadataOverrides.h"
#include "Editor.h"
#include "EditorConfigSubsystem.h"
#include "Misc/StringBuilder.h"
#include "UObject/UnrealType.h"
UEditorMetadataOverrides::UEditorMetadataOverrides()
{
}
void UEditorMetadataOverrides::Initialize(FSubsystemCollectionBase& Collection)
{
UEditorConfigSubsystem* EditorConfig = Collection.InitializeDependency<UEditorConfigSubsystem>();
TSharedPtr<FEditorConfig> MetadataOverrideConfig = EditorConfig->FindOrLoadConfig(TEXT("MetadataOverrides"));
LoadFromConfig(MetadataOverrideConfig);
}
bool UEditorMetadataOverrides::LoadFromConfig(TSharedPtr<FEditorConfig> Config)
{
SourceConfig = Config;
LoadedMetadata.Classes.Reset();
if (!SourceConfig.IsValid())
{
return false;
}
return SourceConfig->TryGetStruct(TEXT("Metadata"), LoadedMetadata, FEditorConfig::EPropertyFilter::All);
}
void UEditorMetadataOverrides::Save()
{
if (!SourceConfig.IsValid())
{
return;
}
SourceConfig->SetStruct(TEXT("Metadata"), LoadedMetadata, FEditorConfig::EPropertyFilter::All);
UEditorConfigSubsystem* EditorConfigSubsystem = GEditor->GetEditorSubsystem<UEditorConfigSubsystem>();
if (EditorConfigSubsystem == nullptr)
{
return;
}
EditorConfigSubsystem->SaveConfig(SourceConfig.ToSharedRef());
}
const FMetadataSet* UEditorMetadataOverrides::FindFieldMetadata(const FField* Field) const
{
check(Field != nullptr);
if (!SourceConfig.IsValid())
{
return nullptr;
}
const UStruct* OwnerStruct = Field->GetOwnerStruct();
if (OwnerStruct == nullptr)
{
return nullptr;
}
const FStructMetadata* StructMetadata = LoadedMetadata.Classes.Find(OwnerStruct->GetFName());
if (StructMetadata == nullptr)
{
return nullptr;
}
const FMetadataSet* FieldMetadata = StructMetadata->Fields.Find(Field->GetFName());
return FieldMetadata;
}
FMetadataSet* UEditorMetadataOverrides::FindFieldMetadata(const FField* Field)
{
check(Field != nullptr);
if (!SourceConfig.IsValid())
{
return nullptr;
}
const UStruct* OwnerStruct = Field->GetOwnerStruct();
if (OwnerStruct == nullptr)
{
return nullptr;
}
FStructMetadata* StructMetadata = LoadedMetadata.Classes.Find(OwnerStruct->GetFName());
if (StructMetadata == nullptr)
{
return nullptr;
}
FMetadataSet* FieldMetadata = StructMetadata->Fields.Find(Field->GetFName());
return FieldMetadata;
}
FMetadataSet* UEditorMetadataOverrides::FindOrAddFieldMetadata(const FField* Field)
{
check(Field != nullptr);
if (!SourceConfig.IsValid())
{
return nullptr;
}
const UStruct* OwnerStruct = Field->GetOwnerStruct();
if (OwnerStruct == nullptr)
{
return nullptr;
}
FStructMetadata& StructMetadata = LoadedMetadata.Classes.FindOrAdd(OwnerStruct->GetFName());
FMetadataSet& FieldMetadata = StructMetadata.Fields.FindOrAdd(Field->GetFName());
return &FieldMetadata;
}
EMetadataType UEditorMetadataOverrides::GetMetadataType(const FField* Field, FName Key) const
{
check(Field != nullptr);
const FMetadataSet* MetadataSet = FindFieldMetadata(Field);
if (MetadataSet == nullptr)
{
return EMetadataType::None;
}
if (MetadataSet->Bools.Contains(Key))
{
return EMetadataType::Bool;
}
if (MetadataSet->Ints.Contains(Key))
{
return EMetadataType::Int;
}
if (MetadataSet->Floats.Contains(Key))
{
return EMetadataType::Float;
}
if (MetadataSet->Strings.Contains(Key))
{
return EMetadataType::String;
}
return EMetadataType::None;
}
EMetadataType UEditorMetadataOverrides::GetMetadataType(const UStruct* Struct, FName Key) const
{
check(Struct != nullptr);
const FMetadataSet* MetadataSet = FindStructMetadata(Struct);
if (MetadataSet == nullptr)
{
return EMetadataType::None;
}
if (MetadataSet->Bools.Contains(Key))
{
return EMetadataType::Bool;
}
if (MetadataSet->Ints.Contains(Key))
{
return EMetadataType::Int;
}
if (MetadataSet->Floats.Contains(Key))
{
return EMetadataType::Float;
}
if (MetadataSet->Strings.Contains(Key))
{
return EMetadataType::String;
}
return EMetadataType::None;
}
bool UEditorMetadataOverrides::GetStringMetadata(const FField* Field, FName Key, FString& OutValue) const
{
const FMetadataSet* FieldMetadata = FindFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return false;
}
const FString* MetaValue = FieldMetadata->Strings.Find(Key);
if (MetaValue == nullptr)
{
if (!Field->HasMetaData(Key))
{
return false;
}
OutValue = Field->GetMetaData(Key);
return true;
}
OutValue = *MetaValue;
return true;
}
void UEditorMetadataOverrides::SetStringMetadata(const FField* Field, FName Key, FStringView Value)
{
FMetadataSet* FieldMetadata = FindOrAddFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return;
}
FieldMetadata->Strings.Add(Key, FString(Value));
}
bool UEditorMetadataOverrides::GetFloatMetadata(const FField* Field, FName Key, float& OutValue) const
{
const FMetadataSet* FieldMetadata = FindFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return false;
}
const float* MetaValue = FieldMetadata->Floats.Find(Key);
if (MetaValue == nullptr)
{
if (!Field->HasMetaData(Key))
{
return false;
}
OutValue = Field->GetFloatMetaData(Key);
return true;
}
OutValue = *MetaValue;
return true;
}
void UEditorMetadataOverrides::SetFloatMetadata(const FField* Field, FName Key, float Value)
{
FMetadataSet* FieldMetadata = FindOrAddFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return;
}
FieldMetadata->Floats.Add(Key, Value);
Save();
}
bool UEditorMetadataOverrides::GetIntMetadata(const FField* Field, FName Key, int32& OutValue) const
{
const FMetadataSet* FieldMetadata = FindFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return false;
}
const int32* MetaValue = FieldMetadata->Ints.Find(Key);
if (MetaValue == nullptr)
{
if (!Field->HasMetaData(Key))
{
return false;
}
OutValue = Field->GetIntMetaData(Key);
return true;
}
OutValue = *MetaValue;
return true;
}
void UEditorMetadataOverrides::SetIntMetadata(const FField* Field, FName Key, int32 Value)
{
FMetadataSet* FieldMetadata = FindOrAddFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return;
}
FieldMetadata->Ints.Add(Key, Value);
Save();
}
bool UEditorMetadataOverrides::GetBoolMetadata(const FField* Field, FName Key, bool& OutValue) const
{
const FMetadataSet* FieldMetadata = FindFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return false;
}
const bool* MetaValue = FieldMetadata->Bools.Find(Key);
if (MetaValue == nullptr)
{
if (!Field->HasMetaData(Key))
{
return false;
}
OutValue = Field->GetBoolMetaData(Key);
return true;
}
OutValue = *MetaValue;
return true;
}
void UEditorMetadataOverrides::SetBoolMetadata(const FField* Field, FName Key, bool Value)
{
FMetadataSet* FieldMetadata = FindOrAddFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return;
}
FieldMetadata->Bools.Add(Key, Value);
Save();
}
bool UEditorMetadataOverrides::GetClassMetadata(const FField* Field, FName Key, UClass*& OutValue) const
{
FString ClassName;
if (!GetStringMetadata(Field, Key, ClassName))
{
return false;
}
OutValue = UClass::TryFindTypeSlow<UClass>(ClassName);
return true; // we return true here even if the value is null because we did have a value, it just wasn't a valid class name
}
void UEditorMetadataOverrides::SetClassMetadata(const FField* Field, FName Key, UClass* Value)
{
FString ClassName;
if (Value != nullptr)
{
ClassName = Value->GetName();
}
SetStringMetadata(Field, Key, ClassName);
Save();
}
bool UEditorMetadataOverrides::GetArrayMetadata(const FField* Field, FName Key, TArray<FString>& OutValue) const
{
const FMetadataSet* FieldMetadata = FindFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return false;
}
const FString* MetaValue = FieldMetadata->Strings.Find(Key);
if (MetaValue != nullptr)
{
MetaValue->ParseIntoArray(OutValue, TEXT(","));
return true;
}
// fallback to metadata system
if (!Field->HasMetaData(Key))
{
return false;
}
const FString ArrayString = Field->GetMetaData(Key);
ArrayString.ParseIntoArray(OutValue, TEXT(","));
return true;
}
void UEditorMetadataOverrides::SetArrayMetadata(const FField* Field, FName Key, const TArray<FString>& Value)
{
FMetadataSet* FieldMetadata = FindOrAddFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return;
}
const FString ValueString = FString::Join(Value, TEXT(","));
FieldMetadata->Strings.Add(Key, ValueString);
Save();
}
void UEditorMetadataOverrides::AddToArrayMetadata(const FField* Field, FName Key, const FString& Value)
{
FMetadataSet* FieldMetadata = FindOrAddFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return;
}
FString& CurrentValue = FieldMetadata->Strings.FindOrAdd(Key);
if (CurrentValue.IsEmpty())
{
CurrentValue = Value;
}
else
{
CurrentValue.Append(TEXT(","));
CurrentValue.Append(Value);
}
Save();
}
void UEditorMetadataOverrides::RemoveFromArrayMetadata(const FField* Field, FName Key, const FString& Value)
{
FMetadataSet* FieldMetadata = FindFieldMetadata(Field);
if (FieldMetadata == nullptr)
{
return;
}
FString* CurrentValue = FieldMetadata->Strings.Find(Key);
if (CurrentValue == nullptr)
{
return;
}
TArray<FString> ArrayValue;
CurrentValue->ParseIntoArray(ArrayValue, TEXT(","));
ArrayValue.Remove(Value);
if (ArrayValue.IsEmpty())
{
FieldMetadata->Strings.Remove(Key);
}
else
{
const FString ValueString = FString::Join(ArrayValue, TEXT(","));
FieldMetadata->Strings.Add(Key, ValueString);
}
Save();
}
void UEditorMetadataOverrides::RemoveMetadata(const FField* Field, FName Key)
{
if (!SourceConfig.IsValid())
{
return;
}
const UStruct* OwnerStruct = Field->GetOwnerStruct();
if (OwnerStruct == nullptr)
{
return;
}
FStructMetadata* StructMetadata = LoadedMetadata.Classes.Find(OwnerStruct->GetFName());
if (StructMetadata == nullptr)
{
return;
}
FMetadataSet* FieldMetadata = StructMetadata->Fields.Find(Field->GetFName());
if (FieldMetadata == nullptr)
{
return;
}
FieldMetadata->Ints.Remove(Key);
FieldMetadata->Bools.Remove(Key);
FieldMetadata->Floats.Remove(Key);
FieldMetadata->Strings.Remove(Key);
Save();
}
const FMetadataSet* UEditorMetadataOverrides::FindStructMetadata(const UStruct* Struct) const
{
check(Struct != nullptr);
if (!SourceConfig.IsValid())
{
return nullptr;
}
const FStructMetadata* StructMetadata = LoadedMetadata.Classes.Find(Struct->GetFName());
return StructMetadata != nullptr ? &StructMetadata->StructMetadata : nullptr;
}
FMetadataSet* UEditorMetadataOverrides::FindStructMetadata(const UStruct* Struct)
{
check(Struct != nullptr);
if (!SourceConfig.IsValid())
{
return nullptr;
}
FStructMetadata* StructMetadata = LoadedMetadata.Classes.Find(Struct->GetFName());
return StructMetadata != nullptr ? &StructMetadata->StructMetadata : nullptr;
}
FMetadataSet* UEditorMetadataOverrides::FindOrAddStructMetadata(const UStruct* Struct)
{
check(Struct != nullptr);
if (!SourceConfig.IsValid())
{
return nullptr;
}
FStructMetadata& StructMetadata = LoadedMetadata.Classes.FindOrAdd(Struct->GetFName());
return &StructMetadata.StructMetadata;
}
bool UEditorMetadataOverrides::GetStringMetadata(const UStruct* Struct, FName Key, FString& OutValue) const
{
const FMetadataSet* StructMetadata = FindStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return false;
}
const FString* MetaValue = StructMetadata->Strings.Find(Key);
if (MetaValue == nullptr)
{
if (!Struct->HasMetaData(Key))
{
return false;
}
OutValue = Struct->GetMetaData(Key);
return true;
}
OutValue = *MetaValue;
return true;
}
void UEditorMetadataOverrides::SetStringMetadata(const UStruct* Struct, FName Key, FStringView Value)
{
FMetadataSet* StructMetadata = FindOrAddStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return;
}
StructMetadata->Strings.Add(Key, FString(Value));
Save();
}
bool UEditorMetadataOverrides::GetFloatMetadata(const UStruct* Struct, FName Key, float& OutValue) const
{
const FMetadataSet* StructMetadata = FindStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return false;
}
const float* MetaValue = StructMetadata->Floats.Find(Key);
if (MetaValue == nullptr)
{
if (!Struct->HasMetaData(Key))
{
return false;
}
OutValue = Struct->GetFloatMetaData(Key);
return true;
}
OutValue = *MetaValue;
return true;
}
void UEditorMetadataOverrides::SetFloatMetadata(const UStruct* Struct, FName Key, float Value)
{
FMetadataSet* StructMetadata = FindOrAddStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return;
}
StructMetadata->Floats.Add(Key, Value);
Save();
}
bool UEditorMetadataOverrides::GetIntMetadata(const UStruct* Struct, FName Key, int32& OutValue) const
{
const FMetadataSet* StructMetadata = FindStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return false;
}
const int32* MetaValue = StructMetadata->Ints.Find(Key);
if (MetaValue == nullptr)
{
if (!Struct->HasMetaData(Key))
{
return false;
}
OutValue = Struct->GetIntMetaData(Key);
return true;
}
OutValue = *MetaValue;
return true;
}
void UEditorMetadataOverrides::SetIntMetadata(const UStruct* Struct, FName Key, int32 Value)
{
FMetadataSet* StructMetadata = FindOrAddStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return;
}
StructMetadata->Ints.Add(Key, Value);
Save();
}
bool UEditorMetadataOverrides::GetBoolMetadata(const UStruct* Struct, FName Key, bool& OutValue) const
{
const FMetadataSet* StructMetadata = FindStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return false;
}
const bool* MetaValue = StructMetadata->Bools.Find(Key);
if (MetaValue == nullptr)
{
if (!Struct->HasMetaData(Key))
{
return false;
}
OutValue = Struct->GetBoolMetaData(Key);
return true;
}
OutValue = *MetaValue;
return true;
}
void UEditorMetadataOverrides::SetBoolMetadata(const UStruct* Struct, FName Key, bool Value)
{
FMetadataSet* StructMetadata = FindOrAddStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return;
}
StructMetadata->Bools.Add(Key, Value);
Save();
}
bool UEditorMetadataOverrides::GetClassMetadata(const UStruct* Struct, FName Key, UClass*& OutValue) const
{
FString ClassName;
if (!GetStringMetadata(Struct, Key, ClassName))
{
return false;
}
OutValue = UClass::TryFindTypeSlow<UClass>(ClassName);
return true; // we return true here even if the class is null because we did have a value, it just wasn't a valid class name
}
void UEditorMetadataOverrides::SetClassMetadata(const UStruct* Struct, FName Key, UClass* Value)
{
FString ClassName;
if (Value != nullptr)
{
ClassName = Value->GetName();
}
SetStringMetadata(Struct, Key, ClassName);
Save();
}
bool UEditorMetadataOverrides::GetArrayMetadata(const UStruct* Struct, FName Key, TArray<FString>& OutValue) const
{
const FMetadataSet* StructMetadata = FindStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return false;
}
const FString* MetaValue = StructMetadata->Strings.Find(Key);
if (MetaValue != nullptr)
{
MetaValue->ParseIntoArray(OutValue, TEXT(","));
return true;
}
if (!Struct->HasMetaData(Key))
{
return false;
}
const FString ArrayString = Struct->GetMetaData(Key);
ArrayString.ParseIntoArray(OutValue, TEXT(","));
return true;
}
void UEditorMetadataOverrides::SetArrayMetadata(const UStruct* Struct, FName Key, const TArray<FString>& Value)
{
FMetadataSet* StructMetadata = FindOrAddStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return;
}
const FString ValueString = FString::Join(Value, TEXT(","));
StructMetadata->Strings.Add(Key, ValueString);
Save();
}
void UEditorMetadataOverrides::AddToArrayMetadata(const UStruct* Struct, FName Key, const FString& Value)
{
FMetadataSet* StructMetadata = FindOrAddStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return;
}
FString& CurrentValue = StructMetadata->Strings.FindOrAdd(Key);
if (CurrentValue.IsEmpty())
{
CurrentValue = Value;
}
else
{
CurrentValue.Append(TEXT(","));
CurrentValue.Append(Value);
}
Save();
}
void UEditorMetadataOverrides::RemoveFromArrayMetadata(const UStruct* Struct, FName Key, const FString& Value)
{
FMetadataSet* StructMetadata = FindStructMetadata(Struct);
if (StructMetadata == nullptr)
{
return;
}
FString* CurrentValue = StructMetadata->Strings.Find(Key);
if (CurrentValue == nullptr)
{
return;
}
TArray<FString> ArrayValue;
CurrentValue->ParseIntoArray(ArrayValue, TEXT(","));
ArrayValue.Remove(Value);
if (ArrayValue.IsEmpty())
{
StructMetadata->Strings.Remove(Key);
}
else
{
const FString ValueString = FString::Join(ArrayValue, TEXT(","));
StructMetadata->Strings.Add(Key, ValueString);
}
Save();
}
void UEditorMetadataOverrides::RemoveMetadata(const UStruct* Struct, FName Key)
{
if (!SourceConfig.IsValid())
{
return;
}
FStructMetadata* StructMetadata = LoadedMetadata.Classes.Find(Struct->GetFName());
if (StructMetadata == nullptr)
{
return;
}
StructMetadata->StructMetadata.Ints.Remove(Key);
StructMetadata->StructMetadata.Bools.Remove(Key);
StructMetadata->StructMetadata.Floats.Remove(Key);
StructMetadata->StructMetadata.Strings.Remove(Key);
Save();
}