Files
UnrealEngineUWP/Engine/Source/Editor/DetailCustomizations/Private/DataTableCustomization.cpp
robert manuszewski d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00

216 lines
6.9 KiB
C++

// Copyright Epic Games, Inc. All Rights Reserved.
#include "DataTableCustomization.h"
#include "DataTableEditorUtils.h"
#include "Editor.h"
#include "Widgets/SWidget.h"
#include "Widgets/Text/STextBlock.h"
#include "PropertyCustomizationHelpers.h"
#include "Framework/Application/SlateApplication.h"
#include "Framework/MultiBox/MultiBoxBuilder.h"
#define LOCTEXT_NAMESPACE "FDataTableCustomizationLayout"
void FDataTableCustomizationLayout::CustomizeHeader(TSharedRef<class IPropertyHandle> InStructPropertyHandle, class FDetailWidgetRow& HeaderRow, IPropertyTypeCustomizationUtils& StructCustomizationUtils)
{
this->StructPropertyHandle = InStructPropertyHandle;
if (StructPropertyHandle->HasMetaData(TEXT("RowType")))
{
const FString& RowType = StructPropertyHandle->GetMetaData(TEXT("RowType"));
RowTypeFilter = FName(*RowType);
RowFilterStruct = UClass::TryFindTypeSlow<UScriptStruct>(RowType);
}
FSimpleDelegate OnDataTableChangedDelegate = FSimpleDelegate::CreateSP(this, &FDataTableCustomizationLayout::OnDataTableChanged);
StructPropertyHandle->SetOnPropertyValueChanged(OnDataTableChangedDelegate);
HeaderRow
.NameContent()
[
InStructPropertyHandle->CreatePropertyNameWidget()
];
FDataTableEditorUtils::AddSearchForReferencesContextMenu(HeaderRow, FExecuteAction::CreateSP(this, &FDataTableCustomizationLayout::OnSearchForReferences));
}
void FDataTableCustomizationLayout::CustomizeChildren(TSharedRef<class IPropertyHandle> InStructPropertyHandle, class IDetailChildrenBuilder& StructBuilder, IPropertyTypeCustomizationUtils& StructCustomizationUtils)
{
/** Get all the existing property handles */
DataTablePropertyHandle = InStructPropertyHandle->GetChildHandle("DataTable");
RowNamePropertyHandle = InStructPropertyHandle->GetChildHandle("RowName");
if (DataTablePropertyHandle->IsValidHandle() && RowNamePropertyHandle->IsValidHandle())
{
/** Setup Change callback */
FSimpleDelegate OnDataTableChangedDelegate = FSimpleDelegate::CreateSP(this, &FDataTableCustomizationLayout::OnDataTableChanged);
DataTablePropertyHandle->SetOnPropertyValueChanged(OnDataTableChangedDelegate);
/** Construct a asset picker widget with a custom filter */
StructBuilder.AddCustomRow(LOCTEXT("DataTable_TableName", "Data Table"))
.NameContent()
[
SNew(STextBlock)
.Text(LOCTEXT("DataTable_TableName", "Data Table"))
.Font(StructCustomizationUtils.GetRegularFont())
]
.ValueContent()
.MaxDesiredWidth(0.0f) // don't constrain the combo button width
[
SNew(SObjectPropertyEntryBox)
.PropertyHandle(DataTablePropertyHandle)
.AllowedClass(UDataTable::StaticClass())
.OnShouldFilterAsset(this, &FDataTableCustomizationLayout::ShouldFilterAsset)
];
FPropertyComboBoxArgs ComboArgs(RowNamePropertyHandle,
FOnGetPropertyComboBoxStrings::CreateSP(this, &FDataTableCustomizationLayout::OnGetRowStrings),
FOnGetPropertyComboBoxValue::CreateSP(this, &FDataTableCustomizationLayout::OnGetRowValueString));
ComboArgs.ShowSearchForItemCount = 1;
/** Construct a combo box widget to select from a list of valid options */
StructBuilder.AddCustomRow(LOCTEXT("DataTable_RowName", "Row Name"))
.NameContent()
[
SNew(STextBlock)
.Text(LOCTEXT("DataTable_RowName", "Row Name"))
.Font(StructCustomizationUtils.GetRegularFont())
]
.ValueContent()
.MaxDesiredWidth(0.0f) // don't constrain the combo button width
[
PropertyCustomizationHelpers::MakePropertyComboBox(ComboArgs)
];
}
}
bool FDataTableCustomizationLayout::GetCurrentValue(UDataTable*& OutDataTable, FName& OutName) const
{
if (RowNamePropertyHandle.IsValid() && RowNamePropertyHandle->IsValidHandle() && DataTablePropertyHandle.IsValid() && DataTablePropertyHandle->IsValidHandle())
{
// If either handle is multiple value or failure, fail
UObject* SourceDataTable = nullptr;
if (DataTablePropertyHandle->GetValue(SourceDataTable) == FPropertyAccess::Success)
{
OutDataTable = Cast<UDataTable>(SourceDataTable);
if (RowNamePropertyHandle->GetValue(OutName) == FPropertyAccess::Success)
{
return true;
}
}
}
return false;
}
void FDataTableCustomizationLayout::OnSearchForReferences()
{
UDataTable* DataTable;
FName RowName;
if (GetCurrentValue(DataTable, RowName) && DataTable)
{
TArray<FAssetIdentifier> AssetIdentifiers;
AssetIdentifiers.Add(FAssetIdentifier(DataTable, RowName));
FEditorDelegates::OnOpenReferenceViewer.Broadcast(AssetIdentifiers, FReferenceViewerParams());
}
}
FString FDataTableCustomizationLayout::OnGetRowValueString() const
{
if (!RowNamePropertyHandle.IsValid() || !RowNamePropertyHandle->IsValidHandle())
{
return FString();
}
FName RowNameValue;
const FPropertyAccess::Result RowResult = RowNamePropertyHandle->GetValue(RowNameValue);
if (RowResult == FPropertyAccess::Success)
{
if (RowNameValue.IsNone())
{
return LOCTEXT("DataTable_None", "None").ToString();
}
return RowNameValue.ToString();
}
else if (RowResult == FPropertyAccess::Fail)
{
return LOCTEXT("DataTable_None", "None").ToString();
}
else
{
return LOCTEXT("MultipleValues", "Multiple Values").ToString();
}
}
void FDataTableCustomizationLayout::OnGetRowStrings(TArray< TSharedPtr<FString> >& OutStrings, TArray<TSharedPtr<SToolTip>>& OutToolTips, TArray<bool>& OutRestrictedItems) const
{
UDataTable* DataTable = nullptr;
FName IgnoredRowName;
// Ignore return value as we will show rows if table is the same but row names are multiple values
GetCurrentValue(DataTable, IgnoredRowName);
TArray<FName> AllRowNames;
if (DataTable != nullptr)
{
for (TMap<FName, uint8*>::TConstIterator Iterator(DataTable->GetRowMap()); Iterator; ++Iterator)
{
AllRowNames.Add(Iterator.Key());
}
// Sort the names alphabetically.
AllRowNames.Sort(FNameLexicalLess());
}
for (const FName& RowName : AllRowNames)
{
OutStrings.Add(MakeShared<FString>(RowName.ToString()));
OutRestrictedItems.Add(false);
}
}
void FDataTableCustomizationLayout::OnDataTableChanged()
{
UDataTable* CurrentTable;
FName OldName;
// Clear name on table change if no longer valid
if (GetCurrentValue(CurrentTable, OldName))
{
if (!CurrentTable || !CurrentTable->FindRowUnchecked(OldName))
{
RowNamePropertyHandle->SetValue(FName());
}
}
}
bool FDataTableCustomizationLayout::ShouldFilterAsset(const struct FAssetData& AssetData)
{
if (!RowTypeFilter.IsNone())
{
static const FName RowStructureTagName("RowStructure");
FString RowStructure;
if (AssetData.GetTagValue<FString>(RowStructureTagName, RowStructure))
{
if (RowStructure == RowTypeFilter.ToString())
{
return false;
}
// This is slow, but at the moment we don't have an alternative to the short struct name search
UScriptStruct* RowStruct = UClass::TryFindTypeSlow<UScriptStruct>(RowStructure);
if (RowStruct && RowFilterStruct && RowStruct->IsChildOf(RowFilterStruct))
{
return false;
}
}
return true;
}
return false;
}
#undef LOCTEXT_NAMESPACE