Files
UnrealEngineUWP/Engine/Source/Developer/DerivedDataCache/Private/DerivedDataCacheStore.h
Devin Doucette fa8f3dbe82 DDC: Fixed duplicate puts caused by the in-flight memory cache
Without using StopGetStore, get hits on the in-flight cache would propagate as puts to subsequent nodes in the hierarchy. Since the in-flight cache is only used as temporary storage while a put is in flight, this caused duplicates of the in-flight puts, which manifests as move collision log spam from the file system cache store.

#preflight 625d772d691f49969ea93249
#rb Zousar.Shaker
#rnx

[CL 19785647 by Devin Doucette in ue5-main branch]
2022-04-18 11:06:05 -04:00

137 lines
5.1 KiB
C++

// Copyright Epic Games, Inc. All Rights Reserved.
#pragma once
#include "DerivedDataCache.h"
namespace UE::DerivedData { class ILegacyCacheStore; }
namespace UE::DerivedData { enum class EStatus : uint8; }
namespace UE::DerivedData
{
/**
* Interface to a store of cache records and cache values.
*
* Functions on this interface may be called from any thread.
*/
class ICacheStore
{
public:
virtual ~ICacheStore() = default;
/**
* Asynchronous request to put records in the cache.
*
* Behavior must match the cache record policy in each request. A few of those requirements:
* - Store with Query is expected *not* to overwrite an existing record.
* - Store without Query is permitted to overwrite an existing record.
* - Response must be Error if any value has unrecoverable missing data, unless the policy has PartialRecord.
*
* @param Requests Requests with the cache records to store. Records must have a key.
* @param Owner The owner to execute the request within. See IRequestOwner.
* @param OnComplete A callback invoked for every request as it completes or is canceled.
*/
virtual void Put(
TConstArrayView<FCachePutRequest> Requests,
IRequestOwner& Owner,
FOnCachePutComplete&& OnComplete) = 0;
/**
* Asynchronous request to get records from the cache.
*
* Behavior must match the cache record policy in each request. A few of those requirements:
* - Data is required if the value policy has Query.
* - Data must not be in the response if the value policy has SkipData.
* - Response must contain values and available data if the record policy has PartialRecord.
* - Response must be Error if any required data is missing, even if the record policy has PartialRecord.
*
* @param Requests Requests with the keys of the cache records to fetch.
* @param Owner The owner to execute the request within. See IRequestOwner.
* @param OnComplete A callback invoked for every request as it completes or is canceled.
*/
virtual void Get(
TConstArrayView<FCacheGetRequest> Requests,
IRequestOwner& Owner,
FOnCacheGetComplete&& OnComplete) = 0;
/**
* Asynchronous request to put values in the cache.
*
* @param Requests Requests with the cache values to store. Requests must have a key.
* @param Owner The owner to execute the request within. See IRequestOwner.
* @param OnComplete A callback invoked for every request as it completes or is canceled.
*/
virtual void PutValue(
TConstArrayView<FCachePutValueRequest> Requests,
IRequestOwner& Owner,
FOnCachePutValueComplete&& OnComplete) = 0;
/**
* Asynchronous request to get values from the cache.
*
* @param Requests Requests with the keys of the cache values to fetch.
* @param Owner The owner to execute the request within. See IRequestOwner.
* @param OnComplete A callback invoked for every request as it completes or is canceled.
*/
virtual void GetValue(
TConstArrayView<FCacheGetValueRequest> Requests,
IRequestOwner& Owner,
FOnCacheGetValueComplete&& OnComplete) = 0;
/**
* Asynchronous request to get chunks, which are subsets of values, from records or values.
*
* @param Requests Requests with the key, ID, offset, and size of each chunk to fetch.
* @param Owner The owner to execute the request within. See IRequestOwner.
* @param OnComplete A callback invoked for every request as it completes or is canceled.
*/
virtual void GetChunks(
TConstArrayView<FCacheGetChunkRequest> Requests,
IRequestOwner& Owner,
FOnCacheGetChunkComplete&& OnComplete) = 0;
};
enum class ECacheStoreFlags : uint32
{
None = 0,
/** Accepts requests with a policy of QueryLocal or StoreLocal. Needs matching Query/Store flag. */
Local = 1 << 0,
/** Accepts requests with a policy of QueryRemote or StoreRemote. Needs matching Query/Store flag.*/
Remote = 1 << 1,
/** Accepts requests with a policy of QueryLocal or QueryRemote. Needs matching Local/Remote flag. */
Query = 1 << 2,
/** Accepts requests with a policy of StoreLocal or StoreRemote. Needs matching Local/Remote flag. */
Store = 1 << 3,
/** A put of a record or value contained by this cache store will not store to later cache stores. */
StopPutStore = 1 << 4,
/** A get of a record or value contained by this cache store will not store to later cache stores. */
StopGetStore = 1 << 5,
/** A record or value contained by this cache store will not store to later cache stores. */
StopStore = StopPutStore | StopGetStore,
};
ENUM_CLASS_FLAGS(ECacheStoreFlags);
class ICacheStoreOwner
{
public:
virtual void Add(ILegacyCacheStore* CacheStore, ECacheStoreFlags Flags) = 0;
virtual void SetFlags(ILegacyCacheStore* CacheStore, ECacheStoreFlags Flags) = 0;
virtual void RemoveNotSafe(ILegacyCacheStore* CacheStore) = 0;
};
template <typename RequestRangeType, typename OnCompleteType>
inline void CompleteWithStatus(RequestRangeType&& Requests, OnCompleteType&& OnComplete, EStatus Status)
{
for (const auto& Request : Requests)
{
OnComplete(Request.MakeResponse(Status));
}
}
} // UE::DerivedData