kevin macaulayvacher 4897f8726b - Separates FFrame::ReadObject and FFrame::ReadProperty to rely on a new method, FFrame::ReadPointer(), which returns a bare ScriptPointerType. ...

- Changed codepaths reading FProperty objects using ReadObject() to now use ReadPropertyUnchecked(), since FProperty is not a child of UObject (ReadObject was also an unchecked implementation so validation has been lost).

These changes allow ReadObject to return a UObject fetched from a constructed TObjectPtr<UObject> which enables UObject access tracking. This corrects the previous implementation of ReadProperty which would return an FProperty from a temporarily constructed TObjectPtr<UObject>. This had the effect of running TObjectPtr tracking handlers (if any are registered) on the FProperty object which is not actually a UObject type. Using the intermediate TObjectPtr<UObject> in a handler could corrupt the underlying FProperty data as many codepaths in TObjectPtr lazily initialize UObject member variables upon calling UObject methods.

#jira UE-204533
#rb Francis.Hurteau, Robert.Manuszewski

[CL 30924162 by kevin macaulayvacher in ue5-main branch]

2024-01-26 10:27:20 -05:00

..

AdpcmAudioDecoder/Module

Move all Engine Decoders into their own modules

2024-01-17 11:51:40 -05:00

AdvancedWidgets

…

Advertising

Fix usage of _activity errors

2023-12-14 22:26:25 -05:00

AIModule

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

Analytics

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

Android

Fix quest 3 not showing up in supported devices list.

2024-01-25 11:24:13 -05:00

AnimationCore

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

AnimGraphRuntime

Fix error caused by unknown edit condition in twist corrective node

2024-01-25 09:58:44 -05:00

AppFramework

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

Apple

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

ApplicationCore

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

AssetRegistry

AssetRegistry: Speculative fix for missing AssetRegistry information on Windows11. Turn off use of the FileJournalIterateDirectory API function when the Journal information is not required; use the known-safe IterateDirectoryStat instead.

2024-01-23 17:57:52 -05:00

AudioAnalyzer

Disable audio synesthesia NRT analysis for procedural soundwaves including MetaSounds

2024-01-10 16:09:03 -05:00

AudioCaptureCore

FAudioCapture factory now respects GEngine->UseSound() so that capture devices are only instantiated when audio is active.

2023-12-14 18:48:05 -05:00

AudioCaptureImplementations

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

AudioExtensions

Delete IAudioCodec and IAudioCodecRegistry

2023-12-08 11:50:21 -05:00

AudioLink

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

AudioMixer

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

AudioMixerCore

Rad Audio Codec: SDK and UE integration.

2024-01-22 16:42:09 -05:00

AudioPlatformConfiguration

fix bug in audio resampling which was causing automation test failures in //MetaHuman/Dev-MHPlugin-EngineMerge

2023-12-07 17:41:15 -05:00

AugmentedReality

…

AutomationMessages

Clean up screenshot comparison report pipeline

2024-01-18 12:22:38 -05:00

AutomationTest

AutomationTest - Add support for a task tracker field in the Exclude Test Options

2024-01-22 01:42:51 -05:00

AutomationWorker

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

AVEncoder

…

AVIWriter

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

BinkAudioDecoder

BinkAudioInfo should "Reset" its decoders every time it seeks, not just when "PrepareToLoop" is called.

2024-01-12 10:45:33 -05:00

BlueprintRuntime

…

BuildSettings

…

Cbor

…

CEF3Utils

…

CinematicCamera

…

ClientPilot

…

ClothingSystemRuntimeCommon

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

ClothingSystemRuntimeInterface

…

ClothingSystemRuntimeNv

…

ColorManagement

ColorManagement: Convert tests to low-level tests.

2023-12-21 12:56:11 -05:00

CookOnTheFly

…

Core

AsyncCompilationHelper - Remove 16ms main thread sleep that happens per incomplete task and instead favours polling all tasks and sleeping once if not all tasks are complete.

2024-01-26 09:34:10 -05:00

CoreOnline

…

CoreUObject

- Separates FFrame::ReadObject and FFrame::ReadProperty to rely on a new method, FFrame::ReadPointer(), which returns a bare ScriptPointerType.

2024-01-26 10:27:20 -05:00

CoreVerseVM

…

CrashReportCore

Add support for project overrides in crash report client

2024-01-25 03:54:34 -05:00

CUDA/Source

…

D3D12RHI

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

Datasmith

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

DeveloperSettings

…

Engine

AsyncCompilationHelper - Remove 16ms main thread sleep that happens per incomplete task and instead favours polling all tasks and sleeping once if not all tasks are complete.

2024-01-26 09:34:10 -05:00

EngineMessages

…

EngineSettings

…

Experimental

Iris

2024-01-26 08:18:34 -05:00

ExternalRPCRegistry

Update ExternalRpcRegistry to use FExternalRpcArgumentDesc as values rather than as pointers. Addresses current memory leaks, as there are missing calls to delete after being allocated via new. Also made some other optimisations by moving allocations where possible. Some small code standards fixes.

2023-11-28 11:26:43 -05:00

EyeTracker

…

FieldNotification

Replaced UE_NODISCARD with [[nodiscard]].

2024-01-12 10:47:04 -05:00

Foliage

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 19:41:56 -05:00

FriendsAndChat

…

GameMenuBuilder

…

GameplayDebugger

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

GameplayMediaEncoder

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

GameplayTags

Removing coreminimal.h from some of the most included locations

2024-01-23 15:07:05 -05:00

GameplayTasks

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

GeometryCore

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

GeometryFramework

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

HardwareSurvey

…

HeadMountedDisplay

UE-194607 GitHub 10836 : [OpenXR]Supported XR_EXT_local_floor Extension.

2024-01-15 18:19:35 -05:00

IESFile

…

ImageCore

Silence PVS warnings

2024-01-17 01:34:02 -05:00

ImageWrapper

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

ImageWriteQueue

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

InputCore

…

InputDevice

Add support for creating secondary input devices to be used outside of the Unreal Input System.

2024-01-12 12:19:29 -05:00

InstallBundleManager

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

InteractiveToolsFramework

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

Interchange

Interchange: Prevent re-import of legacy imported asset with interchange to create physics asset. fix crash if a translator in the project settings do not exist anymore.

2024-01-22 13:48:03 -05:00

IOS

Move all Engine Decoders into their own modules

2024-01-17 11:51:40 -05:00

IPC

…

Json

Refactor: move classes out of JsonSerializerMacros.h

2023-12-19 14:06:55 -05:00

JsonUtilities

[json] DOM builder trivial: replaced enable_ifs with UE_REQUIRES

2023-12-13 07:47:48 -05:00

Landscape

Mesh Pass Cleanup

2024-01-23 13:58:04 -05:00

Launch

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

LevelSequence

Sequencer: fix level director blueprint not getting root sequence info correctly

2024-01-25 14:00:20 -05:00

Linux/AudioMixerSDL

[Resubmit] Delete deprecated usage of GetRuntimeFormat and CreateCompressedInfo

2024-01-11 17:33:06 -05:00

LiveLinkAnimationCore

…

LiveLinkInterface

[Backout] - CL30895823 (backed out due to errors)

2024-01-25 17:28:51 -05:00

LiveLinkMessageBusFramework

LiveLinkHub - Refactor clients to use a combination of id & message address as an ID

2023-12-07 13:59:38 -05:00

MaterialShaderQualitySettings

…

Media

…

MediaAssets

Adding checks to Mediaframework's texture conversion code to safely ignore samples that present no converter, texture or CPU side buffer despite otherwise being valid

2023-12-20 18:33:12 -05:00

MediaUtils

Fixing up various Electra issues when playing high FPS videos with new DX12 output path code

2024-01-24 19:18:54 -05:00

MeshConversion

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

MeshConversionEngineTypes

…

MeshDescription

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

MeshUtilitiesCommon

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

Messaging

…

MessagingCommon

…

MessagingRpc

…

MoviePlayer

…

MoviePlayerProxy

…

MovieScene

Sequencer: fix splitting/trimming of looping sub-sections

2024-01-24 17:36:37 -05:00

MovieSceneCapture

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

MovieSceneTracks

Sequencer: throw up an assert if playback capabilities are accessed outside of the game-thread.

2024-01-23 16:11:41 -05:00

MRMesh

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

NavigationSystem

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

Navmesh

[Navmesh] Tile generation debug improvements:

2023-11-29 14:14:09 -05:00

Net

Iris

2024-01-26 08:18:34 -05:00

NetworkFile

…

NetworkFileSystem

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 19:41:56 -05:00

Networking

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

NetworkReplayStreaming

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

NNE

[NNE] Uniformising enum status name to match called function

2024-01-26 10:05:21 -05:00

NonRealtimeAudioRenderer

[Resubmit] Delete deprecated usage of GetRuntimeFormat and CreateCompressedInfo

2024-01-11 17:33:06 -05:00

NullDrv

Preparing for dependency cleanup.

2023-12-11 13:55:22 -05:00

NullInstallBundleManager

…

Online

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

OodleDataCompression

Oodle 2.9.12 re-built libs

2024-01-25 15:33:21 -05:00

OpenColorIOWrapper

OCIO: Expose current context getter.

2024-01-10 15:23:17 -05:00

OpenGLDrv

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

OpusAudioDecoder/Module

Move all Engine Decoders into their own modules

2024-01-17 11:51:40 -05:00

Overlay

GetAssetRegistryTags deprecation: Make the old GetAssetRegistryTags and related functions deprecated.

2023-12-08 21:45:21 -05:00

PacketHandlers

…

PakFile

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

PerfCounters

…

PhysicsCore

Fix inability to cook spline meshes by a cooked cooker (resubmit after backout in CL 30847866).

2024-01-24 14:43:39 -05:00

PlatformThirdPartyHelpers/PosixShim

…

Portal

…

PreLoadScreen

Preload Screen Truncation warning fixes

2024-01-16 11:15:58 -05:00

Projects

Added option to prevent unload of code library for GameFeaturePlugins.

2024-01-23 15:40:21 -05:00

PropertyPath

Fix missing vtable causing crashes when using property paths

2023-12-21 17:36:45 -05:00

RadAudioCodec

Rad Audio -> RAD Audio

2024-01-25 17:45:54 -05:00

RawMesh

…

RenderCore

Heterogeneous Volumes: Initial shadow-casting support and integration with translucency pass.

2024-01-26 00:33:50 -05:00

Renderer

PostProcessing: Removed duplicate definitions of FPostProcessMaterialInputs.

2024-01-26 10:24:14 -05:00

RHI

Fixed up more bool-taking calls to take EAllowShrinking instead.

2024-01-25 14:09:12 -05:00

RHICore

RDG Refactor to Improve Parallelism

2024-01-22 11:04:48 -05:00

RSA

…

RuntimeAssetCache

…

SandboxFile

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

Serialization

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

SessionMessages

…

SessionServices

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

SignalProcessing

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

SkeletalMeshDescription

Skeletal Mesh: Allow importing alt influence meshes with mismatched bones.

2024-01-24 19:44:15 -05:00

Slate

PR #11213: [Slate] SBox: Force contents to be center-aligned, not left-aligned, when using Min/MaxAspectRatio

2024-01-23 15:30:07 -05:00

SlateCore

Slate: Add test to prevent unwanted modifications while iterating on a the list with the FWidgetAttributeIterator.

2024-01-24 10:26:07 -05:00

SlateNullRenderer

…

SlateRHIRenderer

Delete slate post process render targets when they are not used after (n) frame. Optimization was previously rollback because the cleanup of the render targets array was done on the gamethread. Since the array is manipulated on the render thread (FindSlatePostProcessResource), the fix was to move the TickPostProcessResources call after the rendering of the slate elements on the render thread.

2024-01-23 17:19:46 -05:00

Sockets

Fixed up DerivedDataCache, DesktopPlatform, ApplicationCore, AssetRegistry, Core, CoreUObject, Projects, Sockets code to use EAllowShrinking instead of bools.

2024-01-17 19:51:06 -05:00

SoundFieldRendering

…

StaticMeshDescription

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

StorageServerClient

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

StreamingFile

…

StreamingPauseRendering

…

SymsLib

Provide universal binaries for SymsLib on Mac

2023-12-14 15:49:11 -05:00

SynthBenchmark

Preparing for dependency cleanup.

2023-12-11 13:55:22 -05:00

TextureUtilitiesCommon

[Backout] - CL30567677

2024-01-12 03:14:57 -05:00

TimeManagement

…

Toolbox/Private

…

TraceLog

Fix static analysis warnings

2023-12-12 13:43:17 -05:00

TypedElementFramework

Rewrite of TEDS' Scratch Buffer.

2024-01-25 18:02:54 -05:00

TypedElementRuntime

IterativeCooker: Add initial set of allowed and blocked classes for incremental cooking, and some utility functions that we needed to implement it.

2024-01-12 14:28:27 -05:00

UEJpegComp

…

UELibrary

…

UEWavComp

…

UMG

Fix issue with images not showing.

2024-01-25 18:33:29 -05:00

UniversalObjectLocator

Sequencer- Cleanup and minor refactor of use of locators for Sequencer in preparation for the 5.4/29.00 branch.

2024-01-24 16:04:51 -05:00

Unix/UnixCommonStartup

…

UnrealGame

…

VectorVM

[Backout] - CL30888819

2024-01-26 02:19:44 -05:00

VirtualFileCache

Replaced UE_NODISCARD with [[nodiscard]].

2024-01-12 10:47:04 -05:00

VirtualProduction/StageDataCore

…

VorbisAudioDecoder/Module

Move all Engine Decoders into their own modules

2024-01-17 11:51:40 -05:00

VulkanRHI

Works arround a AMD driver bug on memory order of InterlockedMax on a Texture2D corrupting TSR's parallax disocclusion mask

2024-01-23 14:58:18 -05:00

WebBrowser

WebBrowser: Added OnFocusRecieved handler to SWebBrowserView Slate widget to properly route keyboard focus.

2023-12-15 19:25:42 -05:00

WebBrowserTexture

…

WidgetCarousel

…

Windows

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00

XmlParser

Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.

2024-01-19 16:41:35 -05:00