You've already forked UnrealEngineUWP
mirror of
https://github.com/izzy2lost/UnrealEngineUWP.git
synced 2026-03-26 18:15:20 -07:00
The goal of the initial change was to ensure that the OnValueChanged delegate was called properly when the value was changed, even if it was not changed by a direct input on the widget (ie. if the value was set programatically). In the case of Lyra it was crashing because the callback was called too soon, in the widget initialization process. With this change, SSlider::SetValue will no longer call the USlider via a delegate, but instead, USlider will call the USlider::HandleOnValueChanged itself, avoid having the SSlider calling back USlider in unwanted situations. Tests: - repro from the 100% crash, it's no longer crashing, sliders are working (their value can be changed, they will affect the game). - tested my initial use case in UEFN, it's still working as expected. #jira UE-178164 #preflight 63f8de52a134e0b059a805f9 #rb daren.cheng [CL 24402423 by yohann dossantos in ue5-main branch]