You've already forked UnrealEngineUWP
mirror of
https://github.com/izzy2lost/UnrealEngineUWP.git
synced 2026-03-26 18:15:20 -07:00
#rb Per.Larsson #jira UE-208639 #rnx ### Error Handling - Previously we only recorded the http response value inFS3Response, which meant that issues with the API itself (such as being unable to connect to the target) would go unreported. - We now record the curl error value as FS3Response::ApiStatusCode - Replaced FS3Response::GetErrorMsg with two different methods, one to return a short error message based off the api and http status values and another to return longer error messages with additional error messages parsed from the response body where possible. -- We do also log the api (curl) error when they are first detected under the "LogS3Client" category, but these messages are too verbose and heavy weight to pass around with the FS3Response class. ### Misc - Add a new logging category "LogS3Client" for the S3Client module for now it is declared in the only cpp of the module. - Made the members of FS3Response private and added the appropriate accessors. -- This should encourage people to use the accessors provided to get error messages rather than just relying on the HttpStatusCode or ApiStatusCode and maybe missing out on important info. [CL 32365499 by paul chipchase in ue5-main branch]