Commit Graph

4698 Commits

Author SHA1 Message Date
ben marsh
fffd43eb4f Fix log output showing CL being synced for iterative cooks.
#jira
[FYI] Jeff.Williams

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5491806 via CL 5492141 via CL 5492157
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5510554 by ben marsh in Dev-Anim branch]
2019-03-22 17:29:39 -04:00
sorin gradinaru
eb32e8c895 UE-71596 iOS packaging error with CloudKit enabled - Provisioning profile <...> doesn't match the entitlements file's values
#jira UE-71596
#4.22
#iOS
#tvOS
#rb Jack.Porter
#lockdown cristina.riveron

Write the entitlements in PostBuldSync.
Target.bCreateStubIPA is false when building on mac, true on windows (using the -CreateStub argument)

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: sorin.gradinaru
#ROBOMERGE-SOURCE: CL 5491331 in //UE4/Release-4.22/... via CL 5491335
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5510325 by sorin gradinaru in Dev-Anim branch]
2019-03-22 17:28:10 -04:00
graeme thornton
b69f03543a Use accessor function on crypto settings in UAT to determine if signing is enabled, rather than reading the flag directly. Makes sure that signing is correctly disabled if the setting is enabled but no key was set
#rb ben.marsh
#jira UE-71803
#lockdown cristina.riveron

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5487901 in //UE4/Release-4.22/... via CL 5487905
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5507740 by graeme thornton in Dev-Anim branch]
2019-03-22 17:13:10 -04:00
graeme thornton
f233b235d1 Add new config values to go alongside "PlatformRequiresDataCrypto" which can specifically disable signing or encryption. Allows selective disabling of signing OR encryption on some platforms, rather than the old config value which would disable both.
Disable signing on platforms that we wanted encryption enabled for by default (mobile mainly)
Add a warning if pak signing or encryption is enabled but there is no key, then disable the offending functionality for that build

#rb none
#jira UE-71811, UE-71806
#lockdown cristina.riveron

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5487098 in //UE4/Release-4.22/... via CL 5487102
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5507319 by graeme thornton in Dev-Anim branch]
2019-03-22 17:11:06 -04:00
chris babcock
dd060546bf Fix logging of store version
#rb none
[FYI] Andrew.Grant

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: chris.babcock
#ROBOMERGE-SOURCE: CL 5481418 via CL 5481426 via CL 5484531 via CL 5484535
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5506353 by chris babcock in Dev-Anim branch]
2019-03-22 17:05:17 -04:00
andrew grant
11be41b1e6 Added some logging around Android symbol generaton
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5469194 via CL 5469197 via CL 5470751 via CL 5470757
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5505363 by andrew grant in Dev-Anim branch]
2019-03-22 17:00:00 -04:00
graeme thornton
4f06e16149 Edigrated rollup of all engine RSA changes that were done for 4.22. Pak signature checking is now much more competent.
#rb none
[FYI] joe.barrett
#rnx

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5469067 via CL 5469119 via CL 5470585 via CL 5470597
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5505293 by graeme thornton in Dev-Anim branch]
2019-03-22 16:59:44 -04:00
andrew grant
8e673f1ef1 Fixed issue with UBTArgs including quotes.
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5460234 via CL 5462256 via CL 5462315
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5477240 by andrew grant in Dev-Anim branch]
2019-03-20 13:30:52 -04:00
ben marsh
d501be5207 Fix missing plugin error at startup.
#jira

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5459335 via CL 5461952 via CL 5462074
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5476936 by ben marsh in Dev-Anim branch]
2019-03-20 13:28:46 -04:00
ben marsh
8ef2559af1 UBT: Make mismatched supported target platforms an error.
#jira

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5459241 via CL 5460114 via CL 5460172
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5476808 by ben marsh in Dev-Anim branch]
2019-03-20 13:28:14 -04:00
ben marsh
503c4b8d8a Add a warning when a plugin reference overrides the plugin's list of supported target platforms. Silently failing at build time will cause errors at runtime.
[FYI] Justin.Marcus
#jira

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5459133 via CL 5459920 via CL 5460056
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5476611 by ben marsh in Dev-Anim branch]
2019-03-20 13:27:06 -04:00
andrew grant
a7ac60f754 Added some verbose logging when copying Kairos files
Fixed some case checks
Made -config param optional

[FYI] daniel.lamb

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5459100 via CL 5459911 via CL 5460034
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5476572 by andrew grant in Dev-Anim branch]
2019-03-20 13:26:51 -04:00
ben marsh
e7693cb8c7 Fix exception when hot-reloading a module that contains an additional bundle resource. List of hot-reload build products for each module now only includes import library and DLL.
#rb none
#jira UE-71692

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5458343 in //UE4/Release-4.22/... via CL 5458360
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5474993 by ben marsh in Dev-Anim branch]
2019-03-20 13:15:30 -04:00
sorin gradinaru
3b5cb86561 UE-52346 TM-Gameplay: Load Level Volume Fails to Read TestSlot.sav file
#jira UE-52346
#iOS
#tvOS
#rb Jack.Porter

Created a pList key named ICloudContainerIdentifier to be used at run-time when intializing the CloudKit services

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: sorin.gradinaru
#ROBOMERGE-SOURCE: CL 5448858 in //UE4/Release-4.22/... via CL 5448862
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5471396 by sorin gradinaru in Dev-Anim branch]
2019-03-20 13:01:03 -04:00
ben marsh
6e5c840498 UBT: Disable the "bAdaptiveUnityDisablesPCH" build flag by default. This significantly improves iteration times on individual files, at the risk of introducing missing headers. Will validate this in CIS instead.
#rb none
#jira

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5447578 in //UE4/Release-4.22/... via CL 5447579
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5471224 by ben marsh in Dev-Anim branch]
2019-03-20 13:00:26 -04:00
graeme thornton
cf5dbb9860 Created a new interface to RSA functionality that is independent of key size (unlike the old TBigInt version). Internally, RSA functions are implemented by OpenSSL on Windows/Mac/Linux an falling back to the TBigInt implementation for other platforms
- Future plan would be not to use OpenSSL directly, but to go via PlatformCrypto or something like it which could provide platform specific RSA functionality if it exists
- Also contains some compensation code for platforms that are still stuck on an older version of OpenSSL (everything except windows)
- On platforms that use OpenSSL < 1.1.1, register a locking callback so we can provide mutexes and stop it crashing horribly when the same RSA key is used concurrently on different threads

Changed default key size in the CryptoKeys plugin to 4096 bits.

#jira UE-71377
#rb ian.fox, robert.manuszewski, ryan.gerleve

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: graeme.thornton
#ROBOMERGE-SOURCE: CL 5447433 in //UE4/Release-4.22/... via CL 5447485
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5447738 by graeme thornton in Dev-Anim branch]
2019-03-19 09:01:12 -04:00
jules blok
91a2107344 Escape all paths when generating VS project filter files
#jira UE-71727
#rb Jack.Porter

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jules.blok
#ROBOMERGE-SOURCE: CL 5439949 in //UE4/Release-4.22/... via CL 5439986
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5443190 by jules blok in Dev-Anim branch]
2019-03-19 01:03:48 -04:00
andrew grant
f2c663907a Use case-insensitive comparison for package names
#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5435243 via CL 5438956 via CL 5439032
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5441701 by andrew grant in Dev-Anim branch]
2019-03-18 21:13:07 -04:00
andrew grant
dfe01ffd79 null-merge of Android toolchain
Fixed issue with code stripping of frameworks not being restricted to local symbols


#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: andrew.grant
#ROBOMERGE-SOURCE: CL 5435138 via CL 5438906 via CL 5438992
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5441558 by andrew grant in Dev-Anim branch]
2019-03-18 21:12:01 -04:00
pete procopio
9a55a816a5 Allow dynamic library as target for finalizing Android project
#ue4
#android
#rb Chris.Babcock
[FYI] Chris.Babcock


#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: pete.procopio
#ROBOMERGE-SOURCE: CL 5420722 via CL 5427997 via CL 5428139
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5431754 by pete procopio in Dev-Anim branch]
2019-03-18 13:11:13 -04:00
ben marsh
b10bbe4b3c Remove the CommandUtils.Log function, so we don't shadow the global Log class.
#jira

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 5418570 via CL 5426900 via CL 5427007
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5430741 by ben marsh in Dev-Anim branch]
2019-03-18 13:01:44 -04:00
jeff fisher
65239b882b Back out changelist 5417701
-This fix breaks the ddc build, which is more important.
#rb build
#jira UE-67120

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jeff.fisher
#ROBOMERGE-SOURCE: CL 5423419 in //UE4/Release-4.22/... via CL 5423420
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5423531 by jeff fisher in Dev-Anim branch]
2019-03-16 16:58:46 -04:00
sorin gradinaru
3c4f91bf4d UE-71596 iOS packaging error with CloudKit enabled - Provisioning profile <...> doesn't match the entitlements file's values
#jira UE-71596
#iOS
#tvOS
#4.22
#rb Jack.Porter

Moved the entitlements file generation from preinit to postbuild, so we can write the correct iCloud container settings

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: sorin.gradinaru
#ROBOMERGE-SOURCE: CL 5419244 in //UE4/Release-4.22/... via CL 5419247
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5421560 by sorin gradinaru in Dev-Anim branch]
2019-03-15 17:02:59 -04:00
jeff fisher
d332048438 UE-67120 Editor crash on startup after enabling Morpheus plugin...
UE-67297 ShaderCompiler crash when opening the editor with Morpheus plugin and project setting enabled
-Moved this shader file out of platform shader directory into the  plugin shaders (it isn't actually for use on that platform, its used in the editor).  Sadly we still need to use it from engine code if the shader file exists because a postprocesspass cannot be defined in a plugin and I couldn't find a way to pull the shader from the plugin and use it in the pass so I had to hardcode the shader path mapping for this plugin in launchengineloop.  A rendering refactor is coming along that will make postprocess passes more like other passes, so it makes sense to defer refactoring this until after that.
#jira UE-67120 UE-67297
#rb Ryan.Vance

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: jeff.fisher
#ROBOMERGE-SOURCE: CL 5417701 in //UE4/Release-4.22/... via CL 5417707
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5420943 by jeff fisher in Dev-Anim branch]
2019-03-15 16:59:14 -04:00
nick shin
44268faca5 HTML5 - FrontEnd COTF - seems proxy port is no longer used/needed
#jira UE-64628  HTML5 Quick Launch fails to connect due to incorrect port
#rb none
#rnx

#ROBOMERGE-OWNER: lina.halper
#ROBOMERGE-AUTHOR: nick.shin
#ROBOMERGE-SOURCE: CL 5415267 in //UE4/Release-4.22/... via CL 5415269
#ROBOMERGE-BOT: ANIM (Main -> Dev-Anim)

[CL 5418429 by nick shin in Dev-Anim branch]
2019-03-15 13:01:55 -04:00