Commit Graph

229 Commits

Author SHA1 Message Date
phil popp
2f280717b0 Add metasound reset routine to external nodes
#jira UE-174363
#rb Rob.Gay
#preflight 6400d71caa004233353024cb

[CL 24488096 by phil popp in ue5-main branch]
2023-03-02 14:40:35 -05:00
nicholas howe
fe85d59d59 Fix race condition in FPatchOutput::WaitUntilNumSamplesAvailable when setting up the sample pushed event.
[REVIEW] [at]jake.burga
#preflight 63ff5fe5ae54ee4ce9372314

[CL 24469442 by nicholas howe in ue5-main branch]
2023-03-01 15:40:57 -05:00
phil popp
a7aff7825c Fix for unit test crashing on ARM machines.
#jira UE-178037
#rb Helen.Yang
#preflight 63fd3567f43e53f6812bf0a7

[CL 24448660 by phil popp in ue5-main branch]
2023-02-28 14:56:09 -05:00
nicholas howe
2f6980f67a Nonunity build fix
include HAL/PlatformTime.h

#preflight skip

[CL 24427856 by nicholas howe in ue5-main branch]
2023-02-27 13:35:54 -05:00
nicholas howe
1c419fc963 Audio Bus Reader/Writer Nodes Crackle Fix
Audio Bus Reader Node more accurately calculates how many samples it needs before it can start popping.
Reader node has a CVar timeout on how long it'll wait for samples (whereas it used to calculate a huge timeout value that I suspect was erroneous).  In theory the samples should always become available even with an infinite timeout.
The Metasound generator's BuilderTask's completion is ensured at the beginning of FMetasoundGenerator::OnGenerateAudio.  This prevents the mixer, writer and reader nodes from getting out of sync in terms of samples output and input.
FMixerAudioBus::MixBuffer doesn't try to cache any samples and just uses PopAudio and PushAudio directly on its mixer and splitter.
FPatchOutput::WaitUntilNumSamplesAvailable no longer has a race condition and an attempt has been made to improve thread-safety in FPatchOutput.

#jira UE-170575
#rb phil.popp
#preflight 63fcbfe2a134e0b059c64c76

[CL 24427705 by nicholas howe in ue5-main branch]
2023-02-27 13:29:22 -05:00
Joe Kirchoff
2d50350b4f Fix dsp include path for BuildSettingsVersion.V3
#rnx
#rb trivial
#preflight 63ec06e0346bca0035cb2101

[CL 24222048 by Joe Kirchoff in ue5-main branch]
2023-02-14 17:25:46 -05:00
phil popp
aabb506a7b Fix for unit test failure in sine wavetable oscillator.
#rnx
#rb trivial
#jira UE-175492
#preflight skip

[CL 23933590 by phil popp in ue5-main branch]
2023-01-31 14:12:35 -05:00
phil popp
1d78b81b52 Metasound automated node tests and fixes
#jira UE-175097
#rb Charlie.Huguenard
#preflight 63d1895f033e457ba8f10cb4

[CL 23863384 by phil popp in ue5-main branch]
2023-01-25 20:41:44 -05:00
jimmy smith
23c3b961e7 Perlin "value" noise metasound node
#rb helen.yang miles.flanagan
#preflight 63cf2860574ab9cae49c0c5b

[CL 23825389 by jimmy smith in ue5-main branch]
2023-01-23 19:50:56 -05:00
steve robb
6a31618d42 Removed TIsSame from misc. engine files (part of a larger change to deprecate TIsSame).
#rb devin.doucette
#preflight 63c01cac8f4acc7b54d8832d

[CL 23678906 by steve robb in ue5-main branch]
2023-01-13 11:47:02 -05:00
henrik karlsson
ce587eb612 Added markups for headers that can't be compiled standalone.. this is needed for both Header units and IWYU
#preflight 63789b0c170bc34a93a869e5
#rb none

[CL 23552160 by henrik karlsson in ue5-main branch]
2022-12-21 02:46:50 -05:00
maxwell hayes
44b81d0d81 Added missing scale degree to dorian mode (scale to note array node).
#jira UE-170476
#rb Alfaroh.Corney
#preflight 6387cc07f213a116ebc56476

[CL 23500239 by maxwell hayes in ue5-main branch]
2022-12-13 18:29:54 -05:00
nicholas howe
373ad2a12c Metasound Audio Bus Writer Node
Adds a metasound node that sends its audio input to an audio bus.
Modifies the audio mixer interface to support the node.

FMixerSourceManager::StartAudioBus no longer sets bIsPlaying to false on sources that use an audio bus when the audio bus starts.
FMixerAudioBus::MixBuffer mixes its patch inputs into its MixedSourceData buffer, so that the patch input data is available when CopyCurrentBuffer is used to retrieve the mix.

[REVIEW] [at]aaron.mcleran [at]buzz.burrowes [at]phil.popp
#preflight 6372639c5368a3230a4ed041

[CL 23123823 by nicholas howe in ue5-main branch]
2022-11-14 14:44:30 -05:00
mihnea balta
be6dd35f83 Correctness tests for ISPC functions
Submitting on behalf of Jeff.Rous@intel.com.

#jira none
#preflight https://horde.devtools.epicgames.com/job/636e1eb4953c19d435345835
#rnx
#rb Kriss.Gossart, Phil.Popp, Shaun.Kime

[CL 23094728 by mihnea balta in ue5-main branch]
2022-11-11 05:53:55 -05:00
Zak Middleton
9149ed2129 #ue5 - Truncation fixes for misc engine headers and modules:
- GameplayMediaEncoder
- GameplayTasks

#jira UE-160833
#rb Andrew.Davidson
#preflight 6362aead876630122ab1dead

[CL 22990977 by Zak Middleton in ue5-main branch]
2022-11-04 13:48:41 -04:00
anna lantz
be286bb14c Fix for Limiter Distortion with non-zero attack times
#jira UE-157404
#rb alfaroh.corneyiii
#preflight 63506678c9559712ed1397de

[CL 22649064 by anna lantz in ue5-main branch]
2022-10-19 22:39:29 -04:00
Zak Middleton
9139df46c1 #ue5 - Type conversion fixes for MediaAssets, MovieScene, and SignalProcessing modules.
#jira UE-160835
#rb Dave.Jones2
#preflight 634ee3f3e05a24a939dcc01d

[CL 22606604 by Zak Middleton in ue5-main branch]
2022-10-18 14:22:06 -04:00
rob gay
56088a4180 DSP LFO/Modulation LFO fixes
- Add missing exponential factor to Modulation generator
- Fix bounds restriction calculation for expontential factor
- Add LFO ResetPhase implementation to override initial location in oscilator on rising edge where necessary (for modulation LFO, user range limited to unipolar but hardly ever wants to start at midpoint).
- Add bipolar option to avoid oneshot/bipolar conflation for certain types of LFOs
- Add back implementation for 5.1 deprecated function to avoid breaking licensees
#rb phil.popp
[REVIEW] phil.popp
#jira UE-127886
#preflight 6346eed9b757820b7ae99b76

[CL 22483928 by rob gay in ue5-main branch]
2022-10-12 15:31:28 -04:00
alfaroh corneyiii
d675b2ee4e Fix Occasional Unexpected Behavior in Bitcrusher Node
#jira UE-163142
#preflight 633df62ba712a61df1027517
#rb max.hayes phil.popp

[CL 22387912 by alfaroh corneyiii in ue5-main branch]
2022-10-06 19:46:23 -04:00
helen yang
41d88a2f2e Fix crash in submix spectrum analyzer with unclamped hop size
#jira UE-160484
#rb phil.popp
#preflight 63377ceae72271755f49c7c5

[CL 22322136 by helen yang in ue5-main branch]
2022-10-03 20:34:23 -04:00
andrew davidson
970f8f6a18 Non-Engine module public header truncation fixes to reduce noise when compiling with truncation warnings
#jira UE-160823
#rb dave.jones2, zak.middleton
#preflight 6336a3ecc37844870af8b119

[CL 22271698 by andrew davidson in ue5-main branch]
2022-09-30 11:36:06 -04:00
phil popp
3496231079 CIS Fix for Mac UnitTestAudioFFT aggregate initialization
#rb trivial
#jira UE-163402
#preflight 631f591622433f4f5c65bbb2

[CL 21974113 by phil popp in ue5-main branch]
2022-09-12 18:20:11 -04:00
bryan sefcik
07894f4a07 Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631a717cec45fbf3d74d4ba7

[CL 21916033 by bryan sefcik in ue5-main branch]
2022-09-09 00:53:22 -04:00
phil popp
056d717727 Deprecate AudioFFT in favor of optimized and hardware accelerated version
Deprecating voice processing as is not tested or needed. Current voice processing needs are handled in EOS with WebRTC.
#rb Aaron.McLeran, Helen.Yang
#jira UE-148715
#preflight 631a3e9ed31788ea3a59f214

[CL 21910441 by phil popp in ue5-main branch]
2022-09-08 21:27:22 -04:00
Zak Middleton
84fb0737e0 #ue5 - Fix type conversion warnings in modules: AutomationController, AutomationTest, AVEncoder, AVIWriter.
#jira UE-160830
#rb Andrew.Davidson
#preflight 630d2147556fc14dce527da5

[CL 21690862 by Zak Middleton in ue5-main branch]
2022-08-29 18:32:03 -04:00