Commit Graph

91 Commits

Author SHA1 Message Date
bob tellez
a974b2479b [Backout] - CL25038865
[FYI] Patrick.Boutot
Original CL Desc
-----------------------------------------------------------------
MVVM: Remove the specialized viewmodel editor and use the Blueprint base editor instead.
#jira UE-182297
#preflight 64381b51df20983c41604681

[CL 25050244 by bob tellez in ue5-main branch]
2023-04-14 17:07:03 -04:00
patrick boutot
a4220fc5fe MVVM: Remove the specialized viewmodel editor and use the Blueprint base editor instead.
#jira UE-182297
#preflight 64381b51df20983c41604681

[CL 25039205 by patrick boutot in ue5-main branch]
2023-04-14 09:07:11 -04:00
bob tellez
953cc7733b [Backout] - CL25027663
[FYI] Patrick.Boutot
Original CL Desc
-----------------------------------------------------------------
MVVM: Remove the specialized viewmodel editor and use the Blueprint base editor instead.
#jira UE-182297
#preflight 64381b51df20983c41604681

[CL 25035582 by bob tellez in ue5-main branch]
2023-04-13 20:30:11 -04:00
patrick boutot
ed5cdea372 MVVM: Remove the specialized viewmodel editor and use the Blueprint base editor instead.
#jira UE-182297

[CL 25032617 by patrick boutot in ue5-main branch]
2023-04-13 17:04:04 -04:00
patrick boutot
07f2ab96d8 MVVM: Fix false positive when detecting duplicated binding. Complex functions do not have a source and it's normal that it reuse the same compiled binding.
#rb none
#preflight none

[CL 25025595 by patrick boutot in ue5-main branch]
2023-04-13 10:55:58 -04:00
patrick boutot
67693ef1b7 MVVM: Fix SetViewModel that didn't trigger the child viewmodel binding when changed. Use QAGame UMG_MVVM_LongPath to test. The order the sources are added is important to make sure the bindings are executed in the correct order.
#rb yohann.dossantos
#preflight 642ebaca4847065878530573

[CL 24956638 by patrick boutot in ue5-main branch]
2023-04-06 16:59:04 -04:00
marc audy
6381600309 Move UMG/FieldNotification files to the FieldNotification module.
#jira UE-130880
#rb yohann.dossantos
#preflight 64259ab69834526476306f92, 642aee5a6a37fb35e9ba9926

[CL 24905939 by marc audy in ue5-main branch]
2023-04-03 22:29:35 -04:00
patrick boutot
06a212dc01 MVVM: Add option to not add the compiled result to the final GeneratedClass. Used for property validation.
[CL 24884489 by patrick boutot in ue5-main branch]
2023-04-01 02:41:19 -04:00
Patrick Boutot
d6af8a1dd4 MVVM: Remove warning when building the viewmodel setter graph. The cast not is not needed anymore.
#rb yohann.dossantos
#preflight 6426deeb2a0b706ac68f81d8

[CL 24871491 by Patrick Boutot in ue5-main branch]
2023-03-31 10:56:15 -04:00
zahra nikbakht
f6c07441c6 Disable/enable context filtering in MVVM binding creation through project settings or a temporary checkbox
#preflight 641c89d9a86ae7cbcce4dae3
#rb patrick.boutot
#jira UE-180197

[CL 24766690 by zahra nikbakht in ue5-main branch]
2023-03-23 15:27:54 -04:00
patrick boutot
427ba04371 MVVM: Remove needs to have a SourcePath for ComplexConversionFunction. The source data is inside the function itself and the fieldnotify name is already saved in the class binding.
Update GetBindingInfoFromFieldPath to support viewmodel inside another viewmodel. Add unittest for the function.
Add DoesInitializeAtConstruction on the view class. That is to support manual initialization. When the flag is false, the user is responsible for initializing the view.
Add ReevaluateSourceCreator. A source that was discovered at compile time and added to the list of SourceCreator may need to be evaluated if the path contains notify. That function is similar to SetViewModel but finds the new value from the SourceCreator.
Fix issue when a binding destination can't be evaluated at initialization. Since we only reactivate the bindings link to a source in SetViewModel, some bindings were never registered and never executed after the SetViewModel properly set the binding destination.
Update the view class ToString functions with the new flags.
Prevent adding a new binding when the editor data contains a conversion function and a regular function. That may occur when the user started with a regular binding and changed it afterward for a conversion function. We may not want to reset the binding to be non destructive.
#prefligth 6419e837bb1320be412d274d, 641b068aee0aed13479e6ea3

[CL 24750233 by patrick boutot in ue5-main branch]
2023-03-22 13:07:37 -04:00
zahra nikbakht
e206fdedb6 - Move the list of messages (errors, warnings, info) from the bindings themselves to the owning viewmodel.
- Add a border on each MVVM binding row in the list view of bindings that changes color to red/yellow if there is any error/warning for that binding
- detect if a property is bound to both a MVVM binding and a legacy binding at the same time and add a warning for it.
#jira UE-170983
#jira UE-170403
#rb patrick.boutot, vincent.gauthier
#preflight 6414c614ca2afe3ee6b1c7c8

[CL 24695764 by zahra nikbakht in ue5-main branch]
2023-03-17 16:33:42 -04:00
patrick boutot
f643a8ba09 MVVM: Temporary remove the error warning until we fix some assets.
[CL 24679072 by patrick boutot in ue5-main branch]
2023-03-16 16:49:30 -04:00
patrick boutot
0f5123a168 MVVM: Add option to log all bindings after compilations. Complete the ToString library from CompiledBindings. Expose the LogMVVM to other MVVM modules. In the view, properly report error in the message log.
#jira UE-178313
#preflight 64130274bd6894c43518c04e
#rb daren.cheng

[CL 24673818 by patrick boutot in ue5-main branch]
2023-03-16 13:02:33 -04:00
patrick boutot
2c2fa3761b MVVM: Add a global option to allow viewmodel setter function. This prevent the validation for object /Script/CoreUObject.Function.
Add an option to show the detail view in the binding panel. This prevent the bad memory access in the customizer used by a the binding panel.
#preflight 640b5c260e1f02786bff27f5

[CL 24603096 by patrick boutot in ue5-main branch]
2023-03-10 23:20:09 -05:00
patrick boutot
bc181cb231 MVVM: Rename MVVMBlueprintViewBinding.ViewModelPath and WidgetPath to SourePath and DestinationPath. Historicly they were named that way because it made sense to bind grom viewmodel to a widget. Now we can bind from any property to any property. We renamed to remove the confusion.
#test MVVM asset in QAGame
#rb Yohann.DosSantos
#preflight 64089d788c0039bbf73e80d8

[CL 24574634 by patrick boutot in ue5-main branch]
2023-03-09 08:41:28 -05:00
patrick boutot
8f4aae576d MVVM: Temporary disable code that make the viewmodel variable private. The code is there to prevent setting the variable without using the Setter function.
[CL 24525458 by patrick boutot in ue5-main branch]
2023-03-06 13:07:33 -05:00
patrick boutot
91dfcc1e92 MVVM: First step to support viewmodel inside viewmodel. The wiew now support source that is not a UserWidget property. The compiler generates the missing path.
#jira UE-155920
#preflight 6405aa936e1dadfcdaec0442

[CL 24521505 by patrick boutot in ue5-main branch]
2023-03-06 09:41:11 -05:00
ronald koppers
6f5addd262 Renamed PropertyEditorPermissionList to PropertyPermissionList.
#preflight 63fd04f5c35a14198011368b
#rb Rex.Hill

[CL 24432348 by ronald koppers in ue5-main branch]
2023-02-27 16:27:44 -05:00
ronald koppers
a15889181b Added a new hidden property validation list.
#rb Rex.Hill
#preflight 63f7c9562b1a2765f90a26a5

[CL 24397802 by ronald koppers in ue5-main branch]
2023-02-24 03:57:54 -05:00
patrick boutot
fb31ea2d89 MVVM: Test if the properties or functions are allowed at compile time.
#jira UE-164316
#preflight 63eaf47eb91ae11c1cf4ded7, 63ece0c9514832b242a0f66b

[CL 24289488 by patrick boutot in ue5-main branch]
2023-02-17 15:28:46 -05:00
patrick boutot
583f54b65e Revert properties or functions compile time test introdued with CL 24208984
[CL 24251749 by patrick boutot in ue5-main branch]
2023-02-16 01:58:19 -05:00
patrick boutot
82df764154 MVVM: Test if the properties or functions are allowed at compile time.
#jira UE-164316
#preflight 63eaf47eb91ae11c1cf4ded7, 63ece0c9514832b242a0f66b

[CL 24251528 by patrick boutot in ue5-main branch]
2023-02-16 01:48:06 -05:00
patrick boutot
50aed20739 Revert properties or functions compile time test introdued with CL 24208984
[CL 24215611 by patrick boutot in ue5-main branch]
2023-02-14 13:03:02 -05:00
patrick boutot
7dd604438f MVVM: Test if the properties or functions are allowed at compile time.
#jira UE-164316
#preflight 63eaf47eb91ae11c1cf4ded7

[CL 24213905 by patrick boutot in ue5-main branch]
2023-02-14 12:07:02 -05:00