Rob Gay
366cf65d70
Speculative fix for parameter list construction issue on certain platforms
...
#rb trivial
#jira none
#rnx
#preflight 64347e2241783dc3d0894f21
[CL 24984638 by Rob Gay in ue5-main branch]
2023-04-10 17:45:18 -04:00
phil popp
28544b44bd
Fix data channel management on MetaSounds
...
#rnx
[FYI] Miles.Flanagan
#preflight 642f1db1b306e98c6328cecc
#rb Rob.Gay
[CL 24959616 by phil popp in ue5-main branch]
2023-04-06 18:47:28 -04:00
Rob Gay
3c562cf540
Jumped the gun on submit after preflight on last CL, missing fix.
...
#rb trivial
#jira UE-181360
#rnx
#preflight skip
[CL 24956461 by Rob Gay in ue5-main branch]
2023-04-06 16:51:46 -04:00
Rob Gay
49c739169c
Fix class references misguided towards transient MetaSound class instead of MetaSound Builder class causing failures to add/remove interfaces in certain contexts
...
#rb phil.popp
#jira UE-181360
#preflight 642f15426d46f6b1bfac1f59
#rnx
[CL 24955760 by Rob Gay in ue5-main branch]
2023-04-06 16:32:00 -04:00
charlie huguenard
fb1959d641
[Metasound] Fix races in UMetasoundOutputSubsystem
...
The generator created/destroyed events get called on the audio thread, so avoid manipulating containers used on the game thread in the event.
#rnx
#rb phil.popp, aaron.mcleran
#preflight 642db4d71d19c0312a39ab12
[CL 24937556 by charlie huguenard in ue5-main branch]
2023-04-05 17:42:36 -04:00
phil popp
274f01210e
Remove transmittable input nodes and move updating parameters to the metasound generator
...
#jira UE-179992
#rb Rob.Gay
#preflight 642d9f944847065878db1c64
[CL 24937473 by phil popp in ue5-main branch]
2023-04-05 17:38:47 -04:00
kevin cavanaugh
45a42b6042
Workaround in the metasound builder for source interfaces not being added automatically
...
#preflight skip
#rb charlie.huguenard
[FYI] rob.gay
[CL 24936606 by kevin cavanaugh in ue5-main branch]
2023-04-05 17:01:55 -04:00
rob gay
1de499ef8e
More MetaSound Interface registry clean-up
...
- Move bIsDefault/bCanEdit(renamed bIsModifiable) from InterfaceRegistryEntry to Interface data definition
- Add checks in builder to disallow mutation of interfaces that shouldn't be via editor or document builder (ex. SourceInterface which is default and then never changed)
- Optimize SearchEngine query for finding default interfaces
- Tweak MetaSoundUObjectRegistry to support non MetasoundAssetBase classes and add UMetaSoundBuilderDocument. Update iterator w/optional param to only return asset types (true by default for back compat)
- Move FName class name comparitors to use new TopLevelAssetPath
#rb phil.popp
#jira UE-181360
#rnx
#p4v-preflight-copy 24658328
#preflight 642b10834d26bcd1eb0e566c
[CL 24920763 by rob gay in ue5-main branch]
2023-04-04 19:14:26 -04:00
buzz burrowes
e7af0e2bde
Add TRACE macros for profiling
...
[REVIEW] [at]phil.popp
#preflight 642c2cea4d26bcd1eb7aaac3
[CL 24912849 by buzz burrowes in ue5-main branch]
2023-04-04 12:40:45 -04:00
marc audy
e330959f2a
Fix bad merge
...
#rnx
[CL 24906562 by marc audy in ue5-main branch]
2023-04-03 23:32:48 -04:00
buzz burrowes
93831837d9
Namespace the names of the multicast delegate definitions (move them into the class definition) to avoid polluting the global namespace.
...
[REVIEW] [at]phil.popp [at]charlie.huguenard
#preflight 642b2a92ce01db47acc4bf9b
[CL 24906544 by buzz burrowes in ue5-main branch]
2023-04-03 23:31:26 -04:00
marc audy
4cbcbd309d
Add delegates for when the MusicClockComponent connects and disconnects from an underling MidiClock in the associated metasound.
...
[REVIEW] [at]kevin.cavanaugh [at]aaron.mcleran [at]max.hayes
#preflight 642b13501d19c0312a597334
[CL 24906530 by marc audy in ue5-main branch]
2023-04-03 23:30:36 -04:00
charlie huguenard
2284ad7dbf
[Metasound] Avoid dangling pointer in output watcher handler
...
#rnx
[REVIEW] [at]matthew.booth [at]phil.popp [at]rob.gay
#rb matthew.booth, phil.popp
#preflight 6425a92c472a24e570226588
[CL 24867848 by charlie huguenard in ue5-main branch]
2023-03-31 02:40:41 -04:00
rob gay
3d1359e314
- Fix crash when attempting to add invalid MetaSound node classes (due to them being transient assets) to a given MetaSound in its respective asset Editor.
...
- Remove temporary gating cvar for MetaSound builder subsystem
[FYI] sondra.moyls
[FYI] Kevin.Cavanaugh
#rb trivial
#rnx
#preflight 641e14eeb72410fc17be4b39
[CL 24791409 by rob gay in ue5-main branch]
2023-03-24 20:45:20 -04:00
kevin cavanaugh
e5368194e8
Metasound bug fixes discovered while using the output subsystem
...
#rb buzz.burrowes
#preflight 641c69e0b72410fc1716c064
[CL 24766915 by kevin cavanaugh in ue5-main branch]
2023-03-23 15:44:04 -04:00
rob gay
6e2c09045d
- Fix for builder subsystem not able to reuse audition sound properly due to the sound not being unregistered from the MetaSound Frontend Class Registry before mutation and attempt to play/re-register. Default to register when building and don't expose option to BP (referencing unregistered assets can lead to silent failures when attempting playback later)
...
- Fix for const correctness causing BP functions to not provide execution path even though they're set to BlueprintCallable :(
#rb helen.yang
[FYI] seth.weedin
[FYI] kevin.cavanaugh
#preflight 641c767fa86ae7cbccd64bb9
[CL 24765400 by rob gay in ue5-main branch]
2023-03-23 14:04:36 -04:00
charlie huguenard
3c8efcca93
[Metasound] Blueprint access to watch outputs on a playing Metasound source
...
#rb ryan.mangin, rob.gay, phil.popp
#preflight 6418bfb2691c5ebc15931d3e
[CL 24731517 by charlie huguenard in ue5-main branch]
2023-03-21 10:01:25 -04:00
buzz burrowes
fb48d94232
MusicClockComponent & MusicTempometerComponent for the new Harmonix plugin. Includes massive refactor for Measure -> Bar and Pulse -> Beat.
...
[REVIEW] [at]nicholas.howe [at]jake.burga
#preflight 6418998932723d4a20488334
[CL 24724583 by buzz burrowes in ue5-main branch]
2023-03-20 17:38:24 -04:00
charlie huguenard
4fdfbdf806
[Metasound] Watch outputs on a FMetasoundGenerator
...
#rb rob.gay, phil.popp
#preflight 6414cabd345ab08524fc9542
[CL 24723801 by charlie huguenard in ue5-main branch]
2023-03-20 17:13:25 -04:00
kevin cavanaugh
73b2ff9677
Force the metasound builder audition to create a new sound each time
...
#rb rob.gay
#preflight 6412404abf53fdee19aeb907
[CL 24673829 by kevin cavanaugh in ue5-main branch]
2023-03-16 13:03:16 -04:00
rob gay
cff304e9da
Interface Registry Tidying
...
1.) Move Bindings to own registry
2.) Nuke source files & left over cruft relating to archetypes
3.) Move deprecated interface registration next to respective interfaces for clarity
4.) Rename "FMetasoundFrontendInterfaceBindingConnections" to "FMetasoundFrontendInterfaceVertexBindings"
#rb phil.popp
#preflight 640f6852d778f889752a5bd1
[CL 24622079 by rob gay in ue5-main branch]
2023-03-13 17:23:05 -04:00
rob gay
0214d1c465
- Fix crash w/PostInitProperties initialization of MetaSoundDocumentBuilder
...
- Fix bugs with interfaces not registering with the correct UClass types
- Add missing RemoveByInterfaceBinding MS Builder function
- Builder cache fix for ContainsEdge
#rb trivial
#rnx
#preflight 640a34153c2db40029343bab
[CL 24584406 by rob gay in ue5-main branch]
2023-03-09 17:56:53 -05:00
seth weedin
381ed316ce
MetaSound WavePlayer node: Immediately fire OnFinished if WaveAsset passed in is None
...
#jira UE-179663
#rb Phil.Popp
[CL 24583389 by seth weedin in ue5-main branch]
2023-03-09 17:08:55 -05:00
rob gay
aeb25bb49d
- Add Runtime MetaSound Builder support
...
- Add MetaSound Patch Interface support
- Add MetaSound Interface Bindings
#rb phil.popp
#preflight 640783bd5515f4f57b4b1268
[FYI] Sondra.Moyls
[FYI] Dan.Reynolds
[CL 24548617 by rob gay in ue5-main branch]
2023-03-07 17:01:52 -05:00
Joe Kirchoff
109addf6a3
Cpp20 doesn't allow implicit capture of 'this' via '[=]'
...
#rb Francis.Hurteau
#preflight 64068c936e1dadfcda41bb82
[CL 24548358 by Joe Kirchoff in ue5-main branch]
2023-03-07 16:49:18 -05:00
