Rob Gay
49c739169c
Fix class references misguided towards transient MetaSound class instead of MetaSound Builder class causing failures to add/remove interfaces in certain contexts
...
#rb phil.popp
#jira UE-181360
#preflight 642f15426d46f6b1bfac1f59
#rnx
[CL 24955760 by Rob Gay in ue5-main branch]
2023-04-06 16:32:00 -04:00
rob gay
1de499ef8e
More MetaSound Interface registry clean-up
...
- Move bIsDefault/bCanEdit(renamed bIsModifiable) from InterfaceRegistryEntry to Interface data definition
- Add checks in builder to disallow mutation of interfaces that shouldn't be via editor or document builder (ex. SourceInterface which is default and then never changed)
- Optimize SearchEngine query for finding default interfaces
- Tweak MetaSoundUObjectRegistry to support non MetasoundAssetBase classes and add UMetaSoundBuilderDocument. Update iterator w/optional param to only return asset types (true by default for back compat)
- Move FName class name comparitors to use new TopLevelAssetPath
#rb phil.popp
#jira UE-181360
#rnx
#p4v-preflight-copy 24658328
#preflight 642b10834d26bcd1eb0e566c
[CL 24920763 by rob gay in ue5-main branch]
2023-04-04 19:14:26 -04:00
rob gay
3d1359e314
- Fix crash when attempting to add invalid MetaSound node classes (due to them being transient assets) to a given MetaSound in its respective asset Editor.
...
- Remove temporary gating cvar for MetaSound builder subsystem
[FYI] sondra.moyls
[FYI] Kevin.Cavanaugh
#rb trivial
#rnx
#preflight 641e14eeb72410fc17be4b39
[CL 24791409 by rob gay in ue5-main branch]
2023-03-24 20:45:20 -04:00
rob gay
6e2c09045d
- Fix for builder subsystem not able to reuse audition sound properly due to the sound not being unregistered from the MetaSound Frontend Class Registry before mutation and attempt to play/re-register. Default to register when building and don't expose option to BP (referencing unregistered assets can lead to silent failures when attempting playback later)
...
- Fix for const correctness causing BP functions to not provide execution path even though they're set to BlueprintCallable :(
#rb helen.yang
[FYI] seth.weedin
[FYI] kevin.cavanaugh
#preflight 641c767fa86ae7cbccd64bb9
[CL 24765400 by rob gay in ue5-main branch]
2023-03-23 14:04:36 -04:00
phil popp
03083332fe
Add render timing feedback to metasound editor.
...
#preflight 6411ed27af3fc35292890610
[CL 24658951 by phil popp in ue5-main branch]
2023-03-15 14:22:41 -04:00
rob gay
cff304e9da
Interface Registry Tidying
...
1.) Move Bindings to own registry
2.) Nuke source files & left over cruft relating to archetypes
3.) Move deprecated interface registration next to respective interfaces for clarity
4.) Rename "FMetasoundFrontendInterfaceBindingConnections" to "FMetasoundFrontendInterfaceVertexBindings"
#rb phil.popp
#preflight 640f6852d778f889752a5bd1
[CL 24622079 by rob gay in ue5-main branch]
2023-03-13 17:23:05 -04:00
helen yang
281a6f7fb3
Fix ensure when creating variables on a MetaSound graph that has been converted from preset
...
#jira UE-179044
#rb rob.gay
#preflight 6406736d3206d45d2039b8ab
[CL 24564460 by helen yang in ue5-main branch]
2023-03-08 14:25:19 -05:00
rob gay
852b21ebf6
Fix missing LOCTEXT undef
...
#rb trivial
#preflight skip
[CL 24554499 by rob gay in ue5-main branch]
2023-03-07 22:39:32 -05:00
rob gay
aeb25bb49d
- Add Runtime MetaSound Builder support
...
- Add MetaSound Patch Interface support
- Add MetaSound Interface Bindings
#rb phil.popp
#preflight 640783bd5515f4f57b4b1268
[FYI] Sondra.Moyls
[FYI] Dan.Reynolds
[CL 24548617 by rob gay in ue5-main branch]
2023-03-07 17:01:52 -05:00
Patrick Boutot
6a2863234b
Deprecate arrays from SColorPicker. Memstomp was fixed with 23672712. This CL removed the posibility of creating a new memstomp
...
#jira UE-173303
#rb daren.cheng
#preflight 63c6034bd040694ab82f3970
[CL 23736262 by Patrick Boutot in ue5-main branch]
2023-01-17 07:24:54 -05:00
Patrick Boutot
6e02de5817
Fix memstomp with color picker. Prepare SColorPicker for API change. Update AssetViewUtilis::PathColors to use FLinearColor instead of shared pointer. The shared pointer was only needed for the SColorPicker.
...
#jira UE-173303, UE-173454
#review-23672715 23617361,23611673
#rb daren.cheng
#preflight 63c0b12b1a06fc61059f2fa3
[CL 23672712 by Patrick Boutot in ue5-main branch]
2023-01-12 20:33:08 -05:00
rob gay
08872e5e4c
[MetaSounds] - Inputs, Outputs, and Variables are not allowing spaces in the member name
...
#jira UE-168508
#rb helen.yang
#preflight 63b5c005ab0e99a2bed1567c
[CL 23631786 by rob gay in ue5-main branch]
2023-01-10 15:21:29 -05:00
helen yang
15a6a6c55a
Fix MetaSound vertex sort order and description being reset when changing data type or constructor pin state
...
#rb alfaroh.corneyiii
#jira UE-172230
#preflight 63b697f3202bee5e2764a922
[CL 23601258 by helen yang in ue5-main branch]
2023-01-06 14:24:44 -05:00
helen yang
bf1494589c
Fix double clicking on a MetaSound input node causing inputs to be reset to default, remove false positive warning, typo fixes
...
#jira UE-170321
#rb rob.gay
#preflight 6385122cfa348e84808d3ca7
#rnx
[CL 23580133 by helen yang in ue5-main branch]
2023-01-04 15:45:18 -05:00
helen yang
302198f069
Fix MetaSound constructor pin icon not appearing properly for enum types
...
#jira UE-169684
#rb rob.gay
#preflight 638471967b4bd3f057f13360
[CL 23580129 by helen yang in ue5-main branch]
2023-01-04 15:45:14 -05:00
buzz burrowes
6a343186d8
MetasoundParameterPack V1
...
[REVIEW] [at]phil.popp [at]rob.gay [at]aaron.mcleran
#preflight 639b5db4012902cb8d76c448
[CL 23532613 by buzz burrowes in ue5-main branch]
2022-12-15 17:03:02 -05:00
alfaroh corneyiii
32f81a5ed2
Expose IMetasoundEditor interface
...
#jira UE-167394
#rb aaron.mcleran
#preflight 638664154004f73f62e19049
#9674
[CL 23316042 by alfaroh corneyiii in ue5-main branch]
2022-11-29 15:14:08 -05:00
henrik karlsson
b5164ac775
Fixes to make modules compile with IWYU. We've added to IWYU toolchain so it compiles "orphaned" headers which does not have a owning cpp file. This identified lots of headers that couldn't be compiled by themselves (or if they were to included first)
...
Change consist of only forward declaration and additional includes
#preflight 63789c1de30d438849c48188
#rb none
[CL 23218412 by henrik karlsson in ue5-main branch]
2022-11-21 03:22:23 -05:00
Rob Gay
25d3c6e253
Audio Dashboard Implementation Checkpoint
...
#rb helen.yang
#jira UE-168953
#preflight 636d4990a430c8fbeab100a3
[CL 23085100 by Rob Gay in ue5-main branch]
2022-11-10 14:15:27 -05:00
henrik karlsson
4a5e13525d
Fixed non-unity non-pch compile errors
...
#preflight skipped
#rb none
[CL 22788359 by henrik karlsson in ue5-main branch]
2022-10-26 16:22:34 -04:00
rob gay
9548b0ee1a
[MetaSounds] Fix for ensure when naming an input with "/". Forbid use of analyzer '/' in MetaSound member names & don't bloat FName table with attempted renamed members
...
#rb helen.yang
#jira UE-168051
#preflight
[CL 22786989 by rob gay in ue5-main branch]
2022-10-26 15:28:20 -04:00
rob gay
18e887e937
[MetaSounds] Fix/add missing new MetaSound type icons/thumbnails as well as play/stop overlays. Support for showing/filtering presets in ContentBrowser
...
#rb helen.yang julien.stjean
[REVIEW] helen.yang
#jira UE-168050
#preflight 635314707261e565c497645f
[CL 22786984 by rob gay in ue5-main branch]
2022-10-26 15:28:04 -04:00
henrik karlsson
b5b86c796c
This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
...
#preflight 6355d4940313c24974b2107b
#rb none
[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
helen yang
614fa56c85
Fix MetaSound input widget value not matching actual default value
...
#jira UE-168040
#rb rob.gay
#preflight 635547b40313c2497498ae78
#rnx
[CL 22779973 by helen yang in ue5-main branch]
2022-10-26 10:53:25 -04:00
helen yang
720fde6bdb
Fix MetaSound edited graph member not selected after undo/redo
...
#jira UE-168037
#rb rob.gay
#preflight 63547ad73a547c3da3ce6cdd
#rnx
[CL 22779966 by helen yang in ue5-main branch]
2022-10-26 10:53:20 -04:00