mark lintott
fe1ee99e15
Fix for DDC and Cook analytics event attributes not being transmitted as numbers to the backend. This allows us to correctly aggregate DDC/Cook values in Grafana.
...
[FYI] Devin.Doucette, Garry.Casey, Erik.Knapik
#rb trivial
#preflight 63fdf46fef1b24bf940111c1
[CL 24446536 by mark lintott in ue5-main branch]
2023-02-28 13:24:40 -05:00
devin doucette
d802756cf3
DDC: Added logging if legacy requests fail to copy the buffer
...
Includes a speculative workaround for check(Data.Num()) failing.
#rb Matt.Peters
#rnx
[CL 24412735 by devin doucette in ue5-main branch]
2023-02-24 19:01:05 -05:00
devin doucette
ee3c2bc2fd
DDC: Initialized bGetResult in case the callback is somehow missed
...
#rb none
[CL 24408000 by devin doucette in ue5-main branch]
2023-02-24 15:48:03 -05:00
mark lintott
7126d3c2ed
Split up the DDC cache analytics per back end so we can more easily reason about specific abck end perf
...
#rb zousar.shaker, devin.doucette
#preflight 63da8e557a39a18021722350
[CL 23984212 by mark lintott in ue5-main branch]
2023-02-02 18:47:48 -05:00
mark lintott
72bf7a2d8c
Fixed the Cloud, Local and Shared Percentages that exceed 100% when more than one backend is used. These were flawed, Root Get/Hit count cannot be used for the percentages for each backend in this way.
...
#rb devin.doucette
#preflight 63c93722ac35a0e9da754473
[CL 23773901 by mark lintott in ue5-main branch]
2023-01-19 10:45:32 -05:00
mark lintott
8bad2c0365
Removed the callback system from core Analytics system. Fixed up analytics gathering in DerivedDataCache, Virtualization and HttpCacheStore
...
#rb wes.hunt
#preflight 63be95bd68068a8bd6a4438e
[CL 23651011 by mark lintott in ue5-main branch]
2023-01-11 14:28:01 -05:00
matt peters
71802fb86c
Analytics: Backed out 22909100 and 22951911
...
#rnx
[CL 23583550 by matt peters in ue5-main branch]
2023-01-04 18:51:41 -05:00
Zousar Shaker
b9548ddad4
Move Zen module public headers into an "Experimental" subfolder to have them reflect the feature status.
...
Fix locations that include the headers to use the "Experimental" subfolder and re-sort includes. No functional change, purely a move, search+replace, and sort of includes.
#rb matt.peters
#preflight 63939eebc415e8dc78d35d63
[CL 23468934 by Zousar Shaker in ue5-main branch]
2022-12-09 16:11:41 -05:00
Devin Doucette
110afa128b
DDC: Added new build scheduler modular features to queue by type and reserve memory
...
#preflight 638128f3cc307d6fa5b4ee80
#rb Zousar.Shaker
[CL 23271781 by Devin Doucette in ue5-main branch]
2022-11-25 21:38:59 -05:00
Devin Doucette
e2483014be
DDC: Added LaunchTaskInThreadPool as a replacement for the two existing thread pool task requests
...
#preflight 6380f7c4170bc34a93b9104b
#rb Zousar.Shaker
[CL 23267593 by Devin Doucette in ue5-main branch]
2022-11-25 12:35:29 -05:00
Devin Doucette
f1d54c3a16
DDC: Sorted and removed duplicate includes in DerivedDataCache.cpp
...
#preflight 63627f0254471d10bef32ed7
#rb none
#rnx
[CL 22918352 by Devin Doucette in ue5-main branch]
2022-11-02 11:58:13 -04:00
mark lintott
490070be3c
Decoupled Zen, DerivedDataCache and Virtualization dependency from Studio Analytics. Systems can now register callbacks to append or modify Event payloads to analytics events by name via the FAnalytics interface.
...
#rb Nick.Darnell
#fyi Paul.Chipchase,Zousar.Shaker
#preflight 636248d054471d10bedc3749
[CL 22909100 by mark lintott in ue5-main branch]
2022-11-02 06:56:10 -04:00
Zousar Shaker
fee1c826d6
Update references to "Horde Storage" to "Unreal Cloud DDC" or appropriate variations.
...
Specifically:
HordeStorageServers-> StorageServers
HordeStorage -> UnrealCloudDDC
Horde Storage -> Unreal Cloud DDC
#rb matt.peters
#fyi devin.doucette
#fyi joakim.lindqvist
#jira UE-167262
#preflight 6349da9bad0f7e2f206125e3
[CL 22538004 by Zousar Shaker in ue5-main branch]
2022-10-14 18:39:39 -04:00
Devin Doucette
e0a0961a5d
DDC: Used InheritedContext to implement the reverted inheritance of memory tags
...
#preflight 633c89b70e66c104f1cdc505
#rb Andriy.Tylychko, Zousar.Shaker
#rnx
[CL 22353683 by Devin Doucette in ue5-main branch]
2022-10-05 09:23:53 -04:00
Andriy Tylychko
ab5a1abe8d
InheritedContext
...
grouped inherited LLM tag, mem tag and trace metadata into FInheritedContext to simplify their usage, avoid forgetting using all of them together, and to hide the ugly conditional compilation. Added FInheritedContext to higher level tasks instead of the low-level tasks to allow batch task launch to capture the inherited context once per batch
#rb ionut.matasaru
#preflight 633c47792f4bf32d31687192
[CL 22331272 by Andriy Tylychko in ue5-main branch]
2022-10-04 11:22:08 -04:00
Devin Doucette
78b4dfd59b
DDC: Fixed untagged allocations by capturing tags in tasks
...
#jira UE-154013
#preflight 6335f0ffc37844870abec3f3
#rb Matt.Peters
[CL 22254430 by Devin Doucette in ue5-main branch]
2022-09-29 16:11:35 -04:00
Devin Doucette
6c0a4f9cc8
DDC: Added a check for non-zero size in the legacy cache
...
#jira UE-160573
#preflight 632dd4517b582f58abb80f63
#rb Zousar.Shaker
#rnx
[CL 22157364 by Devin Doucette in ue5-main branch]
2022-09-23 13:12:14 -04:00
Devin Doucette
7f98c7fe6c
DDC: Added functions to convert between derived data priority and queued work priority
...
#preflight 632b42d4b4515b7e226ffae8
#rb Zousar.Shaker
#rnx
[CL 22118431 by Devin Doucette in ue5-main branch]
2022-09-21 14:25:32 -04:00
Joe Kirchoff
6e545d7633
Fix vs2022 compile errors when /Zc:lambda- is removed
...
#rnx
#rb trivial
#preflight 62fc24382d5e2ed99cdbbc84
[CL 21417071 by Joe Kirchoff in ue5-main branch]
2022-08-16 19:23:33 -04:00
devin doucette
6366a19bda
DDC: Added functions to serialize cache types to and from compact binary, and strings where appropriate
...
#rb Zousar.Shaker
#ROBOMERGE-OWNER: devin.doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-SOURCE: CL 20741868 via CL 20744192 via CL 20745275
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v970-20704180)
[CL 20751385 by devin doucette in ue5-main branch]
2022-06-20 23:40:01 -04:00
mark lintott
da46ade47c
Added Cache Speed Stats to Analytics
...
Added Zen Server Stats to Analytics
#rb zousar.shaker, devin.doucette
#jira none
#preflight 6295d84bd57da28cc8ee9eab
[CL 20434901 by mark lintott in ue5-main branch]
2022-05-31 05:11:05 -04:00
danny couture
623896568d
Improve frame rate stability in editor by reducing the priority of the DDC IO threads which are now doing CPU intensive compression to avoid them preempting more important threads (GT/RT/RHI)
...
#rnx
#rb Devin.Doucette
#preflight 62825177cf7e4667a991a6cc
[CL 20223281 by danny couture in ue5-main branch]
2022-05-16 09:52:19 -04:00
Devin Doucette
436b6a6461
DDC: Added IRequestOwner::LaunchTask
...
- Added IRequestOwner::LaunchTask to launch a task as a request in the request owner.
- Renamed ExecuteInCacheThreadPool to LaunchTaskInCacheThreadPool.
- Made GCacheThreadPool private to one source file.
- Changed task scheduling throughout DDC to use these functions where appropriate.
#preflight 623b846d8900c14eecd4daa4
#rb Zousar.Shaker
[CL 19485686 by Devin Doucette in ue5-main branch]
2022-03-23 16:56:39 -04:00
Devin Doucette
d8c983bbe6
DDC: Optimized legacy cache key validation and shortening overhead
...
- Validate and shorten legacy keys lazily.
- Change to ValueOnly mode for PakFile and Zen.
#preflight 623235998a6037989395baf2
#rb Zousar.Shaker
#rnx
[CL 19410386 by Devin Doucette in ue5-main branch]
2022-03-16 15:28:29 -04:00
devin doucette
a2fba58903
DDC: Destroy the cache store graph when shutting down the cache
...
#jira UE-116166
#preflight 620ea11c7509be98435db253
#lockdown Aurel.Cordonnier
#rb Zousar.Shaker
#ROBOMERGE-OWNER: Devin.Doucette
#ROBOMERGE-AUTHOR: devin.doucette
#ROBOMERGE-COMMAND: _robomerge UE5-Main
#ROBOMERGE-SOURCE: CL 19092848 in //UE5/Release-5.0/... via CL 19096129
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)
[CL 19096234 by devin doucette in ue5-main branch]
2022-02-23 13:47:00 -05:00
