Commit Graph

196 Commits

Author SHA1 Message Date
rob gay
fd33c39c6e - Drag/Drop/Double-Click Add/JumpTo Member Support
- Fix another spot for when member is removed from the editor views on next tick, don't show garbage member in details panel
- Variable node body fix-ups
#rb helen.yang
#rnx
#jira UE-143288
#preflight 62102b6a406b34de07e846ae

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19082391 in //UE5/Release-5.0/... via CL 19097086
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19140792 by rob gay in ue5-main branch]
2022-02-24 23:29:50 -05:00
rob gay
69fb1d5b9c Fix for regression with undo/redo when adding/removing MetaSound Graph Members causing the interface list or details panel to go stale
#rb helen.yang
#rnx
#jira UE-142724
#preflight 620c2d84483ff0ae5ecbd5ac

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19082285 in //UE5/Release-5.0/... via CL 19097068
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19140752 by rob gay in ue5-main branch]
2022-02-24 23:28:20 -05:00
rob gay
0490a40d91 Fix for deleting a pasted variable node deleting all instances of that node on the graph
- Also fixes pasting a variable member from another graph or pasting a variable accessor/delayed accessor from ensuring if no other accessor exists
#rb helen.yang
#rnx
#jira UE-142410
#preflight 620adc00803d9066e6902811
#lockdown nick.whiting

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19058501 in //UE5/Release-5.0/... via CL 19074246
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19076464 by rob gay in ue5-main branch]
2022-02-22 13:47:20 -05:00
rob gay
5ba27517d3 Add missing 'BreakSinglePinLink' implementation for MetaSounds
#rb helen.yang
#jira UE-142560
#preflight 620ab0df4d320dbf4c2311e8
#lockdown nick.whiting

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19058418 in //UE5/Release-5.0/... via CL 19074107
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v921-19075845)

[CL 19076400 by rob gay in ue5-main branch]
2022-02-22 13:45:05 -05:00
rob gay
4ffce9e549 MetaSound Member localization options menu support for DisplayName & Tooltip
[REVIEW] helen.yang
#jira UE-142556
#preflight 620acc9d4d320dbf4c29ac0e
#lockdown nick.whiting

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19058366 in //UE5/Release-5.0/... via CL 19066031
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19067166 by rob gay in ue5-main branch]
2022-02-21 03:09:54 -05:00
rob gay
066f2f8c47 (Re)Fix for renaming a MetaSound not propagating the rename to referencing graphs
#rnx
#rb helen.yang
#jira UE-137696
#preflight 620b3a96483ff0ae5ea63369
#lockdown nich.whiting

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 19058267 in //UE5/Release-5.0/... via CL 19066028
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v918-19018356)

[CL 19067158 by rob gay in ue5-main branch]
2022-02-21 03:09:25 -05:00
helen yang
0c14af3503 Various fixes for MetaSound meter functionality
- Add nullptr check when setting bus sends
- Initialize audio analyzer number of frames
- Remove analyzers when tearing down MetaSound audio meter

#jira UE-140872
#rb rob.gay
#preflight 620a9d8f4a08181f72a47f28

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18986455 in //UE5/Release-5.0/... via CL 18986877 via CL 18987819
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18988135 by helen yang in ue5-main branch]
2022-02-14 18:35:49 -05:00
rob gay
f4d6d39ff5 Fix for Undoing/Redoing change to a MetaSound not propagating to other referencing MetaSounds.
#rb phil.popp
#rnx
#jira UE-137481
#preflight 6205f4cc69224cb0d8912fd7

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18983245 in //UE5/Release-5.0/... via CL 18983457 via CL 18983733
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18983749 by rob gay in ue5-main branch]
2022-02-14 14:25:01 -05:00
phil popp
5c65d66c75 Fix crash when creating preset with incompatible literal
#jira UE-142367
#rnx
#rb rob.gay
#preflight 6206ddb3054c2e38c473d1e7

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18983235 in //UE5/Release-5.0/... via CL 18983409 via CL 18983631
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18983673 by phil popp in ue5-main branch]
2022-02-14 14:21:13 -05:00
helen yang
f4a9338223 Add Audio Editor Settings options to pin various asset types
- Move MetaSounds editor settings to Content Editor Category, remove unused settings

#jira UE-141203
#rb rob.gay
#preflight 620584c84c6c33118fb20d7e

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18945154 in //UE5/Release-5.0/... via CL 18946204 via CL 18946520
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18946535 by helen yang in ue5-main branch]
2022-02-10 18:45:19 -05:00
rob gay
a2a0500c01 Don't copy filename to displayname by default when creating a MetaSound
#rb helen.yang
#jira UE-137696
#rnx
#preflight 62054bf7057375a802915dce

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18941184 in //UE5/Release-5.0/... via CL 18941652 via CL 18941907
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18941928 by rob gay in ue5-main branch]
2022-02-10 15:23:43 -05:00
rob gay
45e4645008 Compile out editor-only data from MetaSoundFrontend
- Move Author field to FString to avoid generated text collisions (Authors should always be culture invariant anyway) & add option to override default in MetaSound user settings
#rb helen.yang
#jira UE-142159
#preflight 62055c89057375a802938669

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18941073 in //UE5/Release-5.0/... via CL 18941268 via CL 18941634
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18941665 by rob gay in ue5-main branch]
2022-02-10 15:07:39 -05:00
rob gay
b72277e177 - Fix for superfluous adding a default literal set to false to copied triggers which causes a generated duplicate input when building the core graph if input is connected
- Fix for errors/displaying trigger simulate on output/variable nodes
#rb phil.popp
#jira UE-135832
#rnx
#preflight 6204b4b8a8129f65b74f31ea

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18939803 in //UE5/Release-5.0/... via CL 18939905 via CL 18939998
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v917-18934589)

[CL 18940014 by rob gay in ue5-main branch]
2022-02-10 13:42:12 -05:00
rob gay
6c69365c1f - Fix & re-enable manual update of node class if auto-update is disabled or node class is updated and original class is missing
- Fix updating default value for a graph input not compositionally propagating to references
- Fix 'Reset to Class Default' sometimes showing when it isn't applicable (ex. on triggers or when the class default is out-of-date)
#rb phil.popp
#rnx
#jira UE-135832, UE-138819
#preflight 6204113ad619b08d92f542f4

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18922577 in //UE5/Release-5.0/... via CL 18927066 via CL 18928800
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18929238 by rob gay in ue5-main branch]
2022-02-09 19:27:40 -05:00
rob gay
8279d931a3 Fix for multiple composition nodes referencing same class failing to auto-update properly due to additional class definition added and then immediately removed when it should be updating the pre-existing entry.
- Fix node display title being 'none' when you initially add an externally-defined class
#rnx
#rb phil.popp
#jira UE-140929
#jira UE-136242
#preflight 6202f7fbc451a5d0dc0d9675

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18912572 in //UE5/Release-5.0/... via CL 18919479 via CL 18920616
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18921427 by rob gay in ue5-main branch]
2022-02-09 13:22:21 -05:00
rob gay
6d4096c2af - Reduce MetaSounds loaded on Editor startup by moving additional MetaSound loads/registration to occur when MetaSoundEditor is loaded
- Add UX to communicate on first asset editor load that MetaSounds are still loading and class picker results may be incomplete
#rb phil.popp
#jira UE-134364
#rnx
#preflight 6202b588bf28c072cbf2faeb

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18911432 in //UE5/Release-5.0/... via CL 18919339 via CL 18920527
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18920775 by rob gay in ue5-main branch]
2022-02-09 12:52:44 -05:00
rob gay
f2973c965f - Fix propagation issues with Preset input defaults
- Add UX for overriding preset inputs (allowing auto-update to pass through referenced value if not managed)
- Clarify code by moving bAutoUpdateManagestInterface to bIsPreset in new FMetasoundFrontendGraphClassPresetOptions struct
#rb phil.popp
#jira UE-136242
#preflight 6202b1bfae203853a85c6366
#rnx

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18911247 in //UE5/Release-5.0/... via CL 18919315 via CL 18920513
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v916-18915374)

[CL 18920762 by rob gay in ue5-main branch]
2022-02-09 12:52:07 -05:00
aaron mcleran
f4fca67476 Fixing duplicate loc keys in audio
#jira UE-141419
#rb Rob.Gay
#preflight 61fd68d2a6165e53567bb1ed
#lockdown Cristina.Riveron

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18868877 in //UE5/Release-5.0/... via CL 18868922 via CL 18869617
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18869700 by aaron mcleran in ue5-main branch]
2022-02-04 14:18:45 -05:00
helen yang
041381e5b1 Move MetaSound asset type into the new MetaSounds asset submenu
#jira UE-140764
#rb miles.flanagan, aaron.mcleran
#preflight 61f9ad664b0bc1c41767fc65
#rnx

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18817588 in //UE5/Release-5.0/... via CL 18817656 via CL 18822863
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v910-18824042)

[CL 18824694 by helen yang in ue5-main branch]
2022-02-02 07:58:10 -05:00
rob gay
6887608d07 - Version MetaSound asset graph name FText being generated from file name & copied to MetaSound asset.
- Add missing user-defined fields to MetaSound graph options (ex. IsDeprecated, Keywords, etc.) and force update on transient style changeID (TODO: Probably would make more sense for Metadata FText to live on style struct and share that transient ChangeID, so that non-runtime changes to FText metadata wouldn't bump the change ID)
[CODEREVIEW] helen.yang
#jira UE-137696
#rnx
#preflight 61f870c0a6632a34f35e5e3c

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18805501 in //UE5/Release-5.0/... via CL 18807964 via CL 18821755
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822116 by rob gay in ue5-main branch]
2022-02-02 02:19:16 -05:00
rob gay
820b8558a0 Fix for ensure hit when calling CreateInternalWidgets prior to synchronizing graph for some MetaSounds assets (subsequent CL had deeper fix that avoided calling refresh on nodes prematurally, so the incorrect expectation that widgets had to be generated prior to synchronization no longer holds). This is a partial revert from previous CL.
#rb trivial
#jira none
#rnx
#preflight 61f84dab41414fb013d9fdcb

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18797129 in //UE5/Release-5.0/... via CL 18797912 via CL 18799114
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18799233 by rob gay in ue5-main branch]
2022-01-31 17:23:45 -05:00
rob gay
5452cd8168 MetaSound Composition Fixes
- Removed need for marking ed graph nodes for refresh in most places in favor of using frontend class metadata/interface guids to signify an ed node requiring a refresh
- Update CanAutoUpdate to always provide interface changes if the metadata/interface guids change and return true, even if the runtime properties do not report
 changes, so the editor can adequately update referenced classes that have only asthetic updates
#rb helen.yang
#jira UE-136242
#jira UE-137696
#rnx
#preflight 61f8343168795b2f45820e03

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18794812 in //UE5/Release-5.0/... via CL 18795366 via CL 18796340
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18796687 by rob gay in ue5-main branch]
2022-01-31 15:53:54 -05:00
helen yang
ecb71d0c8a Retain all connections when control + click dragging multiple connections to another MetaSound node
#jira UE-116874
#rb rob.gay
#preflight 61f332ca6b5aea38e59db068

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18794786 in //UE5/Release-5.0/... via CL 18795351 via CL 18796329
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18796678 by helen yang in ue5-main branch]
2022-01-31 15:53:33 -05:00
rob gay
f71016bbac Fix for deleting copied inputs causing them to sneak back into graph
#rb trivial
#jira UE-137490
[FYI] sondra.moyls
#rnx
#preflight skip

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18792566 in //UE5/Release-5.0/... via CL 18792616 via CL 18793509
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18793833 by rob gay in ue5-main branch]
2022-01-31 13:57:52 -05:00
phil popp
3e2e304b2d Fix for invalid proxy generate classes showing up on metasound node drop downs.
#jira UE-135719
#rb trivial
#preflight skip

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18774345 in //UE5/Release-5.0/... via CL 18774355 via CL 18775372
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18775443 by phil popp in ue5-main branch]
2022-01-28 13:50:28 -05:00