sara schvartzman
7110ae279a
Control Rig: Fix crash when resolving template to different type by adding a link
...
#jira UE-164986
#rb benoit.gadreau
#preflight 632f3349a4769ad71440d862
[CL 22188297 by sara schvartzman in ue5-main branch]
2022-09-26 13:20:38 -04:00
bryan sefcik
0beee50b45
Updated ../Engine/Source/Developer/... to inline gen.cpp files
...
Before:
Total CPU Time: 53783.640625 s
Total time in Parallel executor: 558.66 seconds
After:
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds
#jira
[CL 22173145 by bryan sefcik in ue5-main branch]
2022-09-24 13:31:25 -04:00
sara schvartzman
a41c9937d6
Control Rig: Fix add link between array and element of Select values does not resolve select pin correctly
...
#jira UE-164187
#rb jack.cai
#preflight 632c656cd747fe52c84bf0c4
[CL 22163592 by sara schvartzman in ue5-main branch]
2022-09-23 20:01:01 -04:00
sara schvartzman
68a76b92b9
Control Rig: Do not allow IO exposed pin type change to something other than execute context
...
#jira UE-164557
#rb jack.cai
#preflight 632b1aa4fc7f1efbdf9702d8
[CL 22119028 by sara schvartzman in ue5-main branch]
2022-09-21 14:42:45 -04:00
sara schvartzman
ee2557c67a
Control Rig: Fix crash when connecting subpin from entry node to cast, and resolving type of cast output
...
#jira UE-164603
#rb benoit.gadreau
[FYI] jack.cai
#preflight 632af57aa236a029de206f71
[CL 22114002 by sara schvartzman in ue5-main branch]
2022-09-21 11:36:56 -04:00
sara schvartzman
809dbae76c
Control Rig: Fix crash when copy-pasting function with nested functions from one engine to another
...
#jira UE-163967
#rb benoit.gadreau
#preflight 632afca0826e0c2fe99f3961
[CL 22113997 by sara schvartzman in ue5-main branch]
2022-09-21 11:36:47 -04:00
jack cai
c0eef12309
ControlRig: fix graphguard not considering CancelAction. If an action was cancelled, guard would no longer need to pop graph in dtor
...
+ also we should register the pin type
#jira UE-161145
#rb Sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/6321ffa88c478acecfc24acf
[CL 22066642 by jack cai in ue5-main branch]
2022-09-17 01:49:42 -04:00
jack cai
fedab8a7cd
controlrig: fix a place that was using GetStructCPPName, for control rig it should use GetUniqueStructTypeName
...
#rb Sara.schavartzman
#preflight tbd
[CL 22039967 by jack cai in ue5-main branch]
2022-09-15 18:08:49 -04:00
bob tellez
09bdded204
[Backout] - CL22010359
...
[FYI] jack.cai
Original CL Desc
-----------------------------------------------------------------
ControlRig: fix graphguard not considering CancelAction. If an action was cancelled, guard would no longer need to pop graph in dtor
+ also we should register the pin type
#jira UE-161145
#rb Sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/6321ffa88c478acecfc24acf
[CL 22030347 by bob tellez in ue5-main branch]
2022-09-15 11:49:26 -04:00
jack cai
542718d02b
ControlRig: fix graphguard not considering CancelAction. If an action was cancelled, guard would no longer need to pop graph in dtor
...
+ also we should register the pin type
#jira UE-161145
#rb Sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/6321ffa88c478acecfc24acf
[CL 22020038 by jack cai in ue5-main branch]
2022-09-14 19:17:59 -04:00
sara schvartzman
db3913e419
Control Rig: Fix compilation issue
...
#jira na
#rb trivial
[CL 22018682 by sara schvartzman in ue5-main branch]
2022-09-14 18:23:20 -04:00
sara schvartzman
f0b0757d2e
Control Rig: Fix crash when copy pasting function
...
#jira UE-163670
#rb jack.cai
#preflight 6321fdd647741a7dbd79309b
[CL 22017641 by sara schvartzman in ue5-main branch]
2022-09-14 17:42:55 -04:00
sara schvartzman
98701593de
Control Rig: Second attempt to fix incorrect array default values when connected to reroute node#jira UE-163540
...
#rb jack.cai
#preflight 6321b7938838676d103d26e4
[CL 22004379 by sara schvartzman in ue5-main branch]
2022-09-14 07:23:59 -04:00
sara schvartzman
21b5d128f9
Control Rig: Revert fix for incorrect array default values when connected to reroute node
...
#jira UE-163540
#rb na
[CL 21989560 by sara schvartzman in ue5-main branch]
2022-09-13 15:02:02 -04:00
robert millar
0491bcc13c
FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
...
Fixups for misc developer dir files.
#jira UE-161932
#rb none
#preflight 631f8070fd6da68d68b56472
[CL 21976423 by robert millar in ue5-main branch]
2022-09-12 19:53:59 -04:00
sara schvartzman
283f87f1b7
Control Rig: Fix incorrect array default values when connected to reroute node
...
#jira UE-162826
#rb jack.cai
#preflight 631b5b15967ffc68fb21883d
[CL 21962237 by sara schvartzman in ue5-main branch]
2022-09-12 06:17:43 -04:00
sara schvartzman
da3ca1a53c
Control Rig: Improve BubbleUpExpressions performance
...
#jira UE-163088
#rb jack.cai
#preflight 6319f039a60c539c988a8c58
[CL 21908296 by sara schvartzman in ue5-main branch]
2022-09-08 20:12:09 -04:00
sara schvartzman
357a6add77
Control Rig: Fix templates with duplicate permutations
...
#jira UE-163058
#rb jack.cai
#fyi halfdan.ingvarsson
#preflight 63187e24ec45fbf3d7e8acdb
[CL 21851113 by sara schvartzman in ue5-main branch]
2022-09-07 10:55:22 -04:00
sara schvartzman
6976476990
Control Rig: Fix bad for loop
...
#jira na
#preflight 63186328ab25bb91f517947c
[CL 21845911 by sara schvartzman in ue5-main branch]
2022-09-07 05:47:44 -04:00
halfdan ingvarsson
4a3625d140
Control Rig: Temporarily only check if permutations are empty. If there are multiples, pick the first one.
...
#jira UE-163058
#fyi sara.schvartzman
#rnx
#preflight 63179eeaec45fbf3d7d16c39
[CL 21827882 by halfdan ingvarsson in ue5-main branch]
2022-09-06 16:03:23 -04:00
sara schvartzman
a1bb1a3ecb
Control Rig: Once a pin of a template node is resolved, it will add a preferred type
...
#jira UE-162227
#rb benoit.gadreau
#preflight 6317346e7b21ad1e0a144b72
[CL 21818154 by sara schvartzman in ue5-main branch]
2022-09-06 11:24:29 -04:00
sara schvartzman
46d1b28a5d
Control Rig: Fix RigVM.Graph.BindPinLibraryNode crashing in DebugMode
...
#jira UE-162969
#rb benoit.gadreau
#preflight 631602d3a20b67673beac878
[CL 21793812 by sara schvartzman in ue5-main branch]
2022-09-05 10:38:16 -04:00
sara schvartzman
719e040d65
Control Rig: Fix local variables using wrong operand in RigVM
...
#jira UE-158919
#rb benoit.gadreau, jack.cai
#preflight 63136650ec45fbf3d788aa0b
[CL 21790879 by sara schvartzman in ue5-main branch]
2022-09-05 07:45:28 -04:00
jack cai
70bc5b69f4
RigVMRegistry: Added support for user defined type addition and removal
...
Important notes:
1. We should now use TypeUtils::GetUniqueStructName instead of struct->getstructcppname for type names used by the registry since user defined struct need to have unique names generated for them
2. We should be aware that we can have invalid permutations in templates when types are deleted, so make sure you check for typeindex != INDEX_NONE when looping over permutations
#jira UE-152930
#rb Sara.schvartzman, Benoit.gadreau, Halfdan.Ingvarsson
#preflight https://horde.devtools.epicgames.com/job/6310c6992a5406d810d5a0e8
[CL 21754534 by jack cai in ue5-main branch]
2022-09-01 23:33:24 -04:00
sara schvartzman
458060c7a4
Control Rig: Fix aggregate nodes inside functions can not be pasted
...
#jira UE-162141
#rb benoit.gadreau
#preflight 630f6b5f660db81edbb7f558
[CL 21723965 by sara schvartzman in ue5-main branch]
2022-08-31 13:28:04 -04:00
