#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3363699 by Mike.Fricker
VR Editor: Improved extensibility (for mesh editor)
- This was merged from CL 3352612 and re-opened for edit before commit
- All mesh editor changes were stripped before merging
Change 3499858 by Matt.Kuhlenschmidt
PR #3673: Fixed UE-36416 (Contributed by DarkSlot)
Change 3499872 by Matt.Kuhlenschmidt
PR #3682: Details view - matrix button visibility toggle and crash fix (Contributed by kamrann)
Change 3499873 by Matt.Kuhlenschmidt
Hide property matrix button from settings editor. For the combined settings objects view this produces nonsensical results and the property matrix is for bulk editing which settings are not designed for.
Change 3501154 by Arciel.Rekman
Fix incorrect RPATH.
- Fixed LinuxToolChain to use FileItem instead of strings.
- Fixed string-based Utils.MakePathRelativeTo - workaround for an old Mono bug was causing invalid "correction" of the relative path, triggered by the fact that path "Foo/Bar/../Baz" was not considered equal to "Foo/Baz". Instead of removing the workaround altogether, added a better comparison.
Change 3501337 by Arciel.Rekman
Better fix for RPATH.
- Ben Marsh's suggestion.
Change 3502572 by Matt.Kuhlenschmidt
PR #3693: Because "becuase" is spelled because (Contributed by getnamo)
Change 3502731 by Matt.Kuhlenschmidt
Guard against empty warning toasts
#jira UE-46285
Change 3502788 by Matt.Kuhlenschmidt
Avoid shutting down the editor during loads and slow tasks if a windows close message comes in during this time
Change 3503027 by Michael.Dupuis
Optimized UpdateLayerUsageInformation
Change 3503299 by Michael.Dupuis
Fixed crash when having no layer info object
Change 3504529 by Yannick.Lange
Use UWorld instead of FWorldContext for EditorWorldExtensions, since we don't use it.
Change 3504550 by Jamie.Dale
Fixed/Improved DnD validation between Content Browsers
Dragging assets between Content Browsers now goes through the same common DnD code (DragDropHandler) as dragging assets between the SPathView and SAssetView, and between items within an SAssetView. This also improves the validation of asset/file drops to prevent you dropping assets/files into class paths.
#jira UE-45857
Change 3505369 by Alexis.Matte
Make sure undo/redo transactions works for all fbx dialog options.
#jira UE-43465
#jira UE-43569
Change 3505500 by Matt.Kuhlenschmidt
Fix child usd meshes not importing properly.
Change 3505645 by Arciel.Rekman
Add USD support on Linux (UE-45383).
#jira UE-45383
Change 3505658 by Arciel.Rekman
USD: add CMake toolchain file I missed.
Change 3506796 by Yannick.Lange
Fix EditorWorldExtensionCollection using TWeakObjectPtr for UWorlds instead of UPROPERTY
Change 3508082 by Alexis.Matte
Make sure the fbx re-import editor preference "show option dialog at reimport" is working when re-importing an animation sequence.
Change 3508855 by Max.Chen
Add CanFindInContentBrowser to AssetEditorToolkit.
False for LevelSequenceEditorToolkit so that sequencer doesn't take over Find In Content Browser and show only the sequencer asset.
#jira UE-46241
Change 3509282 by Bradut.Palas
#jira UE-45337
Removed check for Actor->GetWorld() against GWorld because the latter would switch between editor world and PIE world during a tick, causing the widget to not update properly.
Since the Actor would always point to the PIE world, the check was no longer needed.
Change 3509298 by Nick.Darnell
Slate - Now has better support for analog navigation, the NavigationConfig is now created per user, and has the ability to deal with repeats and can handle navigation better by waiting until the user has moved enough to intend a direction to move.
Change 3509313 by Bradut.Palas
#jira UE-44630
As the bug description says, the Undo History was not refreshing correctly because an undo coupled with an action would result in the same number of transactions as the previous tick. Now we also check the variation of undo actions count in order to refresh the list.
Change 3509318 by Bradut.Palas
#jira UE-1406
To fix the issue we simply close the Consolidate window if ListViewItems is empty.
Change 3509402 by Nick.Darnell
PR #3703: UE-46362: Fixing typo in EUMGSequencePlayMode.PingPong comment (Contributed by gsfreema)
Change 3510447 by Arciel.Rekman
ReplayProxy: changed protected to private.
Change 3510467 by Max.Chen
Property Editor: Disable color widget when editing is disabled.
#jira UE-46331
Change 3511249 by Matt.Kuhlenschmidt
PR #3715: Turn off the automatic expiration of the restore assets notification (Contributed by IHappyDayI)
Change 3511286 by Matt.Kuhlenschmidt
Added ability to set properties from USD attributes when using scene import to import USD files. See
UsdPropTestScene.usda for an example file of how this works
Change 3511528 by Cody.Albert
Updated FMoviePlayerWidgetRenderer to use Slate time instea of application time
Change 3512149 by Matt.Kuhlenschmidt
Dont save non-dirty built data when playing PIE in a standalone process
#jira UE-46422
Change 3512259 by Matt.Kuhlenschmidt
Fix static analysis
Change 3512291 by Matt.Kuhlenschmidt
PR #3719: Updating UEditorEngine::ReplaceActors to not copy array of actors (Contributed by gsfreema)
Change 3512911 by Matt.Kuhlenschmidt
Fixed USD property setting crashing if the usd file contained an array with 0 elements.
Fixed USD property setting creating invalid tmaps if the usd file contained a key that already existed
Change 3513725 by Matt.Kuhlenschmidt
PR #3726: Copy/paste fix for SAdvancedDropdownRow::Construct() (Contributed by jovisgCL)
Change 3514453 by Jamie.Dale
Added a way to set the UEnum used by a UEnumProperty after using the default constructor
This will assert if called on an instance that has already been initialized
Change 3514858 by Alexis.Matte
Fix crash when importing animation and choosing a different value for option "Import Meshes In Bone Hierarchy" then the value use to import the skeletal mesh. In some case there is no skinned mesh.
Change 3514875 by Matt.Kuhlenschmidt
PR #3721: Fixed. Screen Message was showed always when screenshot is captured(F9) (Contributed by shuaiharry)
Change 3515859 by Bradut.Palas
#jira UE-46516
The RenameTextBox didn't handle the OnTextCommitted event (which can be triggered when pressing Enter in the box). Now it does.
Change 3515998 by Jamie.Dale
Adding missing ) to some log messages
Change 3517681 by Matt.Kuhlenschmidt
Fix automated import not applying any texure settings to imported textures
Change 3517703 by Nick.Darnell
Slate - Marking SWidget's destructor as virtual (it always has been because of the parent), but this makes it more obvious.
Change 3517737 by Nick.Darnell
Slate - The retainer widget now only knows how to store the images in gamma space, rather than rendering in linear and storing using sRGB writes. If you do it that way - you end up in a state of having premultiplied linear space stored in sRGB, and getting that back into a state that looks correct when you finally render it with the rest of Slate becomes very difficult, so to make things simpler
Change 3517758 by Nick.Darnell
UMG - Updating the retainer box categories and visibility.
Change 3517795 by Nick.Darnell
Slate - We now don't do inherited volatility if we're also caching.
Change 3517861 by Matt.Kuhlenschmidt
Update windows USD to .75
Change 3517867 by Matt.Kuhlenschmidt
Delete OpenEXR from USD dependencies. It is no longer used
Change 3517873 by Matt.Kuhlenschmidt
Updated USD windows binaries
Change 3517896 by Max.Chen
Sequencer: Call SkyLightComponent's SetLightColor() directly, similar to LightComponent
#jira UE-46669
Change 3518240 by Max.Chen
Sequencer: Set needs update when binding.
#jira UE-46619
Change 3518492 by Max.Chen
Sequencer: If already at the correct play position, don't jump to it. This fixes a bug where if you play to a position and pause, resuming play will playforward and not keep pausing.
#jira UE-45996, UE-45997
Change 3518997 by Max.Chen
Fbx: Fix aperture width, height, focal length and field of view calculations.
#jira UE-46754
Change 3520190 by Jamie.Dale
Cleaned up SCC log spam when finding out-of-date dependencies
Change 3520237 by Yannick.Lange
VR Editor: cleanup auto entry. Removed TimeSinceHMDChecked and added extra check for if there is currently a vr mode active.
Change 3520923 by Max.Chen
Sequencer: Refactor displaying sequencer settings in editor so that they're always available and not only when the sequencer type is instantiated.
#jira UE-46301
Change 3521212 by Matt.Kuhlenschmidt
PR #3757: MAX_NAME_LENGHT -> MAX_NAME_LENGTH (Contributed by Josef-CL)
#jira UE-46821
Change 3521216 by Matt.Kuhlenschmidt
PR #3751: Spelling fix for ESlateVisibility comment (Contributed by Triplelexx)
#jira UE-46810
Change 3521221 by Matt.Kuhlenschmidt
PR #3733: UE-46683: Don't increment MovieIndex when playing next movie (Contributed by projectgheist)
#jira UE-46683,UE-46714
Change 3521344 by Yannick.Lange
Fix selection tools in the Levels editor window. After selecting all levels SWorldHierarchyImpl::OnUpdateSelection used GetSelectedTreeItems(). At that point the tree items were not updated yet and it would return the 'previous' items. Making it look like nothing happened. Instead WorldModel->GetSelectedLevels() had to be used to get the new list of selected levels (this was used in 4.16) and then convert the list of FLevelModel to the new system that uses WorldHierarchy::FWorldTreeItemID.
#jira UE-46741
Change 3521825 by Joe.Graf
#Xb1
Added missing VectorSetFloat1 by copying the one in UnrealMathSSE.h
#CodeReview: ben.woodhouse
Change 3522114 by Joe.Graf
#Xb1
Changed the missing VectorSetFloat1 to use MakeRegisterVector to be more consistent with other Xbox defines per Ben's code review
#CodeReview: ben.woodhouse
Change 3524202 by Matt.Kuhlenschmidt
Prevent resizing when a context menu is open. This prevents a number of rare crashes when a window is resized when a child menu is open causing the child to lose connection to the parent (happens when the parent widgets are clipped and no longer processed). This is consistent with behavior on windows and mac.
#jira UE-46653
Change 3524263 by Bradut.Palas
#jira UE-46671
The issue happened because a parent callback of OnAssetRenameCommitted would allow an implicit sync and it would reset the search. Solved by blocking the parent callback if the user is searching.
Change 3524265 by Bradut.Palas
#jira UE-46261
Console command was doing something illegal. Opening a map from editor when multiprocess and client mode were enabled is prohibited by code in Playlevel.cpp (( !CanRunUnderOneProcess && PlayNetMode == EPlayNetMode::PIE_Client ))
Solved by banning that specific use of the command.
Change 3524266 by Bradut.Palas
#jira UE-45592
The bug was caused by an iteration in EndPlayMap() that re-selected all previous actors but without the notify flag (hence, not triggering the code that validated showing the transform widget). Fixed by notifying just once per group, for performance reasons.
Change 3524585 by Bradut.Palas
Back out changelist 3524265 until I can figure out why the build system doesn't like it.
Change 3525921 by Bradut.Palas
Resubmitting revision 3524265 with properly guarded editor code (#if WITH_EDITOR)
Change 3526124 by Matt.Kuhlenschmidt
Remvoe debug canvas proxy
Change 3526139 by Matt.Kuhlenschmidt
Force low quality fallback mode on ES2 devices for slate blur widgets. This feature does not work on es2
Change 3526663 by Cody.Albert
Fixed sequencer bindings to correctly work on streamed level in standalone preview mode
Change 3527028 by Cody.Albert
Back out changelist 3526663
Change 3527241 by Cody.Albert
Fixed sequencer bindings to correctly work on streamed level in standalone preview mode
Change 3527829 by Max.Chen
Fbx: Add static transform values to curve data import.
#jira UE-46888
Change 3527830 by Max.Chen
Sequencer: Import static/default transforms and camera focal lengths from fbx.
#jira UE-46888
Change 3528768 by Matt.Kuhlenschmidt
Refactor of GetDetailsView method on IDetalLayoutBuilder for some upcoming changes. There is no longer a guarantee that a physical details panel is present wwhen customizing a property so GetDetailsView now returns a pointer and will be null if no details view exists. This refactor is necessary for a change to allow us to make loose property widgets for use outside of a details view.
Change 3528776 by Yannick.Lange
Allow thumbnails to be captured from a viewport always.
#jira UE-45392
Change 3530675 by Michael.Dupuis
#jira UE-46913 : Added extra validation to prevent possible crash
Change 3530991 by Matt.Kuhlenschmidt
Added ability for users to specifiy usd plugins for the USD importer
Change 3531110 by Matt.Kuhlenschmidt
Added automated import support for USD.
Automated import now also supports loading a level per import group so that factories may spawn actors and manipulate the level
Change 3531119 by Matt.Kuhlenschmidt
USD Scene import now uses actor factories to determine the correct actor type to spawn for an asset specified in USD
Change 3531220 by Jamie.Dale
Fixed some places that were iterating over sets/maps using their element indices as if they were the sparse indices
Change 3531831 by Cody.Albert
BP nodes can no longer be renamed on read-only graphs.
Change 3531938 by Yannick.Lange
Enable setting justification at runtime for multi-line text boxes.
#jira UE-44801
Change 3533011 by Matt.Kuhlenschmidt
Exporting render targets now chooses PNG if the render target format is an LDR format
Change 3533370 by Arciel.Rekman
Fix comparison of the RT format.
Change 3533717 by Nick.Darnell
Slate - Adding justification to SEditableText and SpinBox, also adding the field for UMG.
Change 3534756 by Arciel.Rekman
Linux: add path to bundled GL headers.
- Seems like we have been implicitly relying on it being added someplace else or simply present in the system.
- Change by Cengiz.Terzibas
Change 3535421 by Arciel.Rekman
Reduce SCW logspam on Linux (UE-46634)
#jira UE-46634
Change 3537520 by Matt.Kuhlenschmidt
PR #3780: Fix typo steam to stream (Contributed by YuchenMei)
Change 3537539 by Nick.Darnell
UMG - Fixing a bug with aspect ratio locking cameras when in HDPI mode, the spaces were slightly different. Moving over the code that calculates the offsets to function in normalized space, so that it's trivial to combine with the existing normalized viewport dimensions and offset information, without space confusion.
Change 3537542 by Nick.Darnell
UMG - Fixing some bugs with the retainer widget which was not properly resetting or registering the hit testing information when rendered every frame. This should fix some issues that have been seen with clicks locking the viewport rendering, or not being clickable.
Change 3537596 by Alexis.Matte
Fbx SDK 2018.1.1 Integration
#jira UE-45070
Change 3537672 by Matt.Kuhlenschmidt
Simple fix for seconds of time being spent refreshing the settings editor if commands are registered while it is open. The request to refresh is deferred until next tick, meaning that each command list registered in a frame is not refreshing the details panel.
Change 3537796 by Alexis.Matte
Make sure all general settings are persist when we re-import a staticmesh from fbx file.
#jira UE-46829
Change 3537961 by Michael.Dupuis
#jira UE-47222: Prevent possible crash in some bad drag & drop case
Change 3538149 by Alexis.Matte
Make sure we export NTB information instead of just the normal when exporting to fbx
#jira UE-46785
Change 3538237 by Alexis.Matte
Fix import of large fbx scene (over 2 Gb) pr #3784
#jira UE-47124
Change 3538270 by Lauren.Ridge
Epic Friday: Preview scenes in material editors
Change 3539707 by Yannick.Lange
Optimize viewport interactor hitresult for laser. Store the first hitresult and use that when calling UViewportInteractor::GetHitResultFromLaserPointer multiple times a frame.
Change 3539964 by Lauren.Ridge
Fix for cubemap not persisting between loads
Change 3540321 by Arciel.Rekman
Linux: CEF rebuilt with fewer dependencies (UE-46433).
- Removed source-only binary to save size (we can link to the runtime one, this also allows RPATH to be generated automatically).
- Change by Cengiz.Terzibas, polished by RCL.
Change 3540458 by Alexis.Matte
Fix the HDR pixel inspector. The HDR value is now RGBA in editor viewport and RGB in Game mode.
#jira UE-47199
Change 3540681 by Arciel.Rekman
Linux: fix flickering (UE-46351) - redoing fix from 4.17
- Slate rendering policy can set a scissor rect equal to a (smaller) window, which would get inherited by the scene renderer later.
#jira UE-46351
(Redoing the fix from CL 3538578 in 4.17).
Change 3540838 by Matt.Kuhlenschmidt
Fix locked actors still being moved by piloting them
Change 3542212 by Nick.Darnell
Slate - Fixing a crash with per character wrapping. When used in rich text fields, it can cause a crash due to negative lengths for measurements, due to the way we calculate start and end indexes. New code now ensures the End is always >= to the Start.
Change 3544033 by Arciel.Rekman
Drop and deprecate /-prefixed commandline switches.
- Dropped on all platforms except Windows, where it will produce a warning. Complete drop is expected in 4.19.
Change 3544213 by Nick.Darnell
Slate - Fixing another potential crash with the slate loading thread. The default movie player was listening for map load finishing using the AddSP callaback, which means the weakptr would be accessed, switching these over to AddRaws to be safer.
Change 3546113 by Nick.Darnell
Slate - Resurecting the slate visualizer support in the slate renderer for batch visualization, and overdraw.
Change 3547129 by Michael.Trepka
Few small changes that make UnrealBuildTool faster when running on Mono
Change 3547454 by Jamie.Dale
Added search to editable texts
Change 3547460 by Jamie.Dale
The output log now applies a search to its editable text when filtering
This highlights the term matches on each line
Change 3548177 by Jamie.Dale
Optimized PO entry look-up
Change 3548287 by Matt.Kuhlenschmidt
Fix one off speedtree crash
#jira UE-47538
Change 3548377 by Lauren.Ridge
Checking that the Environment Map Path is set before trying to load it.
#jira UE-47365
Change 3548628 by Matt.Kuhlenschmidt
Fix focus graphic for tabs not pointing to the correct image
Change 3549289 by Max.Chen
Movie Scene Capture: Move window to within the desktop bounds when resizing.
#jira UE-37330
Change 3549290 by Arciel.Rekman
Fix hlslcc not working properly with newer clangs.
- Both the clang 3.8+ problem and UB reported by UBSan.
Change 3550573 by Max.Chen
Sequencer: Track drag drop.
Implement drag and drop onto a camera track, subscene track, and cinematic shot track.
#jira UE-45773
#jira UE-45387
Change 3550729 by Max.Chen
Sequence Recorder: Add interpolation and tangent settings for animation recording keys
#jira UE-46146
Change 3551558 by Nick.Darnell
UMG - Tweaking some designer elements, playing around with a 'real-time' mode. Also fixing a bug with decendant widgets in named slots not triggering design effects like updating the widget switcher.
#jira UE-39404
Change 3551671 by Joe.Graf
Merged over the change to expose more of dormancy to Blueprints (UE-46240)
Change 3551684 by Cody.Albert
Removing some unused code from map check
Change 3552673 by Yannick.Lange
Fix crash select all levels with folders in the treewidget.
Change 3552960 by Yannick.Lange
Frontend filter for files referenced by any level in the project and a filter for not referenced by any level.
#jira UE-22153
Change 3553727 by Max.Chen
Sequencer: Capture thumbnail before pre save so that the thumbnail isn't captured with the evaluation in a reset state.
#jira UE-47693
Change 3553778 by Arciel.Rekman
Cache check for compiler availability (UE-47699).
- Fixes performance drop in the blueprint editor. Better than caching in a particular source accessors because affects all accessors (incl. Mac which isn't cached either) and reduces calls.
Change 3554128 by Matt.Kuhlenschmidt
Null out GEditor after it has been destoyed. Any modules that access GEditor can now properly check for a null geditor instead of blindly accessing it
Change 3554266 by Max.Chen
Movie Scene Capture: Override cinematic mode in the movie scene capture.
#jira UE-33473
Change 3555563 by Alexis.Matte
Fix static mesh screensize lost when converting from an old version. The conversion require valid extended bounds which was converted after the LOD screensize.
#jira UE-47697
Change 3555755 by Yannick.Lange
VR Editor: Add exit button inside new menu called "system" on radial menu. Still needs correct icons.
Change 3556334 by Matt.Kuhlenschmidt
Added a new type of property editor called a property row generator. This is essentially a details panel that can generate each unique row but adds no visual styling around the property editors and does not generate a master tree widget for the properties. This is useful for creating proper widgets for properties and displaying them in a UI that is not the details panel
Change 3558100 by Matt.Kuhlenschmidt
PR #3823: Incorrect comment syntax in ini files (Contributed by projectgheist)
Change 3558240 by Lauren.Ridge
Move floor in material editor preview scene based on preview mesh
Change 3558242 by Matt.Kuhlenschmidt
Fix console variables help page showing only rendering cvars by default
Change 3558243 by Matt.Kuhlenschmidt
Fix static analysis
Change 3558342 by Alexis.Matte
Make the code to find the best sample rate to import fbx animation more simple and more robust. The code need to be able to support all the possible case.
Add a lot of animation sample rate automation tests
#jira UE-47342
Change 3558515 by Yannick.Lange
VR Editor: Changed icon for system and exit button on radial menu.
Change 3558973 by Matt.Kuhlenschmidt
Fix camera placement of the default map
Change 3559230 by Arciel.Rekman
Do not link CEF3 for servers (UE-47721).
Change 3559572 by Arciel.Rekman
Linux: make sure the engine is rebuilt during the updates.
Change 3560197 by Arciel.Rekman
Linux: cosmetic cleanup of an old code.
Change 3560904 by Max.Chen
Movie Scene Capture: Expose "Open Folder" hyperlink while capturing.
Change 3561213 by Matt.Kuhlenschmidt
Enable USD by default in QA game for testing
Change 3561928 by Matt.Kuhlenschmidt
Fix green glowing in the mateiral editor
#jira UE-47826
Change 3562259 by Arciel.Rekman
Made FPlatformMisc::DebugBreak() not inlined on Linux.
- Saves a great deal of binary size without really impacting a performance.
Change 3562630 by Arciel.Rekman
Make Linux editor compilable with clang 5.0-rc1.
Change 3563564 by Yannick.Lange
Fix Cube Static Mesh Thumbnail renders black. Cleared out the thumbnail, causing it to create the correct new one.
#jira UE-47777
Change 3564529 by Jamie.Dale
Const-correct UScriptStruct::ExportText
Change 3564972 by Alexis.Matte
Fix staticmesh merge applying build scale multiple time Git PR #3807
#jira UE-47645
Change 3565253 by Arciel.Rekman
Fix "Anim to Play" being inaccessible after import (UE-47885).
- The variable was not initialized and could remain false on Linux.
#jira UE-47885
Change 3565293 by Jamie.Dale
Merged "Categories" into the main Output Log filter list
Change 3565939 by Alexis.Matte
Back out revision 3 from //UE4/Dev-Editor/Engine/Source/Developer/MeshMergeUtilities/Private/MeshMergeHelpers.cpp
Change 3566081 by Alexis.Matte
Fix staticmesh merge applying scale twice PR #3807
#jira UE-47645
Change 3566232 by Matt.Kuhlenschmidt
Fix edit inline properties not clipping properly
#jira UE-47775
[CL 3567077 by Matt Kuhlenschmidt in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3494741 by Steve.Robb
Generated code size savings.
#jira UE-43048
Change 3495484 by Steve.Robb
Fix for generated indices of static arrays when saving configs.
Change 3497926 by Robert.Manuszewski
Removed FPackageFileSummary's CompressedChunks array as it was no longer being used by anything.
Change 3498077 by Robert.Manuszewski
Only use the recursion guard in async loading code when the event driven loader is enabled.
Change 3498112 by Ben.Marsh
UBT: Respect the option to not create debug info in the Android toolchain. This option is already being respected by the compiler, but the linker adds debug info of its own.
Change 3500239 by Robert.Manuszewski
Made sure the Super Class token stream is also locked when assembling Class token stream with async loading thread enabled. This to to prevent race conditions when loading BP classes.
Change 3500395 by Steve.Robb
Extra codegen savings when not in hot reload.
Change 3501004 by Steve.Robb
EObjectFlags now have constexpr operators.
Change 3502079 by Ben.Marsh
UBT: Pad multi-line error messages so that they align under the prefix for the first line, and include the timestamp if necessary.
Change 3502527 by Steve.Robb
Fix for zero-sized array compile error in generated code when all functions are editor-only.
Change 3502542 by Ben.Marsh
UAT: Remove the custom source parameter from log functions, and add support for a customizable indent instead.
Change 3502868 by Steve.Robb
Workaround for inefficient generated code with stateless lambdas on Clang.
Change 3503550 by Steve.Robb
Another generated code lambda optimization.
Change 3503582 by Ben.Marsh
BuildGraph: Add support for nullable parameter types.
Change 3504424 by Steve.Robb
New AllOf, AnyOf and NoneOf algorithms.
Change 3504712 by Ben.Marsh
UAT: Less spammy log and error output from UAT.
* Callstacks for AutomationExceptions are suppressed by default but still included in the log (the path to the log is noted in console output with the message from the exception).
* Add a mechanism for any exceptions to be caught and rethrown with additional lines of context (CommandUtils.AddContext()) that will be appended to the error output by UAT. Avoids decaying the exception type or masking the inner exception message while still adding additional information.
* AggregateExceptions resulting from exceptions on child threads are automatically unwrapped (full details are still appended to the log)
* Name of the calling function is not included in console output by default, but still included in the log.
Change 3504808 by Ben.Marsh
UAT: Suppress P4 output when running a recursive instance of UAT.
Change 3505044 by Steve.Robb
Code generation improved for TCppClassType code.
Change 3505485 by Ben.Marsh
Fix deterministic cooking issue; always use a pseudo-random number stream when compiling a module.
Change 3505699 by Ben.Marsh
Plugins: Store the bEnabledByDefault flag exactly as it was read from disk rather than collapsing it to an absolute value based on the default for the location it was read from. This allows loading/saving plugin descriptors without any knowledge of whether they are game or engine plugins.
Change 3506055 by Ben.Marsh
UAT: Add a class to apply a log indent for the lifetime of an object (ScopedLogIndent), and use it to apply an indent to MegaXGE/ParallelExecutor output.
Change 3507745 by Robert.Manuszewski
Moved FSimpleObjectReferenceCollectorArchive and FSimpleObjectReferenceCollectorArchive to be internal archives used only by FReferenceCollector so that they are constructed only once per GC task instead of potentially multiple times per GC (as was the case with UDataTables and BlueprintGeneratedClasses).
Change 3507911 by Ben.Marsh
Plugins: Minor changes to plugin descriptors.
* Add a distinct setting for an unspecified EnabledByDefault setting in plugin descriptors.
* Add a function to IPlugin to determine the effective EnabledByDefault setting, based on where the plugin was loaded from.
Change 3508669 by Ben.Marsh
EC: Parse multi-line messages from UBT and UAT.
Change 3508691 by Ben.Marsh
Fix double-spacing of cook stats.
Change 3509245 by Steve.Robb
UHT makefiles removed.
Flag audit removed.
Change 3509275 by Steve.Robb
Fix for mismatched stat categories in AudioMixer.
#jira UE-46129
Change 3509289 by Robert.Manuszewski
Custom Version Container will no longer be always constructed in FArchive constructor. This reduces the number of the Custom Version Container allocations considerably.
Change 3509294 by Robert.Manuszewski
UDataTable::AddReferencedObjects will no longer try to iterate over the RowMap if there's no UObject references in it.
Change 3509312 by Steve.Robb
GitHub# 3679: Add TArray constructor that takes a raw pointer and a count
Check improved for Append() to allow nullptr in empty ranges, and added to new constructor too.
#jira UE-46136
Change 3509396 by Steve.Robb
GitHub# 3676: Fix TUnion operator<< compile error
#jira UE-46099
Change 3509633 by Steve.Robb
Fix for line numbers on multiline macros.
Change 3509938 by Gil.Gribb
UE4 - Fix rare assert involving cancelled precache requests and non-pak-file loading.
Change 3510593 by Daniel.Lamb
Fixed up unsoilicited files getting populated with files which aren't finished being created yet.
#test None
Change 3510594 by Daniel.Lamb
Fixed up temp files directory for patching.
Thanks David Yerkess @ Milestone
#review@Ben.Marsh
Change 3511628 by Ben.Marsh
PR #3707: Fixed UBT stack size (Contributed by gildor2)
Change 3511808 by Ben.Marsh
Optimize checks for whether the game project contains source code. Now stops as soon as the first file is found and ignores directories beginning with a '.' character (eg. .git)
#jira UE-46540
Change 3512017 by Ben.Marsh
Plugins: Deprecate the QueryStatusForAllPlugins() function; the same functionality is available via the IPlugin interface.
Change 3513935 by Steve.Robb
Reverted array iteration in FPropertyNode::PropagatePropertyChange as this is now covered in TProperty::InitializeValueInternal() as of CL# 3293477.
Change 3514142 by Steve.Robb
MemoryProfiler2 added to generated solution.
Change 3516463 by Ben.Marsh
Plugins: Create a manifest for each PAK file containing all the plugin descriptors in one place. Eliminates need to recurse through directories and read separate multiple files in serial at startup, and allows reading all plugin descriptors with one read. The "Mods" directory is excluded from the manifest, since these are intended to be installed separately by the user.
Change 3517860 by Ben.Marsh
PR #3727: FString Dereference Fixes (Contributed by jovisgCL)
Change 3517967 by Ben.Marsh
Suppress additional system error dialogs when loading DLLs if -unnattended is on the command line.
Change 3518070 by Steve.Robb
Disable Binned2 stats in shipping non-editor builds.
Change 3520079 by Steve.Robb
Fixed bad codegen TAssetPtrs being passed into BlueprintImplementableEvent functions.
#jira UE-24034
Change 3520080 by Robert.Manuszewski
Made max package summary size to be configurable with ini setting
Change 3520083 by Steve.Robb
Force a GC after hot reload to clean up reinstanced objects which may still tick.
#jira UE-40421
Change 3520480 by Robert.Manuszewski
Improved assert message when the initial package read request was too small.
Change 3520590 by Graeme.Thornton
SignedArchiveReader optimizations
- Loads more stats
- Stop chunk cache worker from waking up continuously to poll for work. Only wake up when triggered by the archive reader
- Signed archive reader just yields when waiting for buffers to finish loading, rather than sleeping for some arbitrary amount of time
- Track the number of pending read requests in an atomic counter, to save having to lock the request queue to check for new entries
Change 3521023 by Graeme.Thornton
Remove spin from signed archive reader. Main thread waits on an event triggered by the chunk worker to indicate that new chunks are ready for processing
Change 3521787 by Ben.Marsh
PR #3736: Small static code analysis fixes (Contributed by jovisgCL)
Change 3521789 by Ben.Marsh
PR #3735: Fix case sensitivity issue in FWindowsPlatformProcess::IsApplicationRunning. (Contributed by samhocevar)
Change 3524721 by Ben.Marsh
Move Linux SDL initialization into FLinuxPlatformApplicationMisc. Attempting to move functionality related to interactive applications (graphics, input, etc...) into a separate place, so it can ultimately be moved out of Core.
Change 3524741 by Ben.Marsh
Move PumpMessages() into FPlatformApplicationMisc.
Change 3525399 by Ben.Marsh
UGS: Use the default Perforce server port when opening P4V if there is not one set in the environment.
Change 3525743 by Ben.Marsh
UAT: Add a parameter to allow updating version files without updating Version.h, to allow faster link times on incremental builds.
Change 3525746 by Ben.Marsh
EC: Include the clobber option on new workspaces, to allow overriding version files when syncing.
Change 3526453 by Ben.Marsh
UGS: Do not generate project files when syncing precompiled binaries.
Change 3527045 by Ben.Marsh
Fix hot reload generating import libraries without DLLs. Now that they are produced by separate actions by default, it was removing DLLs from the action graph due to the bSkipLinkingWhenNothingToCompile setting.
Change 3527420 by Ben.Marsh
UGS: Add additional search paths for UGS config files, and fix a few cosmetic issues (inability to display ampersands in tools menu, showing changelist -1 when running a tool without syncing).
Config files are now read from:
Engine/Programs/UnrealGameSync/UnrealGameSync.ini
Engine/Programs/UnrealGameSync/NotForLicensees/UnrealGameSync.ini
If a project is selected:
<ProjectDir>/Build/UnrealGameSync.ini
<ProjectDir>/Build/NotForLicensees/UnrealGameSync.ini
If the .uprojectdirs file is selected:
Engine/Programs/UnrealGameSync/DefaultProject.ini
Engine/Programs/UnrealGameSync/NotForLicensees/DefaultProject.ini
Change 3528063 by Ben.Marsh
Fix non-thread safe construction of FPluginManager singleton. Length of time spent in the constructor resulted in multiple instances being constructed at startup, making the time to enumerate plugins on slow media significantly worse.
Change 3528415 by Ben.Marsh
UAT: Remove \r characters from the end of multiline log messages.
Change 3528427 by Ben.Marsh
EC: Fix spaces being converted to tabs at start of line in failure emails (by Gmail), and wrap following lines at the same indent.
Change 3528485 by Ben.Marsh
EC: Remove zero-width word break characters from slashes in notification emails; can cause really hard to debug problems when copy pasted into other places.
Change 3528505 by Steve.Robb
PR #3755: MallocProfiler - Remove subfolder from profiling save directory (Contributed by Josef-CL)
#jira UE-46819
Change 3528772 by Robert.Manuszewski
Enabling actor and blueprint clustering in ShooterGame
Change 3528786 by Robert.Manuszewski
PR #3760: Fix typo (Contributed by jesseyeh)
Change 3528792 by Steve.Robb
PR #3764: MallocProfiler - Refactoring Scopelock (Contributed by Josef-CL)
#jira UE-46962
Change 3528941 by Robert.Manuszewski
Fixed lazy object pointers not being updated for streaming sub-levels in PIE. Fixed lazy pointers returning object that is still being loaded which could lead to undefined behavior when client code started modifying the returned object.
#jira UE-44996
Change 3530241 by Ben.Marsh
UAT: Only pass -submit or -nosubmit to child instances of UAT if they were specified on the original command line. BuildCookRun uses this flag to determine whether to submit, rather than just whether to allow submitting, so we shouldn't pass an inferred value.
Change 3531377 by Ben.Marsh
Plugins: Allow plugins to specify a list of supported target platforms, which is propagated to any .uproject file that enables it.
This has several advantages over the per-module platform whitelist/blacklist:
* Platform-specific .uplugin files can now be excluded when staging other platforms. Previously, it was only possible to determine which platforms a plugin supports by reading the plugin descriptor itself. Now that information is copied into the .uproject file, so the runtime knows which plugins to ignore.
* References to dependent plugins from platform-specific plugins can now be eliminated.
* Plugins containing content can now be unambiguously disabled on a per-platform basis (having no modules for a platform does not confer that a plugin doesn't support that platform; now it is possible to specify supported platforms explicitly).
* The editor can load any plugins without having to whitelist supported editor host platforms.
UE4 targets which support loading plugins for target platforms can set TargetRules.bIncludePluginsForTargetPlatforms (true for the editor by default, false for any other target types). This defines the LOAD_PLUGINS_FOR_TARGET_PLATFORMS macro at runtime, which allows the plugin system to filter which plugins to look for at runtime.
Any .uproject file will be updated at startup to contain the list of supported platforms for each referenced plugin if necessary.
Change 3531502 by Jin.Zhang
Add support for GPUCrash #rb
Change 3531664 by Ben.Marsh
UBT: Change output format from C# JSON writer to match output by the engine.
Change 3531848 by Ben.Marsh
UAT: Add script to resaving all project descriptors under a folder, embedding information for any supported platforms for the plugins they enable.
Change 3531869 by Ben.Marsh
UAT: Add parameter to the ResaveProjectDescriptors command to update the engine association field.
Change 3532474 by Ben.Marsh
UBT: Use the same mechanism as UAT for logging exceptions.
Change 3532734 by Graeme.Thornton
Initial VSCode Support
- Tasks generated for building all game/engine/program targets
- Debugging support for targets on Win64
Change 3532789 by Steve.Robb
FScriptSet::Add and TScriptMap::Add now replace the element, matching the behavior of TSet and TMap.
Set_Add and Map_Add no longer have a return value.
FScriptSet::Find and FScriptMap::Find functions are now FindIndex.
FScriptSetHelper::FindElementFromHash is now FindElementIndexFromHash.
Change 3532845 by Steve.Robb
Obsolete UHT settings deleted.
Change 3532875 by Graeme.Thornton
VSCode
- Add debug targets for different target configurations
- Choose between VS debugger (windows) and GDB (mac/linux)
Change 3532906 by Graeme.Thornton
VSCode
- Point all builds directly at UBT rather than the batch files
- Adjust mac build tasks to run through mono
Change 3532924 by Ben.Marsh
UAT: Set the UAT working directory immediately on startup. This ensures that any command line arguments containing paths are resolved consistently to the branch root.
Change 3535234 by Graeme.Thornton
VSCode - Pass intellisense system a list of paths to use for header resolution
Change 3535247 by Graeme.Thornton
UBT - Add a ToString to ProjectFile.Source file to help with debugger watch presentation
Change 3535376 by Graeme.Thornton
VSCode
- Added build jobs for C# projects
- Linked launch tasks to relevant build task
Change 3537083 by Ben.Marsh
EC: Change P4 swarm links to start at the changelist for a build.
Change 3537368 by Graeme.Thornton
Fix for crash in FSignedArchiveReader when multithreading is disabled
Change 3537550 by Graeme.Thornton
Fixed a crash in the taskgraph when running single threaded
Change 3537922 by Steve.Robb
Missing PF_ATC_RGBA_I added to FOREACH_ENUM_EPIXELFORMAT.
Change 3539691 by Graeme.Thornton
VSCode - Various updates to get PC and Mac C++ projects building and debugging.
- Some other changes to C# setup to allow compilation. Debugging doesn't work.
Change 3539775 by Ben.Marsh
Plugins: Various fixes to settings for enabling plugins.
* Fix crash on startup when trying to disable a missing plugin (was keeping pointers to elements in the project's plugin reference array, which may be modified if a plugin is disabled).
* Revert fix to set PluginDescriptor.bRequiresBuildPlatform = true by default. This was the originally intended behavior, but it was accidentally defaulted to false during serialization unless specified in the .uplugin file. Many plugins may rely on this behavior (they may not declare asset classes otherwise, for example, which could result in loss of data), so change the default value to false instead. Also fixes popups to disable platform-specific plugins if platform SDKs are not installed.
* Fix plugins which are referenced but do not exist not showing the appropriate prompt to disable them.
Change 3540788 by Ben.Marsh
UBT: Add support for declaring custom pre-build steps and post-build steps from .target.cs files. Similarly to the custom build steps configurable from .uproject and .uplugin files, these specify commands which will be executed by the host platform's shell before or after a build. The following variables are expanded within the list of commands before execution: $(EngineDir), $(ProjectDir), $(TargetName), $(TargetPlatform), $(TargetConfiguration), $(TargetType), $(ProjectFile).
Example usage:
public class UnrealPakTarget : TargetRules
{
public UnrealPakTarget(TargetInfo Target) : base(Target)
{
Type = TargetType.Program;
LinkType = TargetLinkType.Monolithic;
LaunchModuleName = "UnrealPak";
if(HostPlatform == UnrealTargetPlatform.Win64)
{
PreBuildSteps.Add("echo Before building:");
PreBuildSteps.Add("echo This is $(TargetName) $(TargetConfiguration) $(TargetPlatform)");
PostBuildSteps.Add("echo After building!");
PostBuildSteps.Add("echo This is $(TargetName) $(TargetConfiguration) $(TargetPlatform)");
}
}
}
Change 3541664 by Graeme.Thornton
VSCode - Add problemMatcher tag to cpp build targets
Change 3541732 by Graeme.Thornton
VSCode - Change UBT command line switch to "-vscode" for simplicity
Change 3541967 by Graeme.Thornton
VSCode - Fixes for Mac/Linux build steps
Change 3541968 by Ben.Marsh
CRP: Pass through the EnabledPlugins element in crash context XML files.
#jira UE-46912
Change 3542519 by Ben.Marsh
UBT: Add chain of references to error messages when configuring plugins.
Change 3542523 by Ben.Marsh
UBT: Add more useful error message when attempt to parse a JSON object fails.
Change 3542658 by Ben.Marsh
UBT: Include a chain of references when reporting errors instantiating modules.
Change 3543432 by Ben.Marsh
Plugins: Fix plugins which are enabled by default not being enabled unless a project file is set.
Change 3543436 by Ben.Marsh
UBT: Prevent recursing through the same module more than once when building out the referenced modules. Produces much shorter reference chains when something fails.
Change 3543536 by Ben.Marsh
UBT: Downgrade message about redundant plugin references to a warning.
Change 3543871 by Gil.Gribb
UE4 - Fixed a critical crash bug with non-EDL loading from pak files.
Change 3543924 by Robert.Manuszewski
Fixed a crash on UnrealFrontend startup caused by re-assembling GC token stream for one of the classes.
+Small optimization to token stream generation code.
Change 3544469 by Jin.Zhang
Crashes page displays the list of plugins from the crash context #rb
Change 3544608 by Steve.Robb
Fix for nativized generated code.
#jira UE-47452
Change 3544612 by Ben.Marsh
Add callback into FMacPlatformMisc::PumpMessages() from FMacPlatformApplicationMisc::PumpMessages().
#jira UE-47449
Change 3545954 by Gil.Gribb
Fixed a critical crash bug relating to a race condition in async package summary reading.
Change 3545968 by Ben.Marsh
UAT: Fix incorrect username in BuildGraph <Submit> task. Should use the username from the Perforce environment, not assume the logged in user name is the same.
#jira UE-47419
Change 3545976 by Ben.Marsh
EC: Delete the AutoSDK client if the directory doesn't exist. When we format build machines, we need to force everything to be resynced from scratch.
Change 3546185 by Ben.Marsh
Hacky fix for deployment on IOS/TVOS. Since deployment directly references the NonUFS manifest files that are written out, merge all the SystemNonUFS files back into the NonUFS list after the regular NonUFS files have been remapped.
Change 3547084 by Gil.Gribb
Fixed a critical race condition in the new async loader. This was only reproducible on IOS, but may affect other platforms.
Change 3547968 by Gil.Gribb
Fixed critical race which potentially could cause a crash in the pak precacher.
Change 3504722 by Ben.Marsh
BuildGraph: Improved tracing for error messages. All errors are now propagated as exceptions, and are tagged with additional context information about the task currently being run.
For example, throwing new AutomationException("Unable to write foo.txt") from SetVersionTask.Execute is now displayed in the log as:
ERROR: Unable to write to foo.txt
while executing <SetVersion Change="0" CompatibleChange="0" Branch="Unknown" Promoted="True" />
at Engine\Build\InstalledEngineBuild.xml(91)
(see D:\P4 UE4\Engine\Programs\AutomationTool\Saved\Logs\UAT_Log.txt for full exception trace)
Change 3512255 by Ben.Marsh
Rename FPaths functions with a "Game" prefix (GameDir(), GameContentDir(), etc...) to have a "Project" prefix (ProjectDir(), ProjectContentDir(), etc...) for clarity with non-game uses of UE4. Old functions still exist but are deprecated.
Change 3512332 by Ben.Marsh
Rename "Game" functions in FApp to be "Project" functions (FApp::GetGameName() -> FApp::GetProjectName(), etc...) for clarity with non-game uses of UE4.
Change 3512393 by Ben.Marsh
Rename FPaths::GameLogDir() to FPaths::ProjectLogDir().
Change 3513452 by Ben.Marsh
Plugins: Rename EPluginLoadedFrom::GameProject to EPluginLoadedFrom::Project.
Change 3516262 by Ben.Marsh
Add support for a "Mods" folder distinct from the project's "Plugins" folder, instead of using the bIsMod flag on the plugin descriptor.
* Mods are enumerated similarly to regular plugins, but IPlugin::GetType() will return EPluginType::Mod.
* The DLCName parameter to BuildCookRun and the cooker now correctly finds any plugin in the Plugins or Mods directory (or any subfolders).
Change 3517565 by Ben.Marsh
Remove fixed engine version numbers from OSS plugins.
Change 3518005 by Ben.Marsh
UAT: Remove the bUFSFile parameter from DeployLowerCaseFilenames(). Every platform returns false if the argument is false.
Change 3518054 by Ben.Marsh
UAT: Use an enum to direct whether all directories should be searched when finding files to stage, rather than a bool. Having so many optional boolean arguments makes code unreadable and refactoring hard.
Change 3524496 by Ben.Marsh
Start moving GUI application code into a separate static platform class, hopefully ultimately removing it from Core.
Change 3524641 by Ben.Marsh
Move more functionality related to windowed/graphical applications into FPlatformApplicationMisc.
Change 3528723 by Steve.Robb
MoveTemp now static asserts if passed a const reference or rvalue.
MoveTempIfPossible still follows the old (std::move) rule, which is useful for templates where the nature of the argument is not obvious.
Fixes to violations of these new rules.
Change 3528876 by Ben.Marsh
Move FPlatformMisc::ClipboardCopy and FPlatformMisc::ClipboardPaste to FPlatformApplicationMisc::ClipboardCopy and FPlatformApplicationMisc::ClipboardPaste.
Change 3529073 by Ben.Marsh
Add script to package ShooterGame for any platforms.
Change 3531493 by Ben.Marsh
Update platform-specific plugins to declare the target platforms they support.
Change 3531611 by Ben.Marsh
UAT: Add a ResavePluginDescriptors command, which resaves all plugin descriptors under a given folder, removing any outdated fields and rewrites them in a consistent style. Many plugins in the wild contain redundant or no-longer used fields due to using our plugins as templates.
Change 3531868 by Ben.Marsh
Resaving project descriptors to remove invalid fields.
Change 3531983 by Ben.Marsh
UAT: Simplify logic for staging code, and add validation against shipping files in restricted folders.
* Added a new SystemNonUFS type for staged files, which excludes files from being remapped or renamed by the platform layer.
* Replaced the DeplyomentContext.StageFiles() function with simpler overloads for particular use cases (options for remapping are replaced with the SystemNonUFS file type)
* Config entries in the [Staging] category in DefaultGame.ini file allow remapping one directory to another, so restricted content can be made public in packaged builds (Example syntax: +RemapDirectory=(From="Foo/NoRedist", To="Foo"))
* An error is output if any restricted folder names other than the output platform are in the staged output.
Change 3540315 by Ben.Marsh
UAT: Moving StreamCopyDescription command into a NotForLicensees folder, since it's only meant to be used by engine developers.
Change 3542410 by Ben.Marsh
UBT: Deprecate accessing properties through BuildConfiguration.* or UEBuildConfiguration.* from .target.cs files. These have been aliases to the current TargetRules instance for several releases already.
Change 3543018 by Ben.Marsh
UBT: Deprecate the BuildConfiguration and UEBuildConfiguration aliases from the ModuleRules class. These have been implemented as an alias ot the ReadOnlyTargetRules instance passed to the constructor for several engine versions.
Change 3544371 by Steve.Robb
Fixes to TSet_Add and TMap_Add BPs.
#jira UE-47441
[CL 3548391 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
- Linkers are no longer UObjects. Renamed ULinker, ULinkerLoad and ULinkerSave to FLinker, FLinkerLoad, FLinkerSave respectively
- Linkers are now associated with their UPackages
- Linker version is now stored in UPackages
- Async loading is now performed on a separate thread (if platform supports it and only in cooked builds), with the exception of PostLoad which is still done on the game thread
- Added UObject::IsPostLoadThreadSafe() function to determine if PostLoad is thread safe and can be executed on the async loading thread (defaults to false)
- UObject creation is now thread safe and can be performed on any thread
- Move many of the linker/UObject globals into FUObjectThreadContext (TLS)
- GetAsyncLoadPercentage() now takes PostLoad into account
- More async loading stats
- Added AtomicallySetFlags/ClearFlags to UObject
- Made FModuleManager thread safe.
- Added FGCScopeGuard as means of preventing GC from executing from non-game thread
- It's possible to disable async loading thread through ini settings.
- Cancelling async loading will now also trigger GC
- Implemented a basic version of async streaming priorities.
Change 2410813 by Mikolaj Sieluzycki:
Change Sleep in while loop to ConditionalSleep in FMultiReaderSingleWriterGT
Change 2410734 by Mikolaj Sieluzycki:
Make FModuleManager thread safe.
Change 2399879 by Mikolaj Sieluzycki:
Basic version of async streaming priorities.
Change 2410707 by Mikolaj Sieluzycki:
Implement conditional and no stat versions of sleep.
Change 2371939 by Robert Manuszewski:
Async Loading Improvements: adding more stats (accumulators)
Change 2372403 by Robert Manuszewski:
Fixing compile errors when STATs are not enabled
Change 2371526 by Robert Manuszewski:
AsyncLoading Improvements (WIP)
Change 2407198 by Robert Manuszewski:
Re-implementing delegate fixes for Async Loading
Change 2407425 by Robert Manuszewski:
Re-implementing cancelling async loading in the async loading branch.
Change 2484362 by Robert Manuszewski:
Making it possible to disable async loading thread through ini settings.
Change 2484744 by Robert Manuszewski:
Minimizing locks in GC and other threads when handling UObjects
Change 2480190 by Robert Manuszewski:
Fixing infinite stall after canceling async loading in non-cooked builds
Change 2484268 by Robert Manuszewski:
Fixing crash when allocating permanent object pool.
Change 2489761 by Robert Manuszewski:
Fixing BulkData using linker archive on the main thread even if the linker was created on the async loading thread.
Change 2493624 by Robert Manuszewski:
Cancelling async loading will now also trigger GC
Change 2487881 by Robert Manuszewski:
Making ShaderIdMap operations thread safe.
Change 2488067 by Robert Manuszewski:
Fixing GetAsyncLoadPercentage. It will now also respect PostLoad.
Change 2458640 by Robert Manuszewski:
Fixing crash in PIE
Change 2458825 by Robert Manuszewski:
Fixing a few crashes when streaming and the package is missing.
Change 2476935 by Robert Manuszewski:
Fixing crash while async loading ANavigationData
Change 2477361 by Robert Manuszewski:
Fixing crashes in cooked game
Change 2480095 by Robert Manuszewski:
Making FUObjectArray more thread safe
Change 2475443 by Robert Manuszewski:
Re-enabling single-threaded async loading path for the editor and platforms that don't support multithreading.
Change 2475458 by Robert Manuszewski:
Making sure bulk data is only loaded on a separate thread if it's not being loaded on the async loading thread.
Change 2476661 by Robert Manuszewski:
Fixing FlushAsyncLoading not flushing everything
Change 2401089 by Jaroslaw Surowiec:
Core - Added AtomicallySetFlags/ClearFlags to UObject, added a comment to ThisThreadAtomicallyClearedRFUnreachable
[CL 2498249 by Robert Manuszewski in Main branch]
Some dialogs, e.g. from save menu actions, don't need the two options.
#jira UE-10400 - Clicking on Save All brings up same window as when closing the editor
[CL 2463740 by Richard TalbotWatkin in Main branch]
* Moved Slate.h into SlateBasics.h and began shifting less commonly used headers into SlateExtras.h.
* Slate.h now simply includes SlateBasics.h and SlateExtras.h.
* Slate.h includes a deprecated warning now to indicate that SlateBasics.h + specific includes should be used instead.
* Moved dozens of inlined functions using Slate widgets into .cpp files to avoid header dependencies.
* All code samples now include SlateBasics.h and SlateExtras.h so future shifts will not break most those projects, but not trigger the deprecation warning of including Slate.h.
#BUN
[CL 2329610 by Wes Hunt in Main branch]
Breaking changes include:
* Rename of GEditorModeTools -> GLevelEditorModeTools to signify that it applies only to the level editor modes
* Addition of FEditorModeRegistry, responsible for managing and creating new editor modes. Modes are no longer registered with an instance of the mode, instead with a mode factory that is able to create a new mode of that type.
* Editor modes now operate on FEditorViewportClients rather than FLevelEditorViewportClients
* Added ability to specify an FEditorModeTools when creating an FEditorViewport
Moved component vizualiser manager handling outside of individual editor modes, and into FLevelEditorViewportClient. This should make it easier to transplant in future.
This work addresses TTP#334640 - EDITOR: Investigate making editor modes a per-'editor' concept
Reviewed by Michael Noland, Matt Kuhlenschmidt
[CL 2109245 by Andrew Rodham in Main branch]
Please note that file comments had no purpose in nearly all cases and just added visual clutter. The two files that had meaningful file comments had their comments moved into the corresponding classes. There are still hundreds of file comments left in other files that will be removed over time.
Also cleaned up some random stuff along the way:
- relative paths to public headers within the same module are no longer necessary (automatically discovered by UBT now)
- header guards are deprecated, use #pragma once instead (all compilers support it now)
- space between multiple template brackets is no longer required (all compilers support >> now)
- NULL to nullptr, OVERRIDE to override
- spelling errors, whitespace, line breaks
[CL 2104067 by Max Preussner in Main branch]
I also added code to retain backwards compatibility. Existing settings from EditorUserSettings.ini will be migrated to EditorLayout.ini
#CodeReview: nick.atamas, matt.kuhlenschmidt
[CL 2074798 by Max Preussner in Main branch]
Ryan Vance
Jason Bestimt
Ben Marsh
Matt Kuhlenschmidt
unrealbot
Matthew Griffin
Robert Manuszewski
Richard TalbotWatkin
Wes Hunt
Robert Jones
Chris Gagnon
Gareth Martin
Andrew Rodham
Max Preussner
Tim Sweeney