Replaced all calls to UWorld::GetFirstPlayerController in the engine with a more readily available player controller, or UGameInstance::GetFirstLocalPlayerController, since that appears to be the actual intent. The first controller in the world's list may not be considered local, such as when a client is recording a replay.
Also changed UConsole::ConsoleCommand to use the first local player controller instead of the first player controller with a non-null player. This fixes commands like ToggleDebugCamera during client replay recording.
--------
Integrated using branch UE4-Orion-To-UE4 of change#2688431 by Ryan.Gerleve on 2015/09/11 14:24:23.
[CL 2688498 by Ryan Gerleve in Main branch]
- New filter flags in automationtest.h
- Compile time errors if proper flags are not specified
- Existing tests converted to new flags
- New "disabled" flag
- Filter dropdown in automation UI replaces Smoke Tests button
- Automation features are no longer compiled out in Test configuration at runtime (except in Shipping)
- Enabled automation tests to be triggered from in-game console in non-editor builds (automation controller is enabled)
NOTE: This will force licensees who use automation to update their tests.
#codereview: jason.bestimt, mike.fricker, ben.salem
[CL 2672561 by Adric Worley in Main branch]
Fixes for lots of existing modules by removing all dynamically loaded duplicates (this is probably not the correct solution, but is the safest).
#codereview robert.manuszewski
[CL 2610845 by Steve Robb in Main branch]
Rob asked me to back out GENERATED_*_BODY -> GENERATED_BODY change for now until the "_Validate and _Implementation auto-generation" discussion is over.
#codereview Robert.Manuszewski
[CL 2481343 by Jaroslaw Palczynski in Main branch]
- improvements to debug drawing - a test can declare which level actors it's using and point at them while being selected in the editor
- added a "comment" field in propertied for a quick summary
[CL 2475160 by Mieszko Zielinski in Main branch]
EngineMinimal.h no longer includes SlateCore.h or SlateBasics.h
- This nearly halves the time it takes to recompile small game projects! (~14s -> ~8s)
- This shrinks the PCH size for EngineMinimal by 161 MB on Windows (420 MB -> 259 MB, Development Editor Win64)
- Note that Engine.h and EnginePrivate.h still include SlateCore.h and SlateBasics.h (not a clear detriment)
- IMPORTANT: We need to verify all example games that use this still compile, and add release notes for user games that forgot to include Slate directly
- This is all part of UE-7203
#codereview james.golding,nick.atamas
[CL 2419751 by Ben Marsh in Main branch]
* Multicast delegate Add* calls now return FDelegateHandles, and Remove* calls are now all deprecated, except for a new Remove function which takes a FDelegateHandle.
* New FConsoleManager::RegisterConsoleVariableSink_Handle and UnregisterConsoleVariableSink_Handle functions which work in terms of FConsoleVariableSinkHandle.
* Timer calls which don't take FTimerHandles are deprecated.
* FTicker::AddTicker now returns an FDelegateHandle and is removed by an overloaded Remove function.
* DEFINE_ONLINE_DELEGATE* macros now define _Handle variants of the Add/Remove functions which return/take handles.
* Various other handle-based registration changes.
* Some unity build fixes.
* Some simplification of delegate code.
* Fixes for lots of existing code to use handle-based registration and unregistration.
#codereview robert.manuszewski
[CL 2400883 by Steve Robb in Main branch]
