Commit Graph

13 Commits

Author SHA1 Message Date
Patrick Laflamme
e3298bf3f1 Fixed crash in EditorSessionSummaryWriter if the current session is not created.
- Added null check in case the session creation is delayed because the system wide lock could not be taken at init time.

Fixed the likely cause of unknown exit code reported by CrashReportClientEditor
  - Fixed EditorSessionSummarySenderto loop/wait until system wide lock could be acquired before returning if bForceSendCurrentSession is true.

#jira UE-91160 - Editor Analytics can crash if the session is created late
#rb Jamie.Dale

[CL 12446564 by Patrick Laflamme in 4.25 branch]
2020-03-26 08:27:29 -04:00
Patrick Laflamme
825c626cf9 Improved reliability of the Editor analytics.
- Modified the Editor session to support lockless logging and corresponding analysis for concurrent events.
  - Added null check EditorSessionSummaryWriter::LowDriveSpaceDetected() to prevent accessing a null session.
  - Fixed CrashReportClient that could use the analytic provider outside of init/shutdow
  - Fixed IdleTime reported that could be buggy if Slate did not register any interaction before a crash occurs.

#jira UE-90719 - FPlatformMisc::RequestExit() can corrupt the EditorSessionSummaryWriter
#rb Jamie.Dale

[CL 12350899 by Patrick Laflamme in 4.25 branch]
2020-03-20 17:09:21 -04:00
Patrick Laflamme
4a8093b9ef #jira UE-90364 - CrashReportClientEditor reports the wrong platform (WindowsNoEditor) for the Editor sessions summary
- Fixed the EditorSessionSummarySender to use the FPlatformProperties::IniPlatformName() rather than FPlatformProperties::PlatformName(). Assuming CRC runs on the same platform as the Editor, the platform reported will be "Windows", "Mac" and "Linux".

#rb Wes.Hunt

[CL 12115143 by Patrick Laflamme in 4.25 branch]
2020-03-10 15:30:12 -04:00
Patrick Laflamme
c05f507c5e #jira UE-88250 - Crash Report Client doesn't emits EditorSummaryEvent with proper AppId/AppVersion/SessionId/UserId
- Added AppId, AppVersion and UserId as FEditorAnalyticSession members and updated FEditorSessionSummaryWriter to write them.
  - Changed FEngineAnalytics::GetProvider() to return IAnalyticsProviderET rather than IAnalyticsProvider.
  - Updated FEditorSessionSummarySender to embed the AppId/AppVersion/UserId as attribute when sending the summary event and also configured the AnalyticsProvider to use the SessionID/AppID/AppVersion/UserID of the event rather than the current one.
  - Added a function to return the current IAnalyticProviderET configuration.

#rb Wes.Hunt

Edigrated 11445334 and 11459406.

[CL 11512055 by Patrick Laflamme in 4.25 branch]
2020-02-18 15:12:36 -05:00
JeanMichel Dignard
70d074639f Merging //UE4/Dev-Main @ 10886849 to Dev-Tools-Staging (//UE4/Dev-Tools-Staging)
#rb none
#rnx

[CL 10906274 by JeanMichel Dignard in Dev-Tools-Staging branch]
2020-01-08 13:26:18 -05:00
ryan durand
471d972e62 Updating copyright for Engine Developer.
#rnx
#rb none


#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870584 by ryan durand in Main branch]
2019-12-26 15:32:37 -05:00
Chris Gagnon
346a4b05ea Copy up from Dev-Editor @10681378
#rb none

[CL 10837446 by Chris Gagnon in Dev-Tools-Staging branch]
2019-12-19 18:07:47 -05:00
sebastian nordgren
21b99f6f94 EditorSessionSummary's session duration is now calculated using FPlatformTime::Seconds instead of FDateTime::UtcNow() timestamps, which are not guaranteed by platforms to increase monotonically, leading to outliers with negative session durations.
#jira UE-84232
#rb chris.gagnon, jamie.dale

#ROBOMERGE-SOURCE: CL 10126191 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v587-10111126)

[CL 10126225 by sebastian nordgren in Main branch]
2019-11-13 11:28:09 -05:00
sebastian nordgren
9cc312197a The list of currently-loaded plugins is now written to the editor session analytics payload.
#jira UE-83104
#rb none
[FYI] chris.gagnon

#ROBOMERGE-SOURCE: CL 10004401 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v560-9963197)

[CL 10004403 by sebastian nordgren in Main branch]
2019-11-05 07:04:46 -05:00
Chris Gagnon
d1973355bc Merge Dev-Tools-Stagng tp Dev-Editor
#rb none

[CL 9961726 by Chris Gagnon in Dev-Editor branch]
2019-11-01 17:39:56 -04:00
sebastian nordgren
d7fbf013c6 We now spoof a crash report and send it from the CrashReportClientApp when detecting an abnormal shutdown has occurred. That is to say, a shutdown where, as far as we can tell, no known exit path was followed.
Reverted change to where FCrashReportAnalytics was initialized now that we get those settings from the UECrashContext file.

Added DelayedSend analytics attribute that determines whether or not the process that is sending an analytics event was the same one that created it.

#rb jamie.dale

#jira UETOOL-1826

#ROBOMERGE-SOURCE: CL 9731024 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v539-9700858)

[CL 9731027 by sebastian nordgren in Main branch]
2019-10-21 08:17:44 -04:00
sebastian nordgren
b35c34e1b5 Re-added the low drive space analytics field now that the SessionSummary analytics changes have been brought back into Dev-Editor.
Edigrated changes to analytics from Dev-Core, most notably FEditorSessionSummarySender::FindCurrentSession.

#rb paul.chipchase

[CL 9730821 by sebastian nordgren in Dev-Editor branch]
2019-10-21 06:13:29 -04:00
Stefan Boberg
1f813eb516 Copying //UE4/Dev-Core to Main (//UE4/Main)
#rb many

[CL 9405827 by Stefan Boberg in Main branch]
2019-10-03 16:26:48 -04:00