Commit Graph

7236 Commits

Author SHA1 Message Date
ben marsh
538ac728ad Allow disabling the S3 backend by setting the UE-S3DataCachePath environment variable to "None"
#rb none
#jira

#ROBOMERGE-SOURCE: CL 12486037 via CL 12486375 via CL 12486409 via CL 12486440
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12487544 by ben marsh in Main branch]
2020-03-30 12:12:06 -04:00
ben marsh
6025062ac9 Remove code which specifies -NoCompile when building UAT. This is determined automatically now.
#rb none
#jira UE-89756

#ROBOMERGE-SOURCE: CL 12486154 in //UE4/Release-4.25/... via CL 12486158 via CL 12486161
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12487495 by ben marsh in Main branch]
2020-03-30 12:10:50 -04:00
tim tillotson
f2ccc5a4ed Merging using Dev-Solaris=>FN/Main CL#12453850
#rb none

#ROBOMERGE-OWNER: tim.tillotson
#ROBOMERGE-AUTHOR: tim.tillotson
#ROBOMERGE-SOURCE: CL 12479490 via CL 12479911 via CL 12479912
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12487295 by tim tillotson in Main branch]
2020-03-30 12:03:26 -04:00
lukas hermanns
bea73c96fa Skip "AllDesktop" platform properties as it will be removed soon and causes shader map keys to differ between game and editor modes.
#rb Arciel.Rekman
[FYI] Ben.Ingram, Josh.Adams, Rolando.Caloca
#jira UE-90852
#rnx

#ROBOMERGE-SOURCE: CL 12474319 in //UE4/Release-4.25/... via CL 12474324 via CL 12474328
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12474332 by lukas hermanns in Main branch]
2020-03-27 16:02:53 -04:00
andrew grant
963ad0c629 Allow users to customise S3 path by setting an UE-S3DataCachePath environment variable. If not set the default of ProjectDir/Saved/S3DDC is still used
#rb swarm
[at]devin.doucette [at]ben.marsh
[FYI] antoine.guilbaud
#tests Booted editor and PIE'd into AthenaTest with UE-S3DataCachePath set to a different drive. Verified data is there.

#ROBOMERGE-SOURCE: CL 12474206 via CL 12474221 via CL 12474232 via CL 12474240
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12474252 by andrew grant in Main branch]
2020-03-27 15:57:11 -04:00
andrew grant
95b59e82f4 Fixed a... typo? bad resolve? that was causing new data not to be written to DDC caches
[FYI] uriel.doyon, devin.doucette
#rb uriel.doyon

#ROBOMERGE-SOURCE: CL 12473303 via CL 12473315 via CL 12473325 via CL 12473327
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12473331 by andrew grant in Main branch]
2020-03-27 14:57:01 -04:00
andrew grant
6a3a6a6425 Temp workaround for FORT-273296 while I investigate why ShaderCompiler on Mac doesn't like the speed test option.
[FYI] stefan.boberg
#rb na
#tests compiled SCW and booted into editor with -noshaderddc to force shader compiles

#ROBOMERGE-SOURCE: CL 12466138 via CL 12468387 via CL 12468494 via CL 12468566
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12468580 by andrew grant in Main branch]
2020-03-27 11:20:28 -04:00
andrew grant
14d1b683f8 Moved some DDC debug options into a common class that can be provided to a backend to simulate certain behavior.
E.g.

'-ddc-local-missrate=50' simulates a 50% miss rate of keys on the local backend,
'-ddc-shared-misstypes=AnimSeq' simulates misses for any AnimSeq key. Use + to combine keys. E.g. AnimSeq+Audio

Memory DDC, FileSystemDDC and S3DDC support these options as do the classes that wrap other backends (e.g. AsyncPut).

#tests lots of warm and cold DDC
#swarm https://p4-swarm.epicgames.net/reviews/12458696

#ROBOMERGE-SOURCE: CL 12466119 via CL 12466177
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12466179 by andrew grant in Main branch]
2020-03-27 08:12:16 -04:00
andrew grant
e224300cc3 Moved some DDC debug options into a common class that can be provided to a backend to simulate certain behavior.
E.g.

'-ddc-local-missrate=50' simulates a 50% miss rate of keys on the local backend,
'-ddc-shared-misstypes=AnimSeq' simulates misses for any AnimSeq key. Use + to combine keys. E.g. AnimSeq+Audio

Memory DDC, FileSystemDDC and S3DDC support these options as do the classes that wrap other backends (e.g. AsyncPut).

#tests lots of warm and cold DDC
[at]ben.marsh [at]josh.engebretson [at]devin.doucette

#ROBOMERGE-SOURCE: CL 12458693 via CL 12462167 via CL 12464485 via CL 12464606
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12464717 by andrew grant in Main branch]
2020-03-26 20:55:39 -04:00
ben marsh
a4c0ecd2eb Suppressing errors about S3DDC if disabled.
#jira

#ROBOMERGE-SOURCE: CL 12455905 via CL 12455924 via CL 12455926 via CL 12460993 via CL 12461148
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12461272 by ben marsh in Main branch]
2020-03-26 17:59:17 -04:00
ben marsh
604cd08968 Enable S3DDC by default if available, with a check for canary file not reachable from internal IPs. Also add an editor setting (in the Global panel) for disabling it.
Also suppress some warning messages when a download is cancelled.

[FYI] Andrew.Grant
#jira

#ROBOMERGE-OWNER: ben.marsh
#ROBOMERGE-AUTHOR: ben.marsh
#ROBOMERGE-SOURCE: CL 12453891 via CL 12454085 via CL 12454109 via CL 12459232 via CL 12459415
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v672-12450963)

[CL 12459547 by ben marsh in Main branch]
2020-03-26 17:03:08 -04:00
jurre debaare
fd0557a297 Editor Unreal Insights creates a malformed EditorLayout.ini, StartPage defined and duplicated Area entries
#fix ensure that the global tab manager is not restored using the UnrealInsights ini layout data, which was growing the closed docking areas and therefore the EditorLayout.ini itself
#jira UE-91177
#rb Ionut.Matasaru

#ROBOMERGE-SOURCE: CL 12453643 in //UE4/Release-4.25/... via CL 12453644
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v672-12450963)

[CL 12453652 by jurre debaare in Release-Engine-Staging branch]
2020-03-26 14:04:26 -04:00
Jurre deBaare
c3f3f7b7a0 Editor Unreal Insights creates a malformed EditorLayout.ini, StartPage defined and duplicated Area entries
#fix ensure that the global tab manager is not restored using the UnrealInsights ini layout data, which was growing the closed docking areas and therefore the EditorLayout.ini itself
#jira UE-91177
#rb Ionut.Matasaru

[CL 12453643 by Jurre deBaare in 4.25 branch]
2020-03-26 14:03:45 -04:00
thomas sarkanen
d6c1fa52b4 Fixed crash when moving/renaming anim blueprints
The FProperty refactor converted all UStructProperty* values into TFieldPaths, but the data is not serialized except in the case of UAnimClassData (for nativizaton). This reverts the various property arrays back to using FStructProperty*, which not only fixes some performance issues, but also prevents relocated data from pointing at incorrect locations when loaded assets are reloacated byt Link() is not subsequently called.

Fixed UAnimClassData (used in nativized builds) to correctly store and patch up anim blueprint functions.

#jira UE-91009 - [CrashReport] UE4Editor-Engine!FAnimInstanceProxy::InitializeRootNode(bool) [AnimInstanceProxy.cpp:201]
#rb Aaron.Cox,Jurre.deBaare,Robert.Manuszewski

#ROBOMERGE-SOURCE: CL 12451001 in //UE4/Release-4.25/... via CL 12451003
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)

[CL 12451013 by thomas sarkanen in Release-Engine-Staging branch]
2020-03-26 10:48:40 -04:00
Thomas Sarkanen
4fe332e775 Fixed crash when moving/renaming anim blueprints
The FProperty refactor converted all UStructProperty* values into TFieldPaths, but the data is not serialized except in the case of UAnimClassData (for nativizaton). This reverts the various property arrays back to using FStructProperty*, which not only fixes some performance issues, but also prevents relocated data from pointing at incorrect locations when loaded assets are reloacated byt Link() is not subsequently called.

Fixed UAnimClassData (used in nativized builds) to correctly store and patch up anim blueprint functions.

#jira UE-91009 - [CrashReport] UE4Editor-Engine!FAnimInstanceProxy::InitializeRootNode(bool) [AnimInstanceProxy.cpp:201]
#rb Aaron.Cox,Jurre.deBaare,Robert.Manuszewski

[CL 12451001 by Thomas Sarkanen in 4.25 branch]
2020-03-26 10:47:56 -04:00
patrick laflamme
93a767a9b8 Fixed crash in EditorSessionSummaryWriter if the current session is not created.
- Added null check in case the session creation is delayed because the system wide lock could not be taken at init time.

Fixed the likely cause of unknown exit code reported by CrashReportClientEditor
  - Fixed EditorSessionSummarySenderto loop/wait until system wide lock could be acquired before returning if bForceSendCurrentSession is true.

#jira UE-91160 - Editor Analytics can crash if the session is created late
#rb Jamie.Dale

#ROBOMERGE-SOURCE: CL 12446564 in //UE4/Release-4.25/... via CL 12446576
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)

[CL 12446629 by patrick laflamme in Release-Engine-Staging branch]
2020-03-26 08:28:22 -04:00
Patrick Laflamme
e3298bf3f1 Fixed crash in EditorSessionSummaryWriter if the current session is not created.
- Added null check in case the session creation is delayed because the system wide lock could not be taken at init time.

Fixed the likely cause of unknown exit code reported by CrashReportClientEditor
  - Fixed EditorSessionSummarySenderto loop/wait until system wide lock could be acquired before returning if bForceSendCurrentSession is true.

#jira UE-91160 - Editor Analytics can crash if the session is created late
#rb Jamie.Dale

[CL 12446564 by Patrick Laflamme in 4.25 branch]
2020-03-26 08:27:29 -04:00
andrew grant
178b067378 Temporrily disabling filesystem DDC optimization that breaks virtual texturing
[FYI] jeremy.moore
#rb na


#ROBOMERGE-SOURCE: CL 12420666 via CL 12425989 via CL 12436837
#ROBOMERGE-BOT: (v671-12333473)

[CL 12442290 by andrew grant in Release-Engine-Staging branch]
2020-03-26 07:31:34 -04:00
mihnea balta
2f05ece9f3 Fixed crash when using a loop with more than 32 iterations in custom HLSL.
The default threshold for loop unrolling was 32, so the compiler tried to make a dynamic loop when we had more iterations. The vector VM doesn't support that, so the codegen was never designed to understand dynamic loops, leading to an assertion failure. Increased the threshold to a large value, so we never hit this problem in practice.

#rnx
#jira none
#rb none

#ROBOMERGE-SOURCE: CL 12422302 in //UE4/Release-4.25/... via CL 12422324
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)

[CL 12426823 by mihnea balta in Release-Engine-Staging branch]
2020-03-25 14:07:16 -04:00
ionut matasaru
bcf53f8828 Fixed static analysis warning (UE-91127).
#rb none
#jira UE-91127

#ROBOMERGE-SOURCE: CL 12402441 in //UE4/Release-4.25/... via CL 12402442
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)

[CL 12425635 by ionut matasaru in Release-Engine-Staging branch]
2020-03-25 13:45:49 -04:00
mihnea balta
7f1a18cebc Fixed crash when using a loop with more than 32 iterations in custom HLSL.
The default threshold for loop unrolling was 32, so the compiler tried to make a dynamic loop when we had more iterations. The vector VM doesn't support that, so the codegen was never designed to understand dynamic loops, leading to an assertion failure. Increased the threshold to a large value, so we never hit this problem in practice.

#rnx
#jira none
#rb none

[CL 12422302 by mihnea balta in 4.25 branch]
2020-03-25 13:14:27 -04:00
ben marsh
ff0c64df6d Fix some non-unity issues building LiveCodingConsole.
#rb none
#rnx
#jira

#ROBOMERGE-SOURCE: CL 12394810 in //UE4/Release-4.25/... via CL 12394948
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)

[CL 12419899 by ben marsh in Release-Engine-Staging branch]
2020-03-25 12:22:58 -04:00
ionut matasaru
fbb56dce6b [Insights]
- NetProfiler: Fixed computation of Exclusive size aggregated stats (UE-91087).
  - Net / Packets view: Fixed Ctrl+A not triggering the update of aggregated stats if no packet was previously selected (UE-91067).
#jira UE-91087, UE-91067
#rb Mattias.Hornlund

#ROBOMERGE-SOURCE: CL 12389037 in //UE4/Release-4.25/... via CL 12389039
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)

[CL 12403447 by ionut matasaru in Release-Engine-Staging branch]
2020-03-25 10:29:37 -04:00
ionut matasaru
afd5c49757 Fixed static analysis warning (UE-91127).
#rb none
#jira UE-91127

[CL 12402441 by ionut matasaru in 4.25 branch]
2020-03-25 09:04:02 -04:00
dmitriy dyomin
533509d73b Add an option to downscale textures without mips. Accepts values between 1.0 and 8.0.
Can be overriden per-platform, for a specifc texture or texture group.
Downscaling will keep texure size divisible by 4 so they can still be compressed
#rb chris.bunner


#ROBOMERGE-SOURCE: CL 12400453 via CL 12400465 via CL 12400467
#ROBOMERGE-BOT: (v671-12333473)

[CL 12402238 by dmitriy dyomin in Release-Engine-Staging branch]
2020-03-25 08:18:43 -04:00